pokecrystal/constants/sfx_constants.asm, branch master

Revise some constant definitions

2021-03-16T22:06:18+00:00

Verify data table sizes with table_width and assert_table_length macros

2021-03-04T05:15:03+00:00

This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739

Clarify naming of SFX_GET_EGG_* pointers

2019-09-23T17:03:19+00:00

In game, one receives eggs from the Aide and the Day-care Man, not the
Day-care Lady. SFX `0x96` is used for both. Rename it to reflect it is
not unique to the Day-care.

SFX `0x95` is an alias of the same sound and appears to be unused.
Rename the pointer to clarify that.

Fix some constants

2019-01-15T12:06:16+00:00

Glass ting SFX were added in crystal.
PicAnimations and UnownAnimations are expected to be in the same bank as
their pointers, because the pointers are not BANK()-referenced
separately.

SFX_UNKNOWN_7F → SFX_TOXIC

2018-07-12T16:25:17+00:00

Replace more hex values with constants or decimal

2018-07-11T19:40:09+00:00

wiggle → wobble

2018-01-19T05:16:08+00:00

Consistent capitalization for map names, matching their constants

2017-12-10T18:37:15+00:00

Document constants with comments, actual names, and more thorough usage

2017-12-09T07:15:46+00:00

Fix marts using hard-coded bank number

2016-01-27T17:25:12+00:00