diff options
Diffstat (limited to 'engine/battle')
| -rwxr-xr-x | engine/battle/anim_hp_bar.asm | 5 | ||||
| -rw-r--r-- | engine/battle/effect_commands.asm | 4 |
2 files changed, 5 insertions, 4 deletions
diff --git a/engine/battle/anim_hp_bar.asm b/engine/battle/anim_hp_bar.asm index 7d51a8629..5c453d0ff 100755 --- a/engine/battle/anim_hp_bar.asm +++ b/engine/battle/anim_hp_bar.asm @@ -384,8 +384,9 @@ ShortHPBar_CalcPixelFrame: ; d839 call AddNTimes ld b, 0 -; This routine is buggy. If [wCurHPAnimMaxHP] * [wCurHPBarPixels] is divisible -; by 48, the loop runs one extra time. To fix, uncomment the line below. +; This routine is buggy. If [wCurHPAnimMaxHP] * [wCurHPBarPixels] is +; divisible by HP_BAR_LENGTH_PX, the loop runs one extra time. +; To fix, uncomment the line below. .loop ld a, l sub HP_BAR_LENGTH_PX diff --git a/engine/battle/effect_commands.asm b/engine/battle/effect_commands.asm index e19bdaacc..d4a3c9446 100644 --- a/engine/battle/effect_commands.asm +++ b/engine/battle/effect_commands.asm @@ -1504,8 +1504,8 @@ BattleCheckTypeMatchup: ; 347c8 ld hl, wBattleMonType1 CheckTypeMatchup: ; 347d3 ; There is an incorrect assumption about this function made in the AI related code: when -; the AI calls CheckTypeMatchup (not BattleCheckTypeMatchup), it assumes that placing -; the offensive type in a will make this function do the right thing. Since a is overwritten, +; the AI calls CheckTypeMatchup (not BattleCheckTypeMatchup), it assumes that placing the +; offensive type in a will make this function do the right thing. Since a is overwritten, ; this assumption is incorrect. A simple fix would be to load the move type for the ; current move into a in BattleCheckTypeMatchup, before falling through, which is ; consistent with how the rest of the code assumes this code works like. |