diff options
Diffstat (limited to 'engine')
| -rwxr-xr-x | engine/clock_reset.asm | 18 | ||||
| -rw-r--r-- | engine/credits.asm | 2 | ||||
| -rwxr-xr-x | engine/decorations.asm | 22 | ||||
| -rwxr-xr-x | engine/link.asm | 2 | ||||
| -rwxr-xr-x | engine/mart.asm | 12 | ||||
| -rwxr-xr-x | engine/mysterygift2.asm | 2 | ||||
| -rwxr-xr-x | engine/pokegear.asm | 161 | ||||
| -rwxr-xr-x | engine/printnum.asm | 2 | ||||
| -rw-r--r-- | engine/scripting.asm | 10 | ||||
| -rwxr-xr-x | engine/startmenu.asm | 6 | ||||
| -rwxr-xr-x | engine/stats_screen.asm | 12 | ||||
| -rwxr-xr-x | engine/unowndex.asm | 2 | ||||
| -rwxr-xr-x | engine/warp_connection.asm | 2 | 
13 files changed, 123 insertions, 130 deletions
| diff --git a/engine/clock_reset.asm b/engine/clock_reset.asm index 4e6f588e9..7b1d84302 100755 --- a/engine/clock_reset.asm +++ b/engine/clock_reset.asm @@ -66,7 +66,7 @@ RestartClock: ; 20021 (8:4021)  .SetClock: ; 20051 (8:4051)  	ld a, 1  	ld [Buffer1], a ; which digit -	ld [Buffer2], a ; wd1eb (aliases: MovementType) +	ld [Buffer2], a  	ld a, 8  	ld [Buffer3], a  	call UpdateTime @@ -151,7 +151,7 @@ RestartClock: ; 20021 (8:4021)  	ret  .pressed_up -	ld a, [Buffer1] ; wd1ea (aliases: MagikarpLength) +	ld a, [Buffer1]  	call ResetClock_GetWraparoundTime  	ld a, [de]  	inc a @@ -163,7 +163,7 @@ RestartClock: ; 20021 (8:4021)  	jr .done_scroll  .pressed_down -	ld a, [Buffer1] ; wd1ea (aliases: MagikarpLength) +	ld a, [Buffer1]  	call ResetClock_GetWraparoundTime  	ld a, [de]  	dec a @@ -176,14 +176,14 @@ RestartClock: ; 20021 (8:4021)  	jr .done_scroll  .pressed_left -	ld hl, Buffer1 ; wd1ea (aliases: MagikarpLength) +	ld hl, Buffer1  	dec [hl]  	jr nz, .done_scroll  	ld [hl], $3  	jr .done_scroll  .pressed_right -	ld hl, Buffer1 ; wd1ea (aliases: MagikarpLength) +	ld hl, Buffer1  	inc [hl]  	ld a, [hl]  	cp $4 @@ -209,14 +209,14 @@ RestartClock: ; 20021 (8:4021)  	ld c, a  	decoord 11, 8  	callba PrintHoursMins -	ld a, [Buffer2] ; wd1eb (aliases: MovementType) +	ld a, [Buffer2]  	lb de, " ", " "  	call .PlaceChars -	ld a, [Buffer1] ; wd1ea (aliases: MagikarpLength) +	ld a, [Buffer1]  	lb de, "▲", "▼"  	call .PlaceChars -	ld a, [Buffer1] ; wd1ea (aliases: MagikarpLength) -	ld [Buffer2], a ; wd1eb (aliases: MovementType) +	ld a, [Buffer1] +	ld [Buffer2], a  	ret  ; 20160 (8:4160) diff --git a/engine/credits.asm b/engine/credits.asm index 3442d4f16..823bcde3a 100644 --- a/engine/credits.asm +++ b/engine/credits.asm @@ -196,7 +196,7 @@ Credits:: ; 109847  	xor a  	ld [hBGMapMode], a  	ld [CreditsPos], a -	ld [wcd21], a +	ld [CreditsUnusedCD21], a  	ld [CreditsTimer], a  .execution_loop diff --git a/engine/decorations.asm b/engine/decorations.asm index 4bd99c0a5..ad82a2080 100755 --- a/engine/decorations.asm +++ b/engine/decorations.asm @@ -908,16 +908,16 @@ DecoAction_putawayornament: ; 26dc9  DecoAction_FinishUp_Ornament: ; 26dd6  	call QueryWhichSide -	ld a, [wd1ec] +	ld a, [wSelectedDecoration]  	ld [hl], a -	ld a, [wd1ed] +	ld a, [wOtherDecoration]  	ld [de], a  	xor a  	ret  ; 26de3  DecoAction_SetItUp_Ornament: ; 26de3 -	ld a, [wd1ec] +	ld a, [wSelectedDecoration]  	and a  	jr z, .nothingthere  	ld b, a @@ -931,7 +931,7 @@ DecoAction_SetItUp_Ornament: ; 26de3  	ld hl, StringBuffer4  	call GetDecorationName  	ld a, [MenuSelection] -	ld [wd1ec], a +	ld [wSelectedDecoration], a  	call .getwhichside  	ld hl, DecoText_PutAwayAndSetUp  	call MenuTextBoxBackup @@ -940,7 +940,7 @@ DecoAction_SetItUp_Ornament: ; 26de3  .nothingthere  	ld a, [MenuSelection] -	ld [wd1ec], a +	ld [wSelectedDecoration], a  	call .getwhichside  	ld a, [MenuSelection]  	ld hl, StringBuffer3 @@ -960,11 +960,11 @@ DecoAction_SetItUp_Ornament: ; 26de3  .getwhichside ; 26e33  	ld a, [MenuSelection]  	ld b, a -	ld a, [wd1ed] +	ld a, [wOtherDecoration]  	cp b  	ret nz  	xor a -	ld [wd1ed], a +	ld [wOtherDecoration], a  	ret  ; 26e41 @@ -975,7 +975,7 @@ UnknownText_0x26e41: ; 0x26e41  ; 0x26e46  DecoAction_PutItAway_Ornament: ; 26e46 -	ld a, [wd1ec] +	ld a, [wSelectedDecoration]  	and a  	jr z, .nothingthere  	ld hl, StringBuffer3 @@ -983,7 +983,7 @@ DecoAction_PutItAway_Ornament: ; 26e46  	ld a, $1  	ld [Buffer5], a  	xor a -	ld [wd1ec], a +	ld [wSelectedDecoration], a  	ld hl, DecoText_PutAwayTheDeco  	call MenuTextBoxBackup  	xor a @@ -1015,9 +1015,9 @@ DecoAction_AskWhichSide: ; 26e70  	ld [Buffer2], a  	call QueryWhichSide  	ld a, [hl] -	ld [wd1ec], a +	ld [wSelectedDecoration], a  	ld a, [de] -	ld [wd1ed], a +	ld [wOtherDecoration], a  	xor a  	ret diff --git a/engine/link.asm b/engine/link.asm index ad2d8a982..ab3d38968 100755 --- a/engine/link.asm +++ b/engine/link.asm @@ -390,7 +390,7 @@ Gen2ToGen2LinkComms: ; 28177  	ld [de], a  .skip_mail -	ld hl, wLinkData +	ld hl, wLinkPlayerName  	ld de, OTPlayerName  	ld bc, NAME_LENGTH  	call CopyBytes diff --git a/engine/mart.asm b/engine/mart.asm index 7002902cc..6bcec4c55 100755 --- a/engine/mart.asm +++ b/engine/mart.asm @@ -370,9 +370,9 @@ BuyMenu: ; 15c62  	call FadeToMenu  	callba BlankScreen  	xor a -	ld [wd045 + 1], a +	ld [wMenuScrollPositionBackup], a  	ld a, 1 -	ld [wd045], a +	ld [wMenuCursorBufferBackup], a  .loop  	call BuyMenuLoop ; menu loop  	jr nc, .loop @@ -471,15 +471,15 @@ BuyMenuLoop: ; 15cef  	call UpdateSprites  	ld hl, MenuDataHeader_Buy  	call CopyMenuDataHeader -	ld a, [wd045] +	ld a, [wMenuCursorBufferBackup]  	ld [wMenuCursorBuffer], a -	ld a, [wd045 + 1] +	ld a, [wMenuScrollPositionBackup]  	ld [wMenuScrollPosition], a  	call ScrollingMenu  	ld a, [wMenuScrollPosition] -	ld [wd045 + 1], a +	ld [wMenuScrollPositionBackup], a  	ld a, [wMenuCursorY] -	ld [wd045], a +	ld [wMenuCursorBufferBackup], a  	call SpeechTextBox  	ld a, [wMenuJoypad]  	cp B_BUTTON diff --git a/engine/mysterygift2.asm b/engine/mysterygift2.asm index 4048ea533..0b8948c5b 100755 --- a/engine/mysterygift2.asm +++ b/engine/mysterygift2.asm @@ -9,7 +9,7 @@ PrepMysteryGiftDataToSend: ; 2c642 (b:4642)  	ld a, [hli]  	ld [de], a  	ld b, a -	inc de +	inc de ; wc802  	ld a, [hl]  	ld [de], a  	ld c, a diff --git a/engine/pokegear.asm b/engine/pokegear.asm index dadee0629..948589639 100755 --- a/engine/pokegear.asm +++ b/engine/pokegear.asm @@ -1619,8 +1619,8 @@ RadioChannels:  LoadStation_OaksPokemonTalk: ; 91753 (24:5753)  	xor a ; OAKS_POKEMON_TALK -	ld [wd002], a -	ld [wd005], a +	ld [wCurrentRadioLine], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1629,9 +1629,9 @@ LoadStation_OaksPokemonTalk: ; 91753 (24:5753)  LoadStation_PokedexShow: ; 91766 (24:5766)  	ld a, POKEDEX_SHOW -	ld [wd002], a +	ld [wCurrentRadioLine], a  	xor a -	ld [wd005], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1640,9 +1640,9 @@ LoadStation_PokedexShow: ; 91766 (24:5766)  LoadStation_PokemonMusic: ; 9177b (24:577b)  	ld a, POKEMON_MUSIC -	ld [wd002], a +	ld [wCurrentRadioLine], a  	xor a -	ld [wd005], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1651,9 +1651,9 @@ LoadStation_PokemonMusic: ; 9177b (24:577b)  LoadStation_LuckyChannel: ; 91790 (24:5790)  	ld a, LUCKY_CHANNEL -	ld [wd002], a +	ld [wCurrentRadioLine], a  	xor a -	ld [wd005], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1662,9 +1662,9 @@ LoadStation_LuckyChannel: ; 91790 (24:5790)  LoadStation_BuenasPassword: ; 917a5 (24:57a5)  	ld a, BUENAS_PASSWORD -	ld [wd002], a +	ld [wCurrentRadioLine], a  	xor a -	ld [wd005], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1682,9 +1682,9 @@ NotBuenasPasswordName: db "@"  LoadStation_UnownRadio: ; 917d5 (24:57d5)  	ld a, UNOWN_RADIO -	ld [wd002], a +	ld [wCurrentRadioLine], a  	xor a -	ld [wd005], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1693,9 +1693,9 @@ LoadStation_UnownRadio: ; 917d5 (24:57d5)  LoadStation_PlacesAndPeople: ; 917ea (24:57ea)  	ld a, PLACES_AND_PEOPLE -	ld [wd002], a +	ld [wCurrentRadioLine], a  	xor a -	ld [wd005], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1704,9 +1704,9 @@ LoadStation_PlacesAndPeople: ; 917ea (24:57ea)  LoadStation_LetsAllSing: ; 917ff (24:57ff)  	ld a, LETS_ALL_SING -	ld [wd002], a +	ld [wCurrentRadioLine], a  	xor a -	ld [wd005], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1717,9 +1717,9 @@ LoadStation_LetsAllSing: ; 917ff (24:57ff)  LoadStation_RocketRadio: ; 91814  	ld a, ROCKET_RADIO -	ld [wd002], a +	ld [wCurrentRadioLine], a  	xor a -	ld [wd005], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1730,9 +1730,9 @@ LoadStation_RocketRadio: ; 91814  LoadStation_PokeFluteRadio: ; 91829 (24:5829)  	ld a, POKE_FLUTE_RADIO -	ld [wd002], a +	ld [wCurrentRadioLine], a  	xor a -	ld [wd005], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1741,9 +1741,9 @@ LoadStation_PokeFluteRadio: ; 91829 (24:5829)  LoadStation_EvolutionRadio: ; 9183e (24:583e)  	ld a, EVOLUTION_RADIO -	ld [wd002], a +	ld [wCurrentRadioLine], a  	xor a -	ld [wd005], a +	ld [wNumRadioLinesPrinted], a  	ld a, BANK(PlayRadioShow)  	ld hl, PlayRadioShow  	call Radio_BackUpFarCallParams @@ -1855,20 +1855,20 @@ _TownMap: ; 9191c  	ld a, $e3  	ld [rLCDC], a  	call TownMap_GetCurrentLandmark -	ld [wd002], a -	ld [wd003], a +	ld [wTownMapPlayerIconLandmark], a +	ld [wTownMapCursorLandmark], a  	xor a  	ld [hBGMapMode], a  	call .InitTilemap  	call WaitBGMap2 -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	call PokegearMap_InitPlayerIcon -	ld a, [wd003] +	ld a, [wTownMapCursorLandmark]  	call PokegearMap_InitCursor  	ld a, c -	ld [wd004], a +	ld [wTownMapCursorObjectPointer], a  	ld a, b -	ld [wd005], a +	ld [wTownMapCursorObjectPointer + 1], a  	ld b, SCGB_POKEGEAR_PALS  	call GetSGBLayout  	call SetPalettes @@ -1880,7 +1880,7 @@ _TownMap: ; 9191c  	call DelayFrame  .dmg -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	cp KANTO_LANDMARK  	jr nc, .kanto  	ld d, KANTO_LANDMARK - 1 @@ -1925,7 +1925,7 @@ _TownMap: ; 9191c  	jr .loop  .pressed_up -	ld hl, wd003 +	ld hl, wTownMapCursorLandmark  	ld a, [hl]  	cp d  	jr c, .okay @@ -1938,7 +1938,7 @@ _TownMap: ; 9191c  	jr .next  .pressed_down -	ld hl, wd003 +	ld hl, wTownMapCursorLandmark  	ld a, [hl]  	cp e  	jr nz, .okay2 @@ -1951,20 +1951,20 @@ _TownMap: ; 9191c  .next  	push de -	ld a, [wd003] +	ld a, [wTownMapCursorLandmark]  	call PokegearMap_UpdateLandmarkName -	ld a, [wd004] +	ld a, [wTownMapCursorObjectPointer]  	ld c, a -	ld a, [wd005] +	ld a, [wTownMapCursorObjectPointer + 1]  	ld b, a -	ld a, [wd003] +	ld a, [wTownMapCursorLandmark]  	call PokegearMap_UpdateCursorPosition  	pop de  	jr .loop2  ; 91a04  .InitTilemap: ; 91a04 -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	cp KANTO_LANDMARK  	jr nc, .kanto2  	ld e, $0 @@ -1992,7 +1992,7 @@ _TownMap: ; 9191c  	call ByteFill  	hlcoord 19, 2  	ld [hl], $17 -	ld a, [wd003] +	ld a, [wTownMapCursorLandmark]  	call PokegearMap_UpdateLandmarkName  	callba TownMapPals  	ret @@ -2147,7 +2147,7 @@ _FlyMap: ; 91af3  	jr .exit  .pressedA -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	ld l, a  	ld h, 0  	add hl, hl @@ -2155,7 +2155,7 @@ _FlyMap: ; 91af3  	add hl, de  	ld a, [hl]  .exit -	ld [wd002], a +	ld [wTownMapPlayerIconLandmark], a  	pop af  	ld [hInMenu], a  	call ClearBGPalettes @@ -2165,7 +2165,7 @@ _FlyMap: ; 91af3  	ld [hBGMapAddress], a  	ld a, VBGMap0 / $100  	ld [hBGMapAddress + 1], a -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	ld e, a  	ret @@ -2186,7 +2186,7 @@ FlyMapScroll: ; 91b73  	ret  .ScrollNext: -	ld hl, wd002 +	ld hl, wTownMapPlayerIconLandmark  	ld a, [hl]  	cp d  	jr nz, .NotAtEndYet @@ -2200,7 +2200,7 @@ FlyMapScroll: ; 91b73  	jr .Finally  .ScrollPrev: -	ld hl, wd002 +	ld hl, wTownMapPlayerIconLandmark  	ld a, [hl]  	cp e  	jr nz, .NotAtStartYet @@ -2269,7 +2269,7 @@ TownMapBubble: ; 91bb5  .Name:  ; We need the map location of the default flypoint -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	ld l, a  	ld h, 0  	add hl, hl ; two bytes per flypoint @@ -2285,7 +2285,7 @@ TownMapBubble: ; 91bb5  ; 91c17  GetMapCursorCoordinates: ; 91c17 -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	ld l, a  	ld h, $0  	add hl, hl @@ -2293,9 +2293,9 @@ GetMapCursorCoordinates: ; 91c17  	add hl, de  	ld e, [hl]  	callba GetLandmarkCoords -	ld a, [wd003] +	ld a, [wTownMapCursorCoordinates]  	ld c, a -	ld a, [wd004] +	ld a, [wTownMapCursorCoordinates + 1]  	ld b, a  	ld hl, $4  	add hl, bc @@ -2389,8 +2389,7 @@ FlyMap: ; 91c90  	ld c, a  	call GetWorldMapLocation  ; If we're not in a valid location, i.e. Pokecenter floor 2F, - -; the backup map information is used +; the backup map information is used.  	cp SPECIAL_MAP  	jr nz, .CheckRegion  	ld a, [BackupMapGroup] @@ -2399,7 +2398,7 @@ FlyMap: ; 91c90  	ld c, a  	call GetWorldMapLocation  .CheckRegion: -; The first 46 locations are part of Johto. The rest are in Kanto +; The first 46 locations are part of Johto. The rest are in Kanto.  	cp KANTO_LANDMARK  	jr nc, .KantoFlyMap  .JohtoFlyMap: @@ -2407,10 +2406,10 @@ FlyMap: ; 91c90  	push af  ; Start from New Bark Town  	ld a, FLY_NEW_BARK -	ld [wd002], a +	ld [wTownMapPlayerIconLandmark], a  ; Flypoints begin at New Bark Town...  	ld [StartFlypoint], a -; ..and end at Silver Cave +; ..and end at Silver Cave.  	ld a, FLY_MT_SILVER  	ld [EndFlypoint], a  ; Fill out the map @@ -2422,17 +2421,13 @@ FlyMap: ; 91c90  .KantoFlyMap:  ; The event that there are no flypoints enabled in a map is not -  ; accounted for. As a result, if you attempt to select a flypoint  ; when there are none enabled, the game will crash. Additionally, -  ; the flypoint selection has a default starting point that -; can be flown to even if none are enabled - +; can be flown to even if none are enabled.  ; To prevent both of these things from happening when the player  ; enters Kanto, fly access is restricted until Indigo Plateau is - -; visited and its flypoint enabled +; visited and its flypoint enabled.  	push af  	ld c, SPAWN_INDIGO  	call HasVisitedSpawn @@ -2447,9 +2442,8 @@ FlyMap: ; 91c90  	ld a, FLY_INDIGO  	ld [EndFlypoint], a  ; Because Indigo Plateau is the first flypoint the player - -; visits, it's made the default flypoint -	ld [wd002], a +; visits, it's made the default flypoint. +	ld [wTownMapPlayerIconLandmark], a  ; Fill out the map  	call FillKantoMap  	call .MapHud @@ -2462,7 +2456,7 @@ FlyMap: ; 91c90  ; Start from New Bark Town  	ld a, FLY_NEW_BARK -	ld [wd002], a +	ld [wTownMapPlayerIconLandmark], a  ; Flypoints begin at New Bark Town...  	ld [StartFlypoint], a  ; ..and end at Silver Cave @@ -2477,21 +2471,21 @@ FlyMap: ; 91c90  	call TownMapBGUpdate  	call TownMapMon  	ld a, c -	ld [wd003], a +	ld [wTownMapCursorCoordinates], a  	ld a, b -	ld [wd004], a +	ld [wTownMapCursorCoordinates + 1], a  	ret  ; 91d11  _Area: ; 91d11  ; e: Current landmark -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	push af -	ld a, [wd003] +	ld a, [wTownMapCursorLandmark]  	push af  	ld a, e -	ld [wd002], a +	ld [wTownMapPlayerIconLandmark], a  	call ClearSprites  	xor a  	ld [hBGMapMode], a @@ -2545,9 +2539,9 @@ _Area: ; 91d11  .a_b  	call ClearSprites  	pop af -	ld [wd003], a +	ld [wTownMapCursorLandmark], a  	pop af -	ld [wd002], a +	ld [wTownMapPlayerIconLandmark], a  	ret  ; 91d9b @@ -2636,7 +2630,7 @@ _Area: ; 91d11  ; 91e1e  .GetAndPlaceNest: ; 91e1e -	ld [wd003], a +	ld [wTownMapCursorLandmark], a  	ld e, a  	callba FindNest ; load nest landmarks into TileMap[0,0]  	decoord 0, 0 @@ -2678,7 +2672,7 @@ _Area: ; 91d11  .HideNestsShowPlayer: ; 91e5a  	call .CheckPlayerLocation  	ret c -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	ld e, a  	callba GetLandmarkCoords  	ld c, e @@ -2731,22 +2725,21 @@ _Area: ; 91d11  .CheckPlayerLocation: ; 91ea9  ; Don't show the player's sprite if you're -  ; not in the same region as what's currently  ; on the screen. -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	cp FAST_SHIP  	jr z, .johto  	cp KANTO_LANDMARK  	jr c, .johto  .kanto -	ld a, [wd003] +	ld a, [wTownMapCursorLandmark]  	and a  	jr z, .clear  	jr .ok  .johto -	ld a, [wd003] +	ld a, [wTownMapCursorLandmark]  	and a  	jr nz, .clear  .ok @@ -2764,7 +2757,7 @@ _Area: ; 91d11  ; 91ed0  .GetPlayerOrFastShipIcon: ; 91ed0 -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	cp FAST_SHIP  	jr z, .FastShip  	callba GetPlayerIcon @@ -2991,7 +2984,7 @@ INCBIN "gfx/pokegear/flymap_label_border.1bpp"  ; XXX  	xor a -	ld [wd002], a +	ld [wTownMapPlayerIconLandmark], a  	call ClearBGPalettes  	call ClearTileMap  	call ClearSprites @@ -3019,9 +3012,9 @@ INCBIN "gfx/pokegear/flymap_label_border.1bpp"  	call TownMapBGUpdate  	call TownMapMon  	ld a, c -	ld [wd003], a +	ld [wTownMapCursorCoordinates], a  	ld a, b -	ld [wd004], a +	ld [wTownMapCursorCoordinates + 1], a  	ld b, SCGB_POKEGEAR_PALS  	call GetSGBLayout  	call SetPalettes @@ -3045,7 +3038,7 @@ INCBIN "gfx/pokegear/flymap_label_border.1bpp"  	jr .finished_a_b  .pressedA -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	ld l, a  	ld h, 0  	add hl, hl @@ -3053,7 +3046,7 @@ INCBIN "gfx/pokegear/flymap_label_border.1bpp"  	add hl, de  	ld a, [hl]  .finished_a_b -	ld [wd002], a +	ld [wTownMapPlayerIconLandmark], a  	pop af  	ld [hInMenu], a  	call ClearBGPalettes @@ -3063,7 +3056,7 @@ INCBIN "gfx/pokegear/flymap_label_border.1bpp"  	ld [hBGMapAddress], a  	ld a, VBGMap0 / $100  	ld [hBGMapAddress + 1], a -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	ld e, a  	ret @@ -3080,7 +3073,7 @@ INCBIN "gfx/pokegear/flymap_label_border.1bpp"  	ret  .down_right -	ld hl, wd002 +	ld hl, wTownMapPlayerIconLandmark  	ld a, [hl]  	cp FLY_INDIGO  	jr c, .okay_dr @@ -3090,7 +3083,7 @@ INCBIN "gfx/pokegear/flymap_label_border.1bpp"  	jr .continue  .up_left -	ld hl, wd002 +	ld hl, wTownMapPlayerIconLandmark  	ld a, [hl]  	and a  	jr nz, .okay_ul @@ -3098,7 +3091,7 @@ INCBIN "gfx/pokegear/flymap_label_border.1bpp"  .okay_ul  	dec [hl]  .continue -	ld a, [wd002] +	ld a, [wTownMapPlayerIconLandmark]  	cp KANTO_FLYPOINT  	jr c, .johto  	call FillKantoMap diff --git a/engine/printnum.asm b/engine/printnum.asm index c68776d5f..7b814a042 100755 --- a/engine/printnum.asm +++ b/engine/printnum.asm @@ -275,7 +275,7 @@ _PrintNum:: ; c4c7  	dec e  	ret nz  	inc hl -	ld [hl], "<PERIOD>" +	ld [hl], "<DOT>"  	ret  .PrintLeadingZero: ; c644 diff --git a/engine/scripting.asm b/engine/scripting.asm index 3ff22599b..df22995b5 100644 --- a/engine/scripting.asm +++ b/engine/scripting.asm @@ -1355,19 +1355,19 @@ Script_earthquake:  ;     param (DecimalParam)  	ld hl, EarthquakeMovement -	ld de, wd002 +	ld de, wEarthquakeMovementDataBuffer  	ld bc, EarthquakeMovementEnd - EarthquakeMovement  	call CopyBytes  	call GetScriptByte -	ld [wd003], a -	and (1 << 6) - 1 -	ld [wd005], a +	ld [wEarthquakeMovementDataBuffer + 1], a +	and %00111111 +	ld [wEarthquakeMovementDataBuffer + 3], a  	ld b, BANK(.script)  	ld de, .script  	jp ScriptCall  .script -	applymovement PLAYER, wd002 +	applymovement PLAYER, wEarthquakeMovementDataBuffer  	end  EarthquakeMovement: diff --git a/engine/startmenu.asm b/engine/startmenu.asm index 2a567bf4f..871da86be 100755 --- a/engine/startmenu.asm +++ b/engine/startmenu.asm @@ -16,7 +16,7 @@ StartMenu:: ; 125cd  	call LoadMenuDataHeader  	call .SetUpMenuItems -	ld a, [wd0d2] +	ld a, [wBattleMenuCursorBuffer]  	ld [wMenuCursorBuffer], a  	call .DrawMenuAccount_  	call DrawVariableLengthMenuBox @@ -32,7 +32,7 @@ StartMenu:: ; 125cd  	call UpdateSprites  	call UpdateTimePals  	call .SetUpMenuItems -	ld a, [wd0d2] +	ld a, [wBattleMenuCursorBuffer]  	ld [wMenuCursorBuffer], a  .Select: @@ -40,7 +40,7 @@ StartMenu:: ; 125cd  	jr c, .Exit  	call .DrawMenuAccount  	ld a, [wMenuCursorBuffer] -	ld [wd0d2], a +	ld [wBattleMenuCursorBuffer], a  	call PlayClickSFX  	call PlaceHollowCursor  	call .OpenMenu diff --git a/engine/stats_screen.asm b/engine/stats_screen.asm index fef83afc7..6f098574e 100755 --- a/engine/stats_screen.asm +++ b/engine/stats_screen.asm @@ -420,7 +420,7 @@ StatsScreen_InitUpperHalf: ; 4deea (13:5eea)  	ld d, a  	ld e, [hl]  	callba ComputeHPBarPixels -	ld hl, wcda1 +	ld hl, wCurHPPal  	call SetHPPal  	ld b, SCGB_STATS_SCREEN_HP_PALS  	call GetSGBLayout @@ -601,7 +601,7 @@ StatsScreen_LoadGFX: ; 4dfb6 (13:5fb6)  	call .CalcExpToNextLevel  	hlcoord 13, 13  	lb bc, 3, 7 -	ld de, Buffer1 ; wd1ea (aliases: MagikarpLength) +	ld de, Buffer1  	call PrintNum  	ld de, .LevelUpStr  	hlcoord 10, 12 @@ -649,14 +649,14 @@ StatsScreen_LoadGFX: ; 4dfb6 (13:5fb6)  	ld a, [hQuotient + 1]  	sbc [hl]  	dec hl -	ld [Buffer2], a ; wd1eb (aliases: MovementType) +	ld [Buffer2], a  	ld a, [hQuotient]  	sbc [hl] -	ld [Buffer1], a ; wd1ea (aliases: MagikarpLength) +	ld [Buffer1], a  	ret  .AlreadyAtMaxLevel: -	ld hl, Buffer1 ; wd1ea (aliases: MagikarpLength) +	ld hl, Buffer1  	xor a  	ld [hli], a  	ld [hli], a @@ -973,7 +973,7 @@ Unknown_4e32a: ; 4e32a  EggStatsScreen: ; 4e33a  	xor a  	ld [hBGMapMode], a -	ld hl, wcda1 +	ld hl, wCurHPPal  	call SetHPPal  	ld b, SCGB_STATS_SCREEN_HP_PALS  	call GetSGBLayout diff --git a/engine/unowndex.asm b/engine/unowndex.asm index d7fe63dc3..007dd9790 100755 --- a/engine/unowndex.asm +++ b/engine/unowndex.asm @@ -1,7 +1,7 @@  UpdateUnownDex: ; fba18  	ld a, [UnownLetter]  	ld c, a -	ld b, 26 +	ld b, NUM_UNOWN  	ld hl, UnownDex  .loop  	ld a, [hli] diff --git a/engine/warp_connection.asm b/engine/warp_connection.asm index f9b379cb2..365e24ea6 100755 --- a/engine/warp_connection.asm +++ b/engine/warp_connection.asm @@ -184,7 +184,7 @@ LoadWarpData: ; 1046c6  	ret z  .not_mt_moon_or_tin_tower  	ld a, [wPrevWarp] -	ld [wDigWarp], a +	ld [wDigWarpNumber], a  	ld a, [wPrevMapGroup]  	ld [wDigMapGroup], a  	ld a, [wPrevMapNumber] | 
