| Age | Commit message (Collapse) | Author |
|---|
|
Use macros for spawns and flypoints.
|
|
Keep the unused labels for readability (and maybe some symfile magic).
|
|
Map header macros and misc comments
|
|
|
|
|
|
|
|
|
|
|
|
This firmly ties spawn constant definition to data allocation,
preventing usage earlier in main.asm or in other objects.
A potential solution is to abuse ifdefs and include it in
both main.asm and constants.asm.
|
|
This should make map headers much easier to edit than before.
Rather than occasionally being able to reuse blockdata semantically,
create a label for each map and attach it to some blockdata include.
This improves readability and reduces overhead when adding new maps.
The macro argument length bug doesn't seem to crop up here...
It looks like it only happens when an argument is over 16 characters
long and references a symbol that exists before the macro is invoked.
|
|
|
|
|
|
|
|
|
|
This is mostly just whitespace reduction.
|
|
Fix predefs and battle code.
|
|
The first and second map header labels have no semantic meaning with regard to length.
In fact, none of the labels are used at all.
|
|
Use the "map" macro instead of using GROUP_* and MAP_* constants.
Also remove redundant "(bank then label)" comments.
|
|
Also add SUBSTATUS_IN_LOOP for multi-hit moves.
|
|
|
|
|
|
|
|
|
|
SUBSTATUS_ROLLOUT was actually SUBSTATUS_RAMPAGE.
SUBSTATUS_ENCORED was actually SUBSTATUS_ROLLOUT.
Substatus 5 bit 4 was actually SUBSTATUS_ENCORED.
Also use some more (sub)status constants where needed.
|
|
|
|
|
|
Also start using hp palette constants.
|
|
Besides making predefs convenient, naming a predef no longer requires
adding or renaming a predef constant. This also lets predefs be rearranged at will.
|
|
|
|
This is mostly to make it more like pokered.
Queues are an order of magnitude faster than invoking a new python instance for each file.
|
|
Reads the contents of trainers/trainers.asm.
|
|
|
|
|
|
Functions prefixed with _ imply they're private.
The real purpose of this function is to use an address,
rather than saving a few cycles on push/pop.
|
|
Also add constants for trap and Celebi event battles.
|
|
- Use more substatus constants.
- Reformat some code to be more atomic.
- Add constants for unused status prevention held item effects.
- Remove pointless or redundant comments.
|
|
|
|
The PartyMon struct is really the box struct with volatile variables like status added.
Some other labels have been reworked.
Move structs no longer have explicit labels since their location is arbitrary and usually shared.
|
|
This eliminates the need for arbitrary move labels like Move2 and Move1 that don't have anything to do with their respective moves.
|
|
There turned out to be a lot of instances of NUM_MOVES.
|
|
Random returns a value from 0 to 0xff.
Instead of doing extra work, most probabilities are out of 0xff.
Convert these from percentages at build time for readability.
|
|
|
|
Better compression, macro cleanup, use MAX_LEVEL everywhere.
- move stats -> data (like pokered).
- remove FuncCoord and use {hl,bc,de}coord for all tilemap loads.
- use MAX_LEVEL where needed.
- update pokemontools for better compression, and recomment related code.
- growth rate constants
|
|
A goal is to be able to reproduce the original lz data in the repository.
In the meantime, make it smaller than before.
|
|
|
|
|
|
Variables can't use labels, so a macro that doesn't use variables is better suited.
|
|
|
|
This was probably used in the stats screen in JP versions.
It fell out of use when the stats screen layout was redon in localization.
|
|
If MAX_LEVEL was set to 255, the value could not fit into a byte.
|
