summaryrefslogtreecommitdiff
path: root/engine/battle/move_effects
AgeCommit message (Collapse)Author
2021-03-04Verify data table sizes with table_width and assert_table_length macrosRangi
This was discussed in #706 It also uncovered some off-by-one issues with defining some constants. A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2020-12-23Rename some labelsRangi
- Remove "Buffer" suffix from some byte and word quantities - Change "Ptr" to "Pointer" Fixes #789
2020-11-17Resolve some "???" commentsRangi
2020-11-03Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobileRangi
2020-11-03More syncing with pokegoldRangi
2020-10-29Updates to more closely sync with pokegoldRangi
2020-10-29Identify the remaining (non-mobile) uses of another WRAM unionRangi
2020-10-26Comment, remove, or revise many unreferenced labelsRangi
2020-10-04Identify some more unnamed labelsRangi
2020-08-29Remove wKickCounter and wPresentPower aliases for wBattleAnimParamRangi
2020-06-13Label some mobile addresses, and revise some commentsRangi
2020-03-21Add suffixes to some constants to avoid ambiguityRangi
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`) - `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`) - `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`) - `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`) This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
2020-02-28Document a bug where Teleport cannot fail for wild PokémonRangi
2019-10-20#641 fixes and additions. (#646)mid-kid
Name a lot of text labels according to our conventions
2019-04-09TextBox -> Textboxmid-kid
Homogenizing names.
2019-01-12Say "BANK(Foo) ; aka BANK(Bar)" to clarify that Foo and Bar share a bankRangi
2018-12-26Fix comments around BANK() statementsmid-kid
Found a couple BANK()s that reference multiple labels.
2018-11-21Move BattleSideCopy to transform.asmmid-kid
2018-08-26hQuotient is a four-byte buffer (fixes #558)Rangi
2018-08-25Use labels instead of constants for HRAMRangi
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-07Fix constants in BattleCommand_MirrorCoatmid-kid
2018-07-29Add meaningful aliases for wd265Rangi
Introduce MONICON_* constants Introduce BATTLEPLAYERACTION_* constants
2018-07-23StringCmp → CompareBytes; CompareLong → CompareBytesLongRangi
hStringCmpString[1/2] → h[EnemyMon/PartyMon1]Speed
2018-07-21Merge branch 'master' of hyperdriveguy/pokecrystalIIMarckus
2018-07-20Add Counter and Mirror Coat bugfixHyperdriveguy
2018-07-04Miscellaneous reorganization fixesRangi
2018-06-25No space between labels and bodiesRangi
2018-06-25Single newline at the end of filesRangi
2018-06-25Remove more triple newlinesRangi
2018-06-24Fix triple newlines left over from removing address commentsRangi
2018-06-24Remove more address commentsRangi
2018-06-24Remove all address commentsmid-kid
2018-04-05Fix some uses of EFFECTIVEmid-kid
2018-04-04Merge pull request #505 from mid-kid/battlecommandsyenatch
Battle command fixes
2018-04-04Rename some battle commandsmid-kid
`hittarget` was misleading, as it doesn't actually "hit" the target, it only plays the animation. As such, I've renamed it to `moveanim`. `checkfaint` has nothing to do with checking if the user or target has fainted, instead, it applies wCurDamage onto the target's HP, hitting the substitute if applicable. I've renamed the command to `applydamage` and all of its subfunctions accordingly.
2018-04-04Label BattleCommand_BeatUpFailTextmid-kid
2018-04-04Comment SapHealthmid-kid
Also fixed some Beat Up inconsistencies to make it more readable.
2018-04-01Fix file permissionsmid-kid
I have no idea why this was a thing (do people store this repo on FAT32 flash drives or something?), but quite a bit of files had a permission of 755. This isn't really a problem, but it's inconsistent and weird.
2018-02-20Use maskbits NUM_TYPESRangi
2018-02-03Merge branch 'master' of https://github.com/pret/pokecrystalRangi
# Conflicts: # audio/engine.asm # constants/gfx_constants.asm # constants/map_data_constants.asm # constants/pokemon_data_constants.asm # constants/sprite_constants.asm # constants/wram_constants.asm # data/maps/data.asm # engine/battle/ai/scoring.asm # engine/battle/core.asm # engine/battle/effect_commands.asm # engine/battle/misc.asm # engine/battle_anims/getpokeballwobble.asm # engine/breeding.asm # engine/buy_sell_toss.asm # engine/decorations.asm # engine/events/battle_tower/battle_tower.asm # engine/events/battle_tower/rules.asm # engine/events/buena.asm # engine/events/bug_contest/contest_2.asm # engine/events/daycare.asm # engine/events/dratini.asm # engine/events/halloffame.asm # engine/events/happiness_egg.asm # engine/events/kurt.asm # engine/events/lucky_number.asm # engine/events/magnet_train.asm # engine/events/overworld.asm # engine/events/pokerus/pokerus.asm # engine/events/print_unown.asm # engine/events/print_unown_2.asm # engine/events/unown_walls.asm # engine/item_effects.asm # engine/link.asm # engine/mon_menu.asm # engine/player_object.asm # engine/routines/playslowcry.asm # engine/scripting.asm # engine/search.asm # engine/search2.asm # engine/specials.asm # engine/start_menu.asm # engine/timeset.asm # home/battle_vars.asm # home/map.asm # maps/GoldenrodUndergroundSwitchRoomEntrances.asm # maps/IlexForest.asm # maps/KrissHouse2F.asm # maps/Route39Barn.asm # mobile/mobile_12_2.asm # mobile/mobile_40.asm # mobile/mobile_5f.asm # wram.asm
2018-01-26Move-unique effect commands consistently go in engine/battle/move_effects/Rangi