From d7970f749ac23786728926109be430ab732f19e6 Mon Sep 17 00:00:00 2001 From: xCrystal Date: Tue, 2 Jan 2018 18:49:25 +0100 Subject: Consistent predef function names --- engine/debug.asm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'engine/debug.asm') diff --git a/engine/debug.asm b/engine/debug.asm index 1e0d042e0..b9031ded8 100755 --- a/engine/debug.asm +++ b/engine/debug.asm @@ -315,12 +315,12 @@ Function81adb: ; 81adb hlcoord 12, 3 call _PrepMonFrontpic ld de, vTiles2 tile $31 - predef GetMonBackpic + predef Predef_GetMonBackpic ld a, $31 ld [hGraphicStartTile], a hlcoord 2, 4 lb bc, 6, 6 - predef PlaceGraphic + predef Predef_PlaceGraphic ld a, [wd003] and a jr z, .asm_81b66 @@ -346,13 +346,13 @@ Function81adb: ; 81adb hlcoord 4, 1 call PlaceString ld de, vTiles2 - callfar GetTrainerPic + callfar Predef_GetTrainerPic xor a ld [TempEnemyMonSpecies], a ld [hGraphicStartTile], a hlcoord 2, 3 lb bc, 7, 7 - predef PlaceGraphic + predef Predef_PlaceGraphic .asm_81ba9 ld a, $1 @@ -739,7 +739,7 @@ Function81df4: ; 81df4 ld a, [wd004] inc a ld [wd265], a - predef GetTMHMMove + predef Predef_GetTMHMMove ld a, [wd265] ld [wPutativeTMHMMove], a call GetMoveName @@ -748,7 +748,7 @@ Function81df4: ; 81df4 ld a, [wd004] call Function81e55 ld [CurItem], a - predef CanLearnTMHMMove + predef Predef_CanLearnTMHMMove ld a, c and a ld de, String_81e46 -- cgit v1.2.3 From 9d0ba6bfd3b2f10fae9969a784aa7b2b573e8411 Mon Sep 17 00:00:00 2001 From: Adelaide Walter Date: Wed, 3 Jan 2018 19:12:45 -0500 Subject: Use BANK for hardcoded WRAM banks (except where bankswitches appear unnecessary). --- engine/debug.asm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'engine/debug.asm') diff --git a/engine/debug.asm b/engine/debug.asm index 1e0d042e0..8cc4809e8 100755 --- a/engine/debug.asm +++ b/engine/debug.asm @@ -155,7 +155,7 @@ Function819a7: ; 819a7 ret z ld a, [rSVBK] push af - ld a, $5 + ld a, BANK(wBGPals2) ld [rSVBK], a ld hl, Palette_819f4 ld de, wBGPals2 @@ -436,7 +436,7 @@ Function81c33: ; 81c33 jr z, .asm_81c69 ld a, [rSVBK] push af - ld a, $5 + ld a, BANK(wBGPals2) ld [rSVBK], a ld hl, wBGPals2 ld de, wc608 @@ -1145,7 +1145,7 @@ Function82203: ; 82203 Function8220f: ; 8220f ld a, [rSVBK] push af - ld a, $5 + ld a, BANK(wBGPals1) ld [rSVBK], a ld a, [wcf64] ld l, a @@ -1198,7 +1198,7 @@ Function82236: ; 82236 call Function821d8 ld a, [rSVBK] push af - ld a, $5 + ld a, BANK(wBGPals2) ld [rSVBK], a ld hl, wBGPals2 ld a, [wcf64] @@ -1228,7 +1228,7 @@ Function82236: ; 82236 Function822a3: ; 822a3 ld a, [rSVBK] push af - ld a, $5 + ld a, BANK(wBGPals2) ld [rSVBK], a ld hl, wBGPals2 ld a, [wcf64] -- cgit v1.2.3 From 5c5f8b325fe5900a3800a976a1a31e99934f6815 Mon Sep 17 00:00:00 2001 From: Remy Oukaour Date: Tue, 9 Jan 2018 23:21:32 -0500 Subject: Move data/palettes/ .pal files into gfx/ --- engine/debug.asm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'engine/debug.asm') diff --git a/engine/debug.asm b/engine/debug.asm index 1e0d042e0..c1c8eb284 100755 --- a/engine/debug.asm +++ b/engine/debug.asm @@ -193,10 +193,10 @@ Function819a7: ; 819a7 ; 819f4 Palette_819f4: ; 819f4 -INCLUDE "data/palettes/debug/bg.pal" +INCLUDE "gfx/debug/bg.pal" Palette_81a34: ; 81a34 -INCLUDE "data/palettes/debug/ob.pal" +INCLUDE "gfx/debug/ob.pal" ; 81a74 Function81a74: ; 81a74 -- cgit v1.2.3 From 417937cffc2a7c3cfac49f3b00caf1a856d0a925 Mon Sep 17 00:00:00 2001 From: Remy Oukaour Date: Wed, 10 Jan 2018 13:47:57 -0500 Subject: Resolve #461 --- engine/debug.asm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'engine/debug.asm') diff --git a/engine/debug.asm b/engine/debug.asm index c1c8eb284..d95676db8 100755 --- a/engine/debug.asm +++ b/engine/debug.asm @@ -1016,17 +1016,17 @@ Function81f5e: ; 81f5e .asm_81fb7 ld a, b - ld [hli], a + ld [hli], a ; y ld a, [de] add a add a - add $18 - ld [hli], a + add 3 * TILE_WIDTH + ld [hli], a ; x xor a - ld [hli], a + ld [hli], a ; tile id ld a, c - ld [hli], a - ld a, $10 + ld [hli], a ; attributes + ld a, 2 * TILE_WIDTH add b ld b, a inc c -- cgit v1.2.3 From 7a09fc9f750aec50dd568226083b279004ffe155 Mon Sep 17 00:00:00 2001 From: Remy Oukaour Date: Sun, 14 Jan 2018 19:43:35 -0500 Subject: GFX tile sizes in decimal --- engine/debug.asm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'engine/debug.asm') diff --git a/engine/debug.asm b/engine/debug.asm index d95676db8..c36652148 100755 --- a/engine/debug.asm +++ b/engine/debug.asm @@ -1061,9 +1061,9 @@ TilesetColorTest: call WaitBGMap2 xor a ld [hBGMapMode], a - ld de, DebugColorTestGFX + $10 + ld de, DebugColorTestGFX + 1 tiles ld hl, vTiles2 tile $6a - lb bc, BANK(DebugColorTestGFX), $16 + lb bc, BANK(DebugColorTestGFX), 22 call Request2bpp ld de, DebugColorTestGFX ld hl, vTiles1 -- cgit v1.2.3 From 80480821142d7a7b16dd2b1a98a213e7b389af0f Mon Sep 17 00:00:00 2001 From: Remy Oukaour Date: Tue, 16 Jan 2018 14:30:10 -0500 Subject: Remove Predef_ prefix from routines listed in PredefPointers --- engine/debug.asm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'engine/debug.asm') diff --git a/engine/debug.asm b/engine/debug.asm index a23e9d674..710091779 100755 --- a/engine/debug.asm +++ b/engine/debug.asm @@ -315,12 +315,12 @@ Function81adb: ; 81adb hlcoord 12, 3 call _PrepMonFrontpic ld de, vTiles2 tile $31 - predef Predef_GetMonBackpic + predef GetMonBackpic ld a, $31 ld [hGraphicStartTile], a hlcoord 2, 4 lb bc, 6, 6 - predef Predef_PlaceGraphic + predef PlaceGraphic ld a, [wd003] and a jr z, .asm_81b66 @@ -346,13 +346,13 @@ Function81adb: ; 81adb hlcoord 4, 1 call PlaceString ld de, vTiles2 - callfar Predef_GetTrainerPic + callfar GetTrainerPic xor a ld [TempEnemyMonSpecies], a ld [hGraphicStartTile], a hlcoord 2, 3 lb bc, 7, 7 - predef Predef_PlaceGraphic + predef PlaceGraphic .asm_81ba9 ld a, $1 @@ -739,7 +739,7 @@ Function81df4: ; 81df4 ld a, [wd004] inc a ld [wd265], a - predef Predef_GetTMHMMove + predef GetTMHMMove ld a, [wd265] ld [wPutativeTMHMMove], a call GetMoveName @@ -748,7 +748,7 @@ Function81df4: ; 81df4 ld a, [wd004] call Function81e55 ld [CurItem], a - predef Predef_CanLearnTMHMMove + predef CanLearnTMHMMove ld a, c and a ld de, String_81e46 -- cgit v1.2.3 From a3beba1e64bcdd71ade4595b37b033e74d87a78c Mon Sep 17 00:00:00 2001 From: Remy Oukaour Date: Thu, 18 Jan 2018 20:40:32 -0500 Subject: Use Japanese charmap definitions in strings --- engine/debug.asm | 88 +++++++++++++++++++++++++++++++++++--------------------- 1 file changed, 56 insertions(+), 32 deletions(-) (limited to 'engine/debug.asm') diff --git a/engine/debug.asm b/engine/debug.asm index 710091779..dcfb1b4cf 100755 --- a/engine/debug.asm +++ b/engine/debug.asm @@ -1,3 +1,27 @@ +const_value set $6a + const DEBUGTEST_UP_ARROW ; $6a + const DEBUGTEST_TICKS ; $6b + const DEBUGTEST_WHITE ; $6c + const DEBUGTEST_LIGHT ; $6d + const DEBUGTEST_DARK ; $6e + const DEBUGTEST_BLACK ; $6f + const DEBUGTEST_0 ; $70 + const DEBUGTEST_1 ; $71 + const DEBUGTEST_2 ; $72 + const DEBUGTEST_3 ; $73 + const DEBUGTEST_4 ; $74 + const DEBUGTEST_5 ; $75 + const DEBUGTEST_6 ; $76 + const DEBUGTEST_7 ; $77 + const DEBUGTEST_8 ; $78 + const DEBUGTEST_9 ; $79 + const DEBUGTEST_A ; $7a + const DEBUGTEST_B ; $7b + const DEBUGTEST_C ; $7c + const DEBUGTEST_D ; $7d + const DEBUGTEST_E ; $7e + const DEBUGTEST_F ; $7f + ColorTest: ; 818ac ; A debug menu to test monster and trainer palettes at runtime. @@ -127,13 +151,13 @@ Function81948: ; 81948 ; 8197c Function8197c: ; 8197c - ld hl, DebugColorTestGFX + $10 - ld de, vTiles2 tile $6a - ld bc, $160 + ld hl, DebugColorTestGFX + 1 tiles + ld de, vTiles2 tile DEBUGTEST_UP_ARROW + ld bc, 22 tiles call CopyBytes ld hl, DebugColorTestGFX ld de, vTiles0 - ld bc, $10 + ld bc, 1 tiles call CopyBytes call LoadStandardFont ld hl, vTiles1 @@ -278,19 +302,19 @@ Function81adb: ; 81adb ld [hBGMapMode], a hlcoord 0, 0 ld bc, SCREEN_WIDTH * SCREEN_HEIGHT - ld a, $6f + ld a, DEBUGTEST_BLACK call ByteFill hlcoord 1, 3 lb bc, 7, 18 - ld a, $6c + ld a, DEBUGTEST_WHITE call Bank20_FillBoxWithByte hlcoord 11, 0 lb bc, 2, 3 - ld a, $6d + ld a, DEBUGTEST_LIGHT call Bank20_FillBoxWithByte hlcoord 16, 0 lb bc, 2, 3 - ld a, $6e + ld a, DEBUGTEST_DARK call Bank20_FillBoxWithByte call Function81bc0 call Function81bf4 @@ -360,9 +384,9 @@ Function81adb: ; 81adb ret ; 81baf -String_81baf: db "レア", $6f, $6f, "@" ; rare (shiny) +String_81baf: db "レアぅぅ@" ; rare (shiny) String_81bb4: db "ノーマル@" ; normal -String_81bb9: db $7a, "きりかえ▶@" ; (A) switches +String_81bb9: db DEBUGTEST_A, "きりかえ▶@" ; (A) switches ; 81bc0 Function81bc0: ; 81bc0 @@ -380,10 +404,10 @@ Function81bc0: ; 81bc0 Function81bde: ; 81bde push af - ld a, $6a + ld a, DEBUGTEST_UP_ARROW ld [hli], a ld bc, $f - ld a, $6b + ld a, DEBUGTEST_TICKS call ByteFill ld l, e ld h, d @@ -458,11 +482,11 @@ Function81c33: ; 81c33 .asm_81c69 ld hl, wSGBPals - ld a, $1 + ld a, 1 ld [hli], a - ld a, $ff + ld a, LOW(PALRGB_WHITE) ld [hli], a - ld a, $7f + ld a, HIGH(PALRGB_WHITE) ld [hli], a ld a, [wc608] ld [hli], a @@ -506,7 +530,7 @@ Function81ca7: ; 81ca7 Function81cbc: ; 81cbc and $f - add $70 + add DEBUGTEST_0 ld [hld], a ret ; 81cc2 @@ -657,7 +681,7 @@ Function81d89: ; 81d89 Function81d8e: ; 81d8e hlcoord 0, 10 ld bc, $a0 - ld a, $6f + ld a, DEBUGTEST_BLACK call ByteFill hlcoord 2, 12 ld de, String_81fcd @@ -777,8 +801,8 @@ Function81e55: ; 81e55 ; 81e5e Function81e5e: ; 81e5e - ld bc, $a - ld a, $6f + ld bc, 10 + ld a, DEBUGTEST_BLACK call ByteFill ret ; 81e67 @@ -864,9 +888,9 @@ Function81eca: ; 81eca Function81ee3: ; 81ee3 .asm_81ee3 - ld a, $ff + ld a, LOW(PALRGB_WHITE) ld [hli], a - ld a, $7f + ld a, HIGH(PALRGB_WHITE) ld [hli], a ld a, [de] inc de @@ -968,7 +992,7 @@ Function81f1d: ; 81f1d ; 81f5e Function81f5e: ; 81f5e - ld a, $6f + ld a, DEBUGTEST_BLACK hlcoord 10, 0 ld [hl], a hlcoord 15, 0 @@ -1039,8 +1063,8 @@ Function81f5e: ; 81f5e String_81fcd: ; 81fcd db "おわりますか?" ; Are you finished? - next "はい", $f2, $f2, $f2, $7a ; YES (A) - next "いいえ", $f2, $f2, $7b ; NO (B) + next "はい", DEBUGTEST_A ; YES...(A) + next "いいえ", DEBUGTEST_B ; NO..(B) db "@" ; 81fe3 @@ -1062,7 +1086,7 @@ TilesetColorTest: xor a ld [hBGMapMode], a ld de, DebugColorTestGFX + 1 tiles - ld hl, vTiles2 tile $6a + ld hl, vTiles2 tile DEBUGTEST_UP_ARROW lb bc, BANK(DebugColorTestGFX), 22 call Request2bpp ld de, DebugColorTestGFX @@ -1073,23 +1097,23 @@ TilesetColorTest: ld [hBGMapAddress + 1], a hlcoord 0, 0 ld bc, SCREEN_WIDTH * SCREEN_HEIGHT - ld a, $6f + ld a, DEBUGTEST_BLACK call ByteFill hlcoord 0, 0, AttrMap ld bc, SCREEN_WIDTH * SCREEN_HEIGHT ld a, $7 call ByteFill ld de, $15 - ld a, $6c + ld a, DEBUGTEST_WHITE call Function821d2 ld de, $1a - ld a, $6d + ld a, DEBUGTEST_LIGHT call Function821d2 ld de, $1f - ld a, $6e + ld a, DEBUGTEST_DARK call Function821d2 ld de, $24 - ld a, $6f + ld a, DEBUGTEST_BLACK call Function821d2 call Function821f4 call Function8220f @@ -1134,10 +1158,10 @@ Function821f4: ; 821f4 hlcoord 2, 8 Function82203: ; 82203 - ld a, $6a + ld a, DEBUGTEST_UP_ARROW ld [hli], a ld bc, $10 - 1 - ld a, $6b + ld a, DEBUGTEST_TICKS call ByteFill ret ; 8220f -- cgit v1.2.3 From ddec0ee305f25bc9941e19e16c79f499c5e95c23 Mon Sep 17 00:00:00 2001 From: Remy Oukaour Date: Fri, 19 Jan 2018 20:48:33 -0500 Subject: More Japanese characters --- engine/debug.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'engine/debug.asm') diff --git a/engine/debug.asm b/engine/debug.asm index dcfb1b4cf..f58891987 100755 --- a/engine/debug.asm +++ b/engine/debug.asm @@ -384,7 +384,7 @@ Function81adb: ; 81adb ret ; 81baf -String_81baf: db "レアぅぅ@" ; rare (shiny) +String_81baf: db "レア", DEBUGTEST_BLACK, DEBUGTEST_BLACK, "@" ; rare (shiny) String_81bb4: db "ノーマル@" ; normal String_81bb9: db DEBUGTEST_A, "きりかえ▶@" ; (A) switches ; 81bc0 -- cgit v1.2.3 From b071dd364f715165d6eec99ebbd1e4aed4b84bde Mon Sep 17 00:00:00 2001 From: Remy Oukaour Date: Fri, 19 Jan 2018 21:49:16 -0500 Subject: =?UTF-8?q?Japanese=20characters=20in=20Japanese=20text=20(e.g.=20?= =?UTF-8?q?"=E3=82=A9"=20not=20","=20for=20$f4)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- engine/debug.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'engine/debug.asm') diff --git a/engine/debug.asm b/engine/debug.asm index f58891987..c15481926 100755 --- a/engine/debug.asm +++ b/engine/debug.asm @@ -1062,7 +1062,7 @@ Function81f5e: ; 81f5e ; 81fcd String_81fcd: ; 81fcd - db "おわりますか?" ; Are you finished? + db "おわりますか？" ; Are you finished? next "はい", DEBUGTEST_A ; YES...(A) next "いいえ", DEBUGTEST_B ; NO..(B) db "@" -- cgit v1.2.3