From 5207615cdcc9ce8fadd4cb76cf0040cc5a407275 Mon Sep 17 00:00:00 2001 From: Rangi Date: Sat, 5 Jan 2019 20:29:45 -0500 Subject: Document a bugfix: 1/256 failure rate for 100% effect chance --- engine/battle/effect_commands.asm | 2 ++ 1 file changed, 2 insertions(+) (limited to 'engine') diff --git a/engine/battle/effect_commands.asm b/engine/battle/effect_commands.asm index 76d6ee375..69171740b 100644 --- a/engine/battle/effect_commands.asm +++ b/engine/battle/effect_commands.asm @@ -1877,6 +1877,8 @@ BattleCommand_EffectChance: ld hl, wEnemyMoveStruct + MOVE_CHANCE .got_move_chance + ; BUG: 1/256 chance to fail even for a 100% effect chance, + ; since carry is not set if BattleRandom == [hl] == 255 call BattleRandom cp [hl] pop hl -- cgit v1.2.3