From dcb24bc72428a60e37c1dfa7a93dc46bff7bd5ed Mon Sep 17 00:00:00 2001 From: Rangi Date: Fri, 24 Jul 2020 09:49:26 -0400 Subject: Use def_* macros for automatic map event counts Resolves #742 --- engine/overworld/player_object.asm | 1 + 1 file changed, 1 insertion(+) (limited to 'engine') diff --git a/engine/overworld/player_object.asm b/engine/overworld/player_object.asm index 8bb9d273e..41b8797cf 100644 --- a/engine/overworld/player_object.asm +++ b/engine/overworld/player_object.asm @@ -55,6 +55,7 @@ PlayerObjectTemplate: ; A dummy map object used to initialize the player object. ; Shorter than the actual amount copied by two bytes. ; Said bytes seem to be unused. +_NUM_OBJECT_EVENTS = 0 object_event -4, -4, SPRITE_CHRIS, SPRITEMOVEDATA_PLAYER, 15, 15, -1, -1, 0, OBJECTTYPE_SCRIPT, 0, 0, -1 CopyDECoordsToMapObject:: -- cgit v1.2.3 From 35821ec58c244be1f5cb670e07873e8a875c10a5 Mon Sep 17 00:00:00 2001 From: Rangi Date: Sat, 25 Jul 2020 18:36:49 -0400 Subject: Correct constants in DoNPCTrade --- engine/events/npc_trade.asm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'engine') diff --git a/engine/events/npc_trade.asm b/engine/events/npc_trade.asm index f7ec0f23e..0f9c7d9f5 100644 --- a/engine/events/npc_trade.asm +++ b/engine/events/npc_trade.asm @@ -188,10 +188,10 @@ DoNPCTrade: ld e, NPCTRADE_DIALOG call GetTradeAttribute ld a, [hl] - cp TRADE_DIALOG_COMPLETE - ld b, RESET_FLAG + cp TRADE_DIALOGSET_GIRL + ld b, CAUGHT_BY_UNKNOWN jr c, .incomplete - ld b, SET_FLAG + ld b, CAUGHT_BY_GIRL .incomplete farcall SetGiftPartyMonCaughtData -- cgit v1.2.3