From 1891879b62bcc6fb08ecf11216672e02ca7b522f Mon Sep 17 00:00:00 2001 From: mid-kid Date: Mon, 26 Feb 2018 18:43:30 +0100 Subject: GENDERLESS -> GENDER_UNKNOWN This is how they're called in official sources, and it fits better with the other `GENDER_` constants. --- engine/pokemon/mon_stats.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'engine') diff --git a/engine/pokemon/mon_stats.asm b/engine/pokemon/mon_stats.asm index 2b5586c51..5468d76fe 100644 --- a/engine/pokemon/mon_stats.asm +++ b/engine/pokemon/mon_stats.asm @@ -209,7 +209,7 @@ GetGender: ; 50bdd ; The higher the ratio, the more likely the monster is to be female. - cp GENDERLESS + cp GENDER_UNKNOWN jr z, .Genderless and a ; GENDER_F0? -- cgit v1.2.3 From 28c6eb83418c0bb7ade8c564406dbb710428f0fd Mon Sep 17 00:00:00 2001 From: mid-kid Date: Tue, 27 Feb 2018 14:24:29 +0100 Subject: Use data/items/pocket_names.asm --- engine/overworld/scripting.asm | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) (limited to 'engine') diff --git a/engine/overworld/scripting.asm b/engine/overworld/scripting.asm index f65f2f9c0..e2918a45b 100644 --- a/engine/overworld/scripting.asm +++ b/engine/overworld/scripting.asm @@ -613,7 +613,7 @@ GetPocketName: farcall CheckItemPocket ld a, [wItemAttributeParamBuffer] dec a - ld hl, .Pockets + ld hl, ItemPocketNames maskbits NUM_POCKETS add a ld e, a @@ -626,20 +626,7 @@ GetPocketName: call CopyName2 ret -.Pockets: - dw .Item - dw .Key - dw .Ball - dw .TM - -.Item: - db "ITEM POCKET@" -.Key: - db "KEY POCKET@" -.Ball: - db "BALL POCKET@" -.TM: - db "TM POCKET@" +INCLUDE "data/items/pocket_names.asm" CurItemName: ld a, [wCurItem] -- cgit v1.2.3 From 80d437d56562e3ec75f2b2fbc05443f4d2cbc0b4 Mon Sep 17 00:00:00 2001 From: mid-kid Date: Fri, 9 Mar 2018 22:09:03 +0100 Subject: Fix some uses of EFFECTIVE --- engine/battle/core.asm | 2 +- engine/battle/move_effects/conversion2.asm | 2 +- engine/battle_anims/anim_commands.asm | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'engine') diff --git a/engine/battle/core.asm b/engine/battle/core.asm index fe20333b5..c94b2b8dd 100644 --- a/engine/battle/core.asm +++ b/engine/battle/core.asm @@ -1533,7 +1533,7 @@ HandleFutureSight: ; 3ca26 xor a ld [wAttackMissed], a ld [wAlreadyDisobeyed], a - ld a, 10 + ld a, EFFECTIVE ld [wTypeModifier], a callfar DoMove xor a diff --git a/engine/battle/move_effects/conversion2.asm b/engine/battle/move_effects/conversion2.asm index 074ca93ba..c0e390926 100644 --- a/engine/battle/move_effects/conversion2.asm +++ b/engine/battle/move_effects/conversion2.asm @@ -50,7 +50,7 @@ BattleCommand_Conversion2: ; 359e6 ld [hl], a pop hl ld a, [wTypeMatchup] - cp 10 + cp EFFECTIVE jr nc, .loop call BattleCommand_SwitchTurn diff --git a/engine/battle_anims/anim_commands.asm b/engine/battle_anims/anim_commands.asm index 43e28c5db..1f4da606d 100644 --- a/engine/battle_anims/anim_commands.asm +++ b/engine/battle_anims/anim_commands.asm @@ -1338,7 +1338,7 @@ PlayHitSound: ; cc881 and $7f ret z - cp 10 + cp EFFECTIVE ld de, SFX_DAMAGE jr z, .play -- cgit v1.2.3 From 1b12109cb05fc1aa2e91c9be3504c2853c5727fd Mon Sep 17 00:00:00 2001 From: mid-kid Date: Thu, 5 Apr 2018 11:41:06 +0200 Subject: HanleDefrost -> HandleDefrost --- engine/battle/core.asm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'engine') diff --git a/engine/battle/core.asm b/engine/battle/core.asm index c94b2b8dd..de4830766 100644 --- a/engine/battle/core.asm +++ b/engine/battle/core.asm @@ -289,7 +289,7 @@ HandleBetweenTurnEffects: ; 3c1d6 .NoMoreFaintingConditions: call HandleLeftovers call HandleMysteryberry - call HanleDefrost + call HandleDefrost call HandleSafeguard call HandleScreens call HandleStatBoostingHeldItems @@ -1549,7 +1549,7 @@ HandleFutureSight: ; 3ca26 jp UpdateEnemyMonInParty ; 3ca8f -HanleDefrost: ; 3ca8f +HandleDefrost: ; 3ca8f ld a, [hSerialConnectionStatus] cp USING_EXTERNAL_CLOCK jr z, .enemy_first -- cgit v1.2.3