From fcfe77bc3db73afd2001c21ec9cc1cfb1beca20e Mon Sep 17 00:00:00 2001 From: Rangi Date: Thu, 1 Feb 2018 12:40:58 -0500 Subject: Meaningful scene constant names (Two common patterns: 0=default event and 1=nothing; and 0=nothing and 1=some event) --- maps/FastShip1F.asm | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'maps/FastShip1F.asm') diff --git a/maps/FastShip1F.asm b/maps/FastShip1F.asm index a13b40237..aa0877c63 100644 --- a/maps/FastShip1F.asm +++ b/maps/FastShip1F.asm @@ -6,9 +6,9 @@ FastShip1F_MapScripts: db 3 ; scene scripts - scene_script .DummyScene0 ; SCENE_FASTSHIP1F_0 - scene_script .EnterFastShip ; SCENE_FASTSHIP1F_1 - scene_script .DummyScene2 ; SCENE_FASTSHIP1F_2 + scene_script .DummyScene0 ; SCENE_DEFAULT + scene_script .EnterFastShip ; SCENE_FASTSHIP1F_ENTER_SHIP + scene_script .DummyScene2 ; SCENE_FASTSHIP1F_MEET_GRANDPA db 0 ; callbacks @@ -33,11 +33,11 @@ FastShip1F_MapScripts: clearevent EVENT_FAST_SHIP_HAS_ARRIVED checkevent EVENT_FAST_SHIP_FIRST_TIME iftrue .SkipGrandpa - setscene SCENE_FASTSHIP1F_2 + setscene SCENE_FASTSHIP1F_MEET_GRANDPA end .SkipGrandpa: - setscene SCENE_FASTSHIP1F_0 + setscene SCENE_DEFAULT end SailorScript_0x75160: @@ -69,7 +69,7 @@ SailorScript_0x75160: special FadeOutPalettes waitsfx setevent EVENT_VERMILION_PORT_SAILOR_AT_GANGWAY - setmapscene VERMILION_PORT, SCENE_VERMILIONPORT_1 + setmapscene VERMILION_PORT, SCENE_VERMILIONPORT_LEAVE_SHIP warp VERMILION_PORT, 7, 17 end @@ -82,7 +82,7 @@ SailorScript_0x75160: special FadeOutPalettes waitsfx setevent EVENT_OLIVINE_PORT_SAILOR_AT_GANGWAY - setmapscene OLIVINE_PORT, SCENE_OLIVINEPORT_1 + setmapscene OLIVINE_PORT, SCENE_OLIVINEPORT_LEAVE_SHIP warp OLIVINE_PORT, 7, 23 end @@ -133,7 +133,7 @@ WorriedGrandpaSceneLeft: spriteface PLAYER, RIGHT applymovement FASTSHIP1F_GENTLEMAN, MovementData_0x75222 disappear FASTSHIP1F_GENTLEMAN - setscene SCENE_FASTSHIP1F_0 + setscene SCENE_DEFAULT end MovementData_0x7520e: @@ -301,8 +301,8 @@ FastShip1F_MapEvents: warp_event 30, 14, 2, FAST_SHIP_B1F db 2 ; coord events - coord_event 24, 6, SCENE_FASTSHIP1F_2, WorriedGrandpaSceneLeft - coord_event 25, 6, SCENE_FASTSHIP1F_2, WorriedGrandpaSceneRight + coord_event 24, 6, SCENE_FASTSHIP1F_MEET_GRANDPA, WorriedGrandpaSceneLeft + coord_event 25, 6, SCENE_FASTSHIP1F_MEET_GRANDPA, WorriedGrandpaSceneRight db 0 ; bg events -- cgit v1.2.3