From 46d748a219bf6d34519d89e1d351b722a2ea9521 Mon Sep 17 00:00:00 2001 From: PikalaxALT Date: Sun, 27 Sep 2020 17:40:30 -0400 Subject: Create pull_request_template.md --- .github/pull_request_template.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .github/pull_request_template.md (limited to '.github/pull_request_template.md') diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..0b38a656c --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,17 @@ +# Pull request into pret/pokeemerald + +## Instructions +Please complete both the questionnaire and the checklist below. This is required for the PR to be merged. Failure to do this may result in a ban from contributions. + +## Questionnaire +1. What is your Discord username? (name#numbers, e.g. PikalaxALT#5823) +2. What is the purpose of this pull request? (decompilation, documentation, bug fixes, typo correction, code style refactor) + + +## Checklist +- [ ] I am a member of the [pret discord server](https://discord.gg/d5dubZ3). +- [ ] I have run `make compare modern` on my local machine to ensure that the project compiles correctly. +- [ ] If I am fixing a bug or undefined behavior in the modern build, I have documented the bug and tested the fix locally. +- [ ] My changes are not informed by the leaked source code, or I have disclosed my use of the leaks in the discord. +- [ ] I have answered all questions truthfully, including this one. +- [ ] I am not a robot. -- cgit v1.2.3 From 70f7d4f256fc76caa3d132908e59598db5ff4549 Mon Sep 17 00:00:00 2001 From: ExpoSeed <> Date: Sun, 27 Sep 2020 17:59:21 -0500 Subject: More concise pull request template --- .github/pull_request_template.md | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) (limited to '.github/pull_request_template.md') diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0b38a656c..9c61ba2be 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,17 +1,23 @@ -# Pull request into pret/pokeemerald + -## Instructions -Please complete both the questionnaire and the checklist below. This is required for the PR to be merged. Failure to do this may result in a ban from contributions. - -## Questionnaire -1. What is your Discord username? (name#numbers, e.g. PikalaxALT#5823) -2. What is the purpose of this pull request? (decompilation, documentation, bug fixes, typo correction, code style refactor) +## Description + +## Type of changes + +- [ ] Decompilation (matching, fixing nonmatching, fakematching, etc.) +- [ ] Documentation (naming symbols, commenting, etc.) +- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) +- [ ] Style (code style refactors, typo, etc.) +- [ ] Other: ## Checklist -- [ ] I am a member of the [pret discord server](https://discord.gg/d5dubZ3). -- [ ] I have run `make compare modern` on my local machine to ensure that the project compiles correctly. + +- [ ] I am a member of the [pret Discord server](https://discord.gg/d5dubZ3). +- [ ] `make compare` and `make compare modern` on my local machine outputs ![OK](https://cdn.discordapp.com/emojis/504128071524286475.png?v=1). +- [ ] My code follows the code style of this project. - [ ] If I am fixing a bug or undefined behavior in the modern build, I have documented the bug and tested the fix locally. -- [ ] My changes are not informed by the leaked source code, or I have disclosed my use of the leaks in the discord. -- [ ] I have answered all questions truthfully, including this one. -- [ ] I am not a robot. +- [ ] All my usage, if any, of the leaked source code has been disclosed in pret's server. + +## **Discord contact info** + -- cgit v1.2.3 From 933e180dd6fd721742af60cd209af11bab7e5ca4 Mon Sep 17 00:00:00 2001 From: ExpoSeed <> Date: Sun, 27 Sep 2020 18:09:35 -0500 Subject: Remove breaking change line --- .github/pull_request_template.md | 1 - 1 file changed, 1 deletion(-) (limited to '.github/pull_request_template.md') diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9c61ba2be..a56a168b8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,7 +7,6 @@ - [ ] Decompilation (matching, fixing nonmatching, fakematching, etc.) - [ ] Documentation (naming symbols, commenting, etc.) -- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Style (code style refactors, typo, etc.) - [ ] Other: -- cgit v1.2.3 From 94bfc31629f5fcad47d196028ffcf8514478ca52 Mon Sep 17 00:00:00 2001 From: ExpoSeed <> Date: Fri, 2 Oct 2020 11:24:39 -0500 Subject: Eliminate most of PR template --- .github/pull_request_template.md | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) (limited to '.github/pull_request_template.md') diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a56a168b8..c381b50f1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -3,20 +3,6 @@ ## Description -## Type of changes - -- [ ] Decompilation (matching, fixing nonmatching, fakematching, etc.) -- [ ] Documentation (naming symbols, commenting, etc.) -- [ ] Style (code style refactors, typo, etc.) -- [ ] Other: - -## Checklist - -- [ ] I am a member of the [pret Discord server](https://discord.gg/d5dubZ3). -- [ ] `make compare` and `make compare modern` on my local machine outputs ![OK](https://cdn.discordapp.com/emojis/504128071524286475.png?v=1). -- [ ] My code follows the code style of this project. -- [ ] If I am fixing a bug or undefined behavior in the modern build, I have documented the bug and tested the fix locally. -- [ ] All my usage, if any, of the leaked source code has been disclosed in pret's server. - ## **Discord contact info** + \ No newline at end of file -- cgit v1.2.3