From 072a98ca9aea8bfea7edc65f0a4a230974362b96 Mon Sep 17 00:00:00 2001 From: Sierraffinity Date: Sat, 25 Apr 2020 18:25:55 -0700 Subject: Document undefined sprite template behavior --- gflib/sprite.h | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'gflib/sprite.h') diff --git a/gflib/sprite.h b/gflib/sprite.h index 9753837fd..c9ba9585d 100644 --- a/gflib/sprite.h +++ b/gflib/sprite.h @@ -182,6 +182,10 @@ struct SpriteTemplate SpriteCallback callback; }; +// UB: template pointer is often used to point to temporary storage, +// then later dereferenced after being freed. Usually this won't +// be visible in-game, but this is (part of) what causes the item +// icon palette to flicker when changing items in the bag. struct Sprite { /*0x00*/ struct OamData oam; -- cgit v1.2.3