Age | Commit message (Collapse) | Author |
|
Backport 2 nonmatching fixes from emerald
|
|
|
|
|
|
Fix Typos / Use Box Constants / Name an Unknown
|
|
|
|
|
|
|
|
|
|
`gUnknown_835B882` has been cleaned up and renamed to `sPlayerAvatarGfxToStateFlag` to match pokeemerald.
|
|
The Celadon City scripts that give Eevee misspelled it as Eeevee. Fixed.
The comment explaining `boxRSEggsUnlocked` in the `ExternalEventFlags` struct had an incorrect deposit requirement listed and was fixed.
Also, replaced the literals with the `TOTAL_BOXES_COUNT` and `IN_BOX_COUNT` constants in `pokemon.c`'s `IsPokemonStorageFull` function. Thanks hjk321 for pointing that out.
|
|
Add -DINFO Option to Makefile
|
|
Popped up in discord channel so adding it here
|
|
Change embarassing magic numbers that should have been fixed a long time ago
|
|
I could *kinda* understand missing SendMonToPc, but IN THE STRUCT ITSELF?!
|
|
Celebratory change to calcrom.pl
|
|
|
|
[LEAK-INFORMED] match rest of text_printer
|
|
|
|
|
|
Mirror pokeemerald PR#1329 & PR#1335 to pokefirered
|
|
The `giftRibbons` field in `SaveBlock1` has been split out into proper subfields. The new ExternalEvent structs deal with interconnectivity between external games/peripherals and FRLG. US & JP Colosseum Bonus Discs', Colosseum and XD's, Pokémon Channel's, and PokémonBox: Ruby & Sapphire's interactions with these fields has been documented.
The `giftRibbon#` fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. The previous `fatefulEncounter` field was actually filler, and relabeled as such, while the `obedient` bit was renamed `eventLegal`. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind.
I still maintain that `eventLegal` is a misnomer and it should be called `fatefulEncounter` in all three repos.
|
|
|
|
Rename "Hidden" Movement Type to "Buried"
|
|
This commit mirrors the change to pokeemerald that renames `MOVEMENT_TYPE_HIDDEN` to `MOVEMENT_TYPE_BURIED` to avoid confusion between it and `MOVEMENT_TYPE_INVISIBLE`.
As the files and function labels are not synced between the two repos, only the necessary changes were made based on what pokefirered calls its functions. More syncing of labels with pokeemerald will need to be done in the future.
|
|
Use more LOCALID constants
|
|
[LEAK-INFORMED] match the rest of pokedex_screen
|
|
Fix warning about gMonPaletteTable section
|
|
|
|
|
|
|
|
|
|
|
|
Fix Trainer Tower Magic Number
|
|
A magic number was missed that will lead to edited projects breaking the Trainer Tower if new map layouts are added. This commit fixes it.
|
|
Fix "Compatibility" Misspelling
|
|
Someone misspelled "compatibility" as "compatability" in pokeemerald and the error was brought over to pokefirered.
|
|
Fix Vermilion Gym Script Label Transposition Typos
|
|
The script labels for being given TM34 from Lt. Surge are mistakenly typoed as TM43. This commit fixes this error.
|
|
Use trainer constants in flags, automatically update flags/vars count
|
|
|
|
Sync tools with pokeemerald
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Fix Egregious Magic Numbers in GetBattleBGM
|
|
Whoever originally decomped this function must've been really fed up with this file.
Renamed GetMUS_ForBattle to GetBattleBGM to be consistent with pokeemerald.
This entire function was magic numbers, so I replaced them with the appropriate constants.
|