From 7e8bff29bb34a9a233172ef738f9fc7ce1a1b833 Mon Sep 17 00:00:00 2001 From: PikalaxALT Date: Fri, 4 Oct 2019 15:45:26 -0400 Subject: review comments; br_ips std=c99 --- Makefile | 2 +- src/wild_pokemon_area.c | 4 ++-- tools/br_ips/Makefile | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 1e8dc6e9f..245a1a16a 100644 --- a/Makefile +++ b/Makefile @@ -123,7 +123,7 @@ MAKEFLAGS += --no-print-directory AUTO_GEN_TARGETS := -all: rom +all: tools rom rom: $(ROM) ifeq ($(COMPARE),1) diff --git a/src/wild_pokemon_area.c b/src/wild_pokemon_area.c index 8654f41f1..66637abfa 100644 --- a/src/wild_pokemon_area.c +++ b/src/wild_pokemon_area.c @@ -11,7 +11,7 @@ struct SeviiDexArea { - const u16 (* lut)[2]; + const u16 (*lut)[2]; s32 count; }; @@ -225,7 +225,7 @@ s32 BuildPokedexAreaSubspriteBuffer(u16 species, struct Subsprite * subsprites) static s32 GetRoamerIndex(u16 species) { s32 i; - for (i = 0; i < 3u; i++) + for (i = 0; i < NELEMS(sRoamerPairs); i++) { if (sRoamerPairs[i].roamer == species) return i; diff --git a/tools/br_ips/Makefile b/tools/br_ips/Makefile index d4e8dcecc..8b6ad51bf 100644 --- a/tools/br_ips/Makefile +++ b/tools/br_ips/Makefile @@ -1,5 +1,5 @@ CC := gcc -CFLAGS := -O3 +CFLAGS := -O3 -std=c99 .PHONY: all -- cgit v1.2.3