From f6e050cf354a6ca3f5ea3a57496cc0ae2aac49dd Mon Sep 17 00:00:00 2001
From: PikalaxALT <pikalaxalt@gmail.com>
Date: Fri, 17 Jan 2020 15:11:46 -0500
Subject: through sub_81081AC

---
 include/bag.h                | 2 ++
 include/battle_controllers.h | 1 +
 include/item_menu.h          | 4 ++--
 3 files changed, 5 insertions(+), 2 deletions(-)

(limited to 'include')

diff --git a/include/bag.h b/include/bag.h
index f82531778..8c085a211 100644
--- a/include/bag.h
+++ b/include/bag.h
@@ -1,6 +1,8 @@
 #ifndef GUARD_BAG_H
 #define GUARD_BAG_H
 
+#include "menu_helpers.h"
+
 void sub_810B858(void);
 void sub_810B8F0(u8 windowId, u8 fontId, const u8 * str, u8 x, u8 y, u8 letterSpacing, u8 lineSpacing, s8 speed, u8 colorIdx);
 void sub_810B958(const u8 * str);
diff --git a/include/battle_controllers.h b/include/battle_controllers.h
index 06a0e2957..412856353 100644
--- a/include/battle_controllers.h
+++ b/include/battle_controllers.h
@@ -2,6 +2,7 @@
 #define GUARD_BATTLE_CONTROLLERS_H
 
 #include "global.h"
+#include "battle.h"
 
 enum
 {
diff --git a/include/item_menu.h b/include/item_menu.h
index 187674e83..d141c6601 100644
--- a/include/item_menu.h
+++ b/include/item_menu.h
@@ -14,8 +14,8 @@ struct BagStruct
     u8 location;
     u8 pocket;
     u16 unk6;
-    u8 cursorPosition[6];
-    u8 scrollPosition[6];
+    u16 itemsAbove[3];
+    u16 cursorPos[3];
 };
 
 extern struct BagStruct gUnknown_203ACFC;
-- 
cgit v1.2.3


From dbf3ac402d94be993839bddd109e3cfaef8e3dea Mon Sep 17 00:00:00 2001
From: PikalaxALT <pikalaxalt@gmail.com>
Date: Fri, 17 Jan 2020 16:40:53 -0500
Subject: through sub_8108560

---
 include/gflib.h     | 18 ++++++++++++++++++
 include/graphics.h  | 11 +++++++----
 include/item_menu.h |  4 ++--
 3 files changed, 27 insertions(+), 6 deletions(-)
 create mode 100644 include/gflib.h

(limited to 'include')

diff --git a/include/gflib.h b/include/gflib.h
new file mode 100644
index 000000000..a6dfc62df
--- /dev/null
+++ b/include/gflib.h
@@ -0,0 +1,18 @@
+#ifndef GUARD_GFLIB_H
+#define GUARD_GFLIB_H
+
+#include "global.h"
+
+#include "bg.h"
+#include "palette.h"
+#include "gpu_regs.h"
+#include "dma3.h"
+#include "malloc.h"
+#include "sound.h"
+#include "text.h"
+#include "sprite.h"
+#include "window.h"
+#include "blit.h"
+#include "string_util.h"
+
+#endif //GUARD_GFLIB_H
diff --git a/include/graphics.h b/include/graphics.h
index a668364bd..eb9a9a20d 100644
--- a/include/graphics.h
+++ b/include/graphics.h
@@ -1,7 +1,3 @@
-//
-// Created by scott on 10/21/2017.
-//
-
 #ifndef GUARD_GRAPHICS_H
 #define GUARD_GRAPHICS_H
 
@@ -4861,4 +4857,11 @@ extern const u16 gBattleInterface_BallStatusBarPal[];
 extern const u16 gBattleInterface_BallDisplayPal[];
 extern const u16 gUnknown_8D12404[];
 
+// item_menu
+extern const u32 gUnknown_8E830CC[];
+extern const u32 gUnknown_8E832C0[];
+extern const u32 gUnknown_8E83444[];
+extern const u32 gUnknown_8E835B4[];
+extern const u32 gUnknown_8E83604[];
+
 #endif //GUARD_GRAPHICS_H
diff --git a/include/item_menu.h b/include/item_menu.h
index d141c6601..343fae393 100644
--- a/include/item_menu.h
+++ b/include/item_menu.h
@@ -12,8 +12,8 @@ struct BagStruct
 {
     void (*bagCallback)(void);
     u8 location;
-    u8 pocket;
-    u16 unk6;
+    u8 unk5;
+    u16 pocket;
     u16 itemsAbove[3];
     u16 cursorPos[3];
 };
-- 
cgit v1.2.3


From 881199142ccac48aa975d0b59be07dfd78ad70af Mon Sep 17 00:00:00 2001
From: PikalaxALT <PikalaxALT@gmail.com>
Date: Fri, 17 Jan 2020 22:23:20 -0500
Subject: through bag_menu_print_cursor

---
 include/bag.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'include')

diff --git a/include/bag.h b/include/bag.h
index 8c085a211..321a48ab0 100644
--- a/include/bag.h
+++ b/include/bag.h
@@ -4,7 +4,7 @@
 #include "menu_helpers.h"
 
 void sub_810B858(void);
-void sub_810B8F0(u8 windowId, u8 fontId, const u8 * str, u8 x, u8 y, u8 letterSpacing, u8 lineSpacing, s8 speed, u8 colorIdx);
+void sub_810B8F0(u8 windowId, u8 fontId, const u8 * str, u8 x, u8 y, u8 letterSpacing, u8 lineSpacing, u8 speed, u8 colorIdx);
 void sub_810B958(const u8 * str);
 void sub_810B994(void);
 u8 sub_810B9DC(u8 a0, u8 a1);
-- 
cgit v1.2.3


From 2ce545fc216cc07ac9b9bf833a6ed410d90ab420 Mon Sep 17 00:00:00 2001
From: PikalaxALT <PikalaxALT@gmail.com>
Date: Sat, 18 Jan 2020 09:23:48 -0500
Subject: through sub_810899C

---
 include/bag.h     | 2 +-
 include/strings.h | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

(limited to 'include')

diff --git a/include/bag.h b/include/bag.h
index 321a48ab0..c48940173 100644
--- a/include/bag.h
+++ b/include/bag.h
@@ -5,7 +5,7 @@
 
 void sub_810B858(void);
 void sub_810B8F0(u8 windowId, u8 fontId, const u8 * str, u8 x, u8 y, u8 letterSpacing, u8 lineSpacing, u8 speed, u8 colorIdx);
-void sub_810B958(const u8 * str);
+void sub_810B958(const u8 * str, u8 unused);
 void sub_810B994(void);
 u8 sub_810B9DC(u8 a0, u8 a1);
 void sub_810BA3C(u8 a0);
diff --git a/include/strings.h b/include/strings.h
index eace8d67e..2e74d7b38 100644
--- a/include/strings.h
+++ b/include/strings.h
@@ -1038,4 +1038,7 @@ extern const u8 gText_SaveFailedScreen_CheckingBackupMemory[];
 extern const u8 gText_SaveFailedScreen_BackupMemoryDamaged[];
 extern const u8 gText_SaveFailedScreen_SaveCompleted[];
 
+// item_menu
+extern const u8 gUnknown_84162F5[];
+
 #endif //GUARD_STRINGS_H
-- 
cgit v1.2.3


From 1c3f865acf9e957e8f6ba4daf7f0cfa093893074 Mon Sep 17 00:00:00 2001
From: PikalaxALT <PikalaxALT@gmail.com>
Date: Sat, 18 Jan 2020 09:36:16 -0500
Subject: through ItemMenu_StartFadeToExitCallback

---
 include/strings.h | 8 ++++++++
 1 file changed, 8 insertions(+)

(limited to 'include')

diff --git a/include/strings.h b/include/strings.h
index 2e74d7b38..809007409 100644
--- a/include/strings.h
+++ b/include/strings.h
@@ -1039,6 +1039,14 @@ extern const u8 gText_SaveFailedScreen_BackupMemoryDamaged[];
 extern const u8 gText_SaveFailedScreen_SaveCompleted[];
 
 // item_menu
+extern const u8 gUnknown_84161A9[];
+extern const u8 gUnknown_84161BC[];
+extern const u8 gUnknown_84161E9[];
+extern const u8 gUnknown_84161F4[];
+extern const u8 gUnknown_84161F9[];
+extern const u8 gUnknown_84162CD[];
+extern const u8 gUnknown_84162D3[];
+extern const u8 gUnknown_84162DE[];
 extern const u8 gUnknown_84162F5[];
 
 #endif //GUARD_STRINGS_H
-- 
cgit v1.2.3


From dfcfe6d8e1942349adfefc8e79255dcd8befca0a Mon Sep 17 00:00:00 2001
From: PikalaxALT <PikalaxALT@gmail.com>
Date: Sat, 18 Jan 2020 11:52:32 -0500
Subject: through MoveItemSlotInList

---
 include/constants/item_menu.h | 17 +++++++++++++++++
 include/item_menu.h           |  3 ++-
 include/strings.h             | 16 ++++++++--------
 3 files changed, 27 insertions(+), 9 deletions(-)
 create mode 100644 include/constants/item_menu.h

(limited to 'include')

diff --git a/include/constants/item_menu.h b/include/constants/item_menu.h
new file mode 100644
index 000000000..8e91d2a17
--- /dev/null
+++ b/include/constants/item_menu.h
@@ -0,0 +1,17 @@
+#ifndef GUARD_CONSTANTS_ITEM_MENU_H
+#define GUARD_CONSTANTS_ITEM_MENU_H
+
+#define ITEMMENUACTION_USE           0
+#define ITEMMENUACTION_TOSS          1
+#define ITEMMENUACTION_REGISTER      2
+#define ITEMMENUACTION_GIVE          3
+#define ITEMMENUACTION_CANCEL        4
+#define ITEMMENUACTION_BATTLE_USE    5
+#define ITEMMENUACTION_CHECK         6
+#define ITEMMENUACTION_OPEN          7
+#define ITEMMENUACTION_OPEN_BERRIES  8
+#define ITEMMENUACTION_WALK          9
+#define ITEMMENUACTION_DESELECT     10
+#define ITEMMENUACTION_DUMMY        11
+
+#endif //GUARD_CONSTANTS_ITEM_MENU_H
diff --git a/include/item_menu.h b/include/item_menu.h
index 343fae393..e7337ffc4 100644
--- a/include/item_menu.h
+++ b/include/item_menu.h
@@ -3,6 +3,7 @@
 
 #include "global.h"
 #include "task.h"
+#include "constants/item_menu.h"
 
 // Exported type declarations
 
@@ -29,7 +30,7 @@ void CB2_SetUpReshowBattleScreenAfterMenu(void);
 void sub_81089BC(void);
 void sub_810B108(u8);
 void CB2_BagMenuFromStartMenu(void);
-void ItemMenu_MoveItemSlotToNewPositionInArray(struct ItemSlot * slots, int pos1, int pos2);
+void MoveItemSlotInList(struct ItemSlot * itemSlots_, u32 from, u32 to_);
 void ItemMenu_StartFadeToExitCallback(u8 taskId);
 void sub_8108CB4(void);
 void ItemMenu_SetExitCallback(void (*)(void));
diff --git a/include/strings.h b/include/strings.h
index 809007409..8dba28b3c 100644
--- a/include/strings.h
+++ b/include/strings.h
@@ -1039,14 +1039,14 @@ extern const u8 gText_SaveFailedScreen_BackupMemoryDamaged[];
 extern const u8 gText_SaveFailedScreen_SaveCompleted[];
 
 // item_menu
-extern const u8 gUnknown_84161A9[];
-extern const u8 gUnknown_84161BC[];
-extern const u8 gUnknown_84161E9[];
-extern const u8 gUnknown_84161F4[];
-extern const u8 gUnknown_84161F9[];
-extern const u8 gUnknown_84162CD[];
-extern const u8 gUnknown_84162D3[];
-extern const u8 gUnknown_84162DE[];
+extern const u8 gOtherText_Register[];
+extern const u8 gOtherText_Walk[];
+extern const u8 gOtherText_Check[];
+extern const u8 gOtherText_Open[];
+extern const u8 gOtherText_Deselect[];
+extern const u8 gText_Items2[];
+extern const u8 gText_PokeBalls2[];
+extern const u8 gText_KeyItems2[];
 extern const u8 gUnknown_84162F5[];
 
 #endif //GUARD_STRINGS_H
-- 
cgit v1.2.3


From 24e199fdfdce8e17f65578b7446c2a8368b3a0be Mon Sep 17 00:00:00 2001
From: PikalaxALT <PikalaxALT@gmail.com>
Date: Sat, 18 Jan 2020 12:59:26 -0500
Subject: through sub_81090DC

---
 include/item_menu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'include')

diff --git a/include/item_menu.h b/include/item_menu.h
index e7337ffc4..43159401a 100644
--- a/include/item_menu.h
+++ b/include/item_menu.h
@@ -34,7 +34,7 @@ void MoveItemSlotInList(struct ItemSlot * itemSlots_, u32 from, u32 to_);
 void ItemMenu_StartFadeToExitCallback(u8 taskId);
 void sub_8108CB4(void);
 void ItemMenu_SetExitCallback(void (*)(void));
-void DisplayItemMessageInBag(u8 taskId, u8 bgId, const u8 * string, TaskFunc followUpFunc);
+void DisplayItemMessageInBag(u8 taskId, u8 fontId, const u8 * string, TaskFunc followUpFunc);
 void sub_810A1F8(u8 taskId);
 void sub_8107ECC(void);
 void sub_810AF74(void);
-- 
cgit v1.2.3


From 0ed743a582a04f178d138d51159426179c969288 Mon Sep 17 00:00:00 2001
From: PikalaxALT <PikalaxALT@gmail.com>
Date: Sat, 18 Jan 2020 19:54:25 -0500
Subject: through sub_810A554

---
 include/menu_helpers.h | 2 +-
 include/strings.h      | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

(limited to 'include')

diff --git a/include/menu_helpers.h b/include/menu_helpers.h
index 1e75b336c..90aeb95f6 100644
--- a/include/menu_helpers.h
+++ b/include/menu_helpers.h
@@ -27,7 +27,7 @@ void CreateYesNoMenuWithCallbacks(u8 taskId, const struct WindowTemplate *templa
 u8 GetLRKeysState(void);
 u8 GetLRKeysPressedAndHeld(void);
 bool8 itemid_link_can_give_berry(u16 itemId);
-bool8 itemid_80BF6D8_mail_related(u16 itemId);
+bool8 CanWriteMailHere(u16 itemId);
 void ResetVramOamAndBgCntRegs(void);
 
 #endif //GUARD_MENU_HELPERS_H
diff --git a/include/strings.h b/include/strings.h
index 8dba28b3c..0d70d9e19 100644
--- a/include/strings.h
+++ b/include/strings.h
@@ -1047,6 +1047,7 @@ extern const u8 gOtherText_Deselect[];
 extern const u8 gText_Items2[];
 extern const u8 gText_PokeBalls2[];
 extern const u8 gText_KeyItems2[];
-extern const u8 gUnknown_84162F5[];
+extern const u8 gText_CloseBag[];
+extern const u8 gText_CantWriteMailHere[];
 
 #endif //GUARD_STRINGS_H
-- 
cgit v1.2.3


From 4c62d0f35f58cd5720997ffb1241d5a08dd90620 Mon Sep 17 00:00:00 2001
From: PikalaxALT <PikalaxALT@gmail.com>
Date: Sat, 18 Jan 2020 22:14:54 -0500
Subject: through InitTutorialBag

---
 include/event_scripts.h  | 2 ++
 include/item_menu.h      | 2 +-
 include/map_name_popup.h | 1 +
 include/strings.h        | 3 +++
 4 files changed, 7 insertions(+), 1 deletion(-)

(limited to 'include')

diff --git a/include/event_scripts.h b/include/event_scripts.h
index b5e355484..dcbe2c137 100644
--- a/include/event_scripts.h
+++ b/include/event_scripts.h
@@ -1195,4 +1195,6 @@ extern const u8 Text_1A5D31[];
 extern const u8 Text_1A5D6E[];
 extern const u8 Text_1A5DB1[];
 
+extern const u8 gUnknown_81A77A0[];
+
 #endif //GUARD_EVENT_SCRIPTS_H
diff --git a/include/item_menu.h b/include/item_menu.h
index 43159401a..d8257ccf1 100644
--- a/include/item_menu.h
+++ b/include/item_menu.h
@@ -37,7 +37,7 @@ void ItemMenu_SetExitCallback(void (*)(void));
 void DisplayItemMessageInBag(u8 taskId, u8 fontId, const u8 * string, TaskFunc followUpFunc);
 void sub_810A1F8(u8 taskId);
 void sub_8107ECC(void);
-void sub_810AF74(void);
+void InitTutorialBag(void);
 void sub_8108DC8(u8 pocketId);
 void sub_81089F4(u8 pocketId);
 void GoToBagMenu(u8 menuType, u8 pocket, MainCallback callback);
diff --git a/include/map_name_popup.h b/include/map_name_popup.h
index c8ce02c30..a7c1234c6 100644
--- a/include/map_name_popup.h
+++ b/include/map_name_popup.h
@@ -4,5 +4,6 @@
 #include "global.h"
 
 void CreateMapNamePopupIfNotAlreadyRunning(bool32 palIntoFadedBuffer);
+void DismissMapNamePopup(void);
 
 #endif //GUARD_MAP_NAME_POPUP_H
diff --git a/include/strings.h b/include/strings.h
index 0d70d9e19..852e88a5c 100644
--- a/include/strings.h
+++ b/include/strings.h
@@ -1049,5 +1049,8 @@ extern const u8 gText_PokeBalls2[];
 extern const u8 gText_KeyItems2[];
 extern const u8 gText_CloseBag[];
 extern const u8 gText_CantWriteMailHere[];
+extern const u8 gText_DepositHowManyStrVars1[];
+extern const u8 gText_DepositedStrVar2StrVar1s[];
+extern const u8 gText_NoRoomToStoreItems[];
 
 #endif //GUARD_STRINGS_H
-- 
cgit v1.2.3


From 6e41dd7b2120f8024bb0cfff7a5ef25f0dce0366 Mon Sep 17 00:00:00 2001
From: PikalaxALT <PikalaxALT@gmail.com>
Date: Sun, 19 Jan 2020 14:47:23 -0500
Subject: Document item_menu

---
 include/bag.h                 | 26 +++++++++++++-------------
 include/constants/item_menu.h | 18 ++++++++++++++++++
 include/event_scripts.h       |  2 +-
 include/graphics.h            |  4 ++--
 include/item_menu.h           | 20 ++++++++++----------
 include/item_menu_icons.h     | 18 ++++++++----------
 include/menu_helpers.h        |  2 +-
 include/strings.h             |  3 +++
 include/teachy_tv.h           | 10 ++++++++++
 include/tm_case.h             | 10 ++++++++++
 10 files changed, 76 insertions(+), 37 deletions(-)

(limited to 'include')

diff --git a/include/bag.h b/include/bag.h
index c48940173..fec9f67bf 100644
--- a/include/bag.h
+++ b/include/bag.h
@@ -3,18 +3,18 @@
 
 #include "menu_helpers.h"
 
-void sub_810B858(void);
-void sub_810B8F0(u8 windowId, u8 fontId, const u8 * str, u8 x, u8 y, u8 letterSpacing, u8 lineSpacing, u8 speed, u8 colorIdx);
-void sub_810B958(const u8 * str, u8 unused);
-void sub_810B994(void);
-u8 sub_810B9DC(u8 a0, u8 a1);
-void sub_810BA3C(u8 a0);
-u8 sub_810BA70(u8 a0);
-void sub_810BA9C(u8 a0);
-u8 sub_810BAD8(u8 a0);
-void sub_810BAE8(u8 taskId, const struct YesNoFuncTable * ptrs);
-void sub_810BB14(u8 taskId, const struct YesNoFuncTable * ptrs);
-void sub_810BB40(void);
-void sub_810BB74(u8 windowId);
+void InitBagWindows(void);
+void BagPrintTextOnWindow(u8 windowId, u8 fontId, const u8 * str, u8 x, u8 y, u8 letterSpacing, u8 lineSpacing, u8 speed, u8 colorIdx);
+void BagPrintTextOnWin1CenteredColor0(const u8 * str, u8 unused);
+void BagDrawDepositItemTextBox(void);
+u8 ShowBagWindow(u8 whichWindow, u8 nItems);
+void HideBagWindow(u8 whichWindow);
+u8 OpenBagWindow(u8 whichWindow);
+void CloseBagWindow(u8 whichWindow);
+u8 GetBagWindow(u8 whichWindow);
+void BagCreateYesNoMenuBottomRight(u8 taskId, const struct YesNoFuncTable * ptrs);
+void BagCreateYesNoMenuTopRight(u8 taskId, const struct YesNoFuncTable * ptrs);
+void BagPrintMoneyAmount(void);
+void BagDrawTextBoxOnWindow(u8 windowId);
 
 #endif //GUARD_BAG_H
diff --git a/include/constants/item_menu.h b/include/constants/item_menu.h
index 8e91d2a17..2a51b8c1b 100644
--- a/include/constants/item_menu.h
+++ b/include/constants/item_menu.h
@@ -1,6 +1,24 @@
 #ifndef GUARD_CONSTANTS_ITEM_MENU_H
 #define GUARD_CONSTANTS_ITEM_MENU_H
 
+#define OPEN_BAG_ITEMS     0
+#define OPEN_BAG_KEYITEMS  1
+#define OPEN_BAG_POKEBALLS 2
+#define OPEN_BAG_LAST      3
+
+#define ITEMMENULOCATION_FIELD            0
+#define ITEMMENULOCATION_PARTY            1
+#define ITEMMENULOCATION_SHOP             2
+#define ITEMMENULOCATION_ITEMPC           3
+#define ITEMMENULOCATION_PCBOX            4
+#define ITEMMENULOCATION_BATTLE           5
+#define ITEMMENULOCATION_OLDMAN           6
+#define ITEMMENULOCATION_TTVSCR_STATUS    7
+#define ITEMMENULOCATION_TTVSCR_CATCHING  8
+#define ITEMMENULOCATION_TTVSCR_REGISTER  9
+#define ITEMMENULOCATION_TTVSCR_TMS      10
+#define ITEMMENULOCATION_LAST            11
+
 #define ITEMMENUACTION_USE           0
 #define ITEMMENUACTION_TOSS          1
 #define ITEMMENUACTION_REGISTER      2
diff --git a/include/event_scripts.h b/include/event_scripts.h
index dcbe2c137..a597868b9 100644
--- a/include/event_scripts.h
+++ b/include/event_scripts.h
@@ -1195,6 +1195,6 @@ extern const u8 Text_1A5D31[];
 extern const u8 Text_1A5D6E[];
 extern const u8 Text_1A5DB1[];
 
-extern const u8 gUnknown_81A77A0[];
+extern const u8 EventScript_BagItemCanBeRegistered[];
 
 #endif //GUARD_EVENT_SCRIPTS_H
diff --git a/include/graphics.h b/include/graphics.h
index eb9a9a20d..296dee465 100644
--- a/include/graphics.h
+++ b/include/graphics.h
@@ -4861,7 +4861,7 @@ extern const u16 gUnknown_8D12404[];
 extern const u32 gUnknown_8E830CC[];
 extern const u32 gUnknown_8E832C0[];
 extern const u32 gUnknown_8E83444[];
-extern const u32 gUnknown_8E835B4[];
-extern const u32 gUnknown_8E83604[];
+extern const u32 gBagBgPalette[];
+extern const u32 gBagBgPalette_FemaleOverride[];
 
 #endif //GUARD_GRAPHICS_H
diff --git a/include/item_menu.h b/include/item_menu.h
index d8257ccf1..4720080da 100644
--- a/include/item_menu.h
+++ b/include/item_menu.h
@@ -13,13 +13,13 @@ struct BagStruct
 {
     void (*bagCallback)(void);
     u8 location;
-    u8 unk5;
+    u8 bagOpen;
     u16 pocket;
     u16 itemsAbove[3];
     u16 cursorPos[3];
 };
 
-extern struct BagStruct gUnknown_203ACFC;
+extern struct BagStruct gBagMenuState;
 
 extern u16 gSpecialVar_ItemId;
 
@@ -27,19 +27,19 @@ extern u16 gSpecialVar_ItemId;
 void sub_81AAC50(void);
 void sub_81AAC70(void);
 void CB2_SetUpReshowBattleScreenAfterMenu(void);
-void sub_81089BC(void);
-void sub_810B108(u8);
+void ResetBagCursorPositions(void);
+void InitPokeDudeBag(u8);
 void CB2_BagMenuFromStartMenu(void);
 void MoveItemSlotInList(struct ItemSlot * itemSlots_, u32 from, u32 to_);
 void ItemMenu_StartFadeToExitCallback(u8 taskId);
-void sub_8108CB4(void);
+void Bag_BeginCloseWin0Animation(void);
 void ItemMenu_SetExitCallback(void (*)(void));
 void DisplayItemMessageInBag(u8 taskId, u8 fontId, const u8 * string, TaskFunc followUpFunc);
-void sub_810A1F8(u8 taskId);
-void sub_8107ECC(void);
-void InitTutorialBag(void);
-void sub_8108DC8(u8 pocketId);
-void sub_81089F4(u8 pocketId);
+void Task_ReturnToBagFromContextMenu(u8 taskId);
+void CB2_BagMenuFromBattle(void);
+void InitOldManBag(void);
+void Pocket_CalculateNItemsAndMaxShowed(u8 pocketId);
+void PocketCalculateInitialCursorPosAndItemsAbove(u8 pocketId);
 void GoToBagMenu(u8 menuType, u8 pocket, MainCallback callback);
 
 #endif //GUARD_ITEM_MENU_H
diff --git a/include/item_menu_icons.h b/include/item_menu_icons.h
index b5b5c6b0b..fd66a9375 100644
--- a/include/item_menu_icons.h
+++ b/include/item_menu_icons.h
@@ -3,28 +3,26 @@
 
 #include "global.h"
 
-extern void * gUnknown_2039884;
-
-extern const struct CompressedSpriteSheet gUnknown_83D41E4;
-extern const struct CompressedSpriteSheet gUnknown_83D41EC;
-extern const struct CompressedSpritePalette gUnknown_83D41F4;
+extern const struct CompressedSpriteSheet gSpriteSheet_Backpack;
+extern const struct CompressedSpriteSheet gSpriteSheet_Satchel;
+extern const struct CompressedSpritePalette gSpritePalette_BagOrSatchel;
 
 extern const struct CompressedSpriteSheet gBagSwapSpriteSheet;
 extern const struct CompressedSpritePalette gBagSwapSpritePalette;
 
 void ResetItemMenuIconState(void);
-void sub_80985E4(void);
+void ItemMenuIcons_CreateInsertIndicatorBarHidden(void);
 void DestroyItemMenuIcon(bool8 a0);
 void CreateItemMenuIcon(u16 itemId, bool8 a0);
 void CopyItemIconPicTo4x4Buffer(const void *src, void *dest);
 u8 AddItemIconObject(u16 tilesTag, u16 paletteTag, u16 itemId);
 u8 AddItemIconObjectWithCustomObjectTemplate(const struct SpriteTemplate * origTemplate, u16 tilesTag, u16 paletteTag, u16 itemId);
 void sub_80989A0(u16 itemId, u8 idx);
-void sub_80986A8(s16 x, u16 y);
-void sub_8098660(u8);
+void ItemMenuIcons_MoveInsertIndicatorBar(s16 x, u16 y);
+void ItemMenuIcons_ToggleInsertIndicatorBarVisibility(bool8 invisible);
 void sub_8098528(u8);
 void sub_8098580(void);
-const void * sub_8098974(u16 itemId, u8 ptrId);
-void sub_80984FC(u8 animNum);
+const void * GetItemIconGfxPtr(u16 itemId, u8 ptrId);
+void CreateBagOrSatchelSprite(u8 animNum);
 
 #endif // GUARD_ITEM_MENU_ICONS
diff --git a/include/menu_helpers.h b/include/menu_helpers.h
index 90aeb95f6..d26f50483 100644
--- a/include/menu_helpers.h
+++ b/include/menu_helpers.h
@@ -20,7 +20,7 @@ bool8 sub_80BF748(void);
 bool8 MenuHelpers_LinkSomething(void);
 void SetVBlankHBlankCallbacksToNull(void);
 void ResetAllBgsCoordinatesAndBgCntRegs(void);
-u8 sub_80BF8E4(void);
+u8 GetDialogBoxFontId(void);
 bool8 AdjustQuantityAccordingToDPadInput(s16 *arg0, u16 arg1);
 void DisplayMessageAndContinueTask(u8 taskId, u8 windowId, u16 tileNum, u8 paletteNum, u8 fontId, u8 textSpeed, const u8 *string, void *taskFunc);
 void CreateYesNoMenuWithCallbacks(u8 taskId, const struct WindowTemplate *template, u8 fontId, u8 left, u8 top, u16 tileStart, u8 palette, const struct YesNoFuncTable *yesNo);
diff --git a/include/strings.h b/include/strings.h
index 852e88a5c..6241bd8a9 100644
--- a/include/strings.h
+++ b/include/strings.h
@@ -1038,6 +1038,9 @@ extern const u8 gText_SaveFailedScreen_CheckingBackupMemory[];
 extern const u8 gText_SaveFailedScreen_BackupMemoryDamaged[];
 extern const u8 gText_SaveFailedScreen_SaveCompleted[];
 
+// bag
+extern const u8 gText_DepositItem[];
+
 // item_menu
 extern const u8 gOtherText_Register[];
 extern const u8 gOtherText_Walk[];
diff --git a/include/teachy_tv.h b/include/teachy_tv.h
index 36bac6a67..3484f88c1 100644
--- a/include/teachy_tv.h
+++ b/include/teachy_tv.h
@@ -1,6 +1,16 @@
 #ifndef GUARD_TEACHY_TV_H
 #define GUARD_TEACHY_TV_H
 
+enum TeachyTvScript
+{
+    TTVSCR_BATTLE,
+    TTVSCR_STATUS,
+    TTVSCR_MATCHUPS,
+    TTVSCR_CATCHING,
+    TTVSCR_TMS,
+    TTVSCR_REGISTER
+};
+
 void InitTeachyTvController(u8 mode, void (*cb)());
 void CB2_ReturnToTeachyTV(void);
 void SetTeachyTvControllerModeToResume(void);
diff --git a/include/tm_case.h b/include/tm_case.h
index f77eae457..bb88fc4d1 100644
--- a/include/tm_case.h
+++ b/include/tm_case.h
@@ -1,6 +1,16 @@
 #ifndef GUARD_TM_CASE_H
 #define GUARD_TM_CASE_H
 
+enum TmCaseType
+{
+    TMCASE_FROMFIELD,
+    TMCASE_FROMPARTYGIVE,
+    TMCASE_FROMMARTSELL,
+    TMCASE_FROMPOKEMONSTORAGEPC,
+    TMCASE_FROMBATTLE,
+    TMCASE_NA
+};
+
 void InitTMCase(u8 a0, void (* a1)(void), u8 a2);
 void ResetTMCaseCursorPos(void);
 void PokeDude_InitTMCase(void);
-- 
cgit v1.2.3


From c365f58833d60606b2a759b190b1f35f09f7ee66 Mon Sep 17 00:00:00 2001
From: PikalaxALT <pikalaxalt@gmail.com>
Date: Sun, 19 Jan 2020 16:19:35 -0500
Subject: Address review comments

---
 include/constants/item_menu.h | 2 +-
 include/data.h                | 2 +-
 include/graphics.h            | 4 ++--
 include/item_menu.h           | 6 +++---
 include/strings.h             | 6 +++---
 include/tm_case.h             | 2 +-
 6 files changed, 11 insertions(+), 11 deletions(-)

(limited to 'include')

diff --git a/include/constants/item_menu.h b/include/constants/item_menu.h
index 2a51b8c1b..d173b9212 100644
--- a/include/constants/item_menu.h
+++ b/include/constants/item_menu.h
@@ -12,7 +12,7 @@
 #define ITEMMENULOCATION_ITEMPC           3
 #define ITEMMENULOCATION_PCBOX            4
 #define ITEMMENULOCATION_BATTLE           5
-#define ITEMMENULOCATION_OLDMAN           6
+#define ITEMMENULOCATION_OLD_MAN          6
 #define ITEMMENULOCATION_TTVSCR_STATUS    7
 #define ITEMMENULOCATION_TTVSCR_CATCHING  8
 #define ITEMMENULOCATION_TTVSCR_REGISTER  9
diff --git a/include/data.h b/include/data.h
index 72e6b66fc..f308b044c 100644
--- a/include/data.h
+++ b/include/data.h
@@ -57,7 +57,7 @@ extern const struct SpriteFrameImage gUnknown_82346D8[];
 extern const struct SpriteFrameImage gUnknown_82346F8[];
 extern const struct SpriteFrameImage gTrainerBackPicTable_Red[];
 extern const struct SpriteFrameImage gTrainerBackPicTable_Leaf[];
-extern const struct SpriteFrameImage gTrainerBackPicTable_PokeDude[];
+extern const struct SpriteFrameImage gTrainerBackPicTable_Pokedude[];
 extern const struct SpriteFrameImage gTrainerBackPicTable_OldMan[];
 extern const struct SpriteFrameImage gTrainerBackPicTable_RSBrendan[];
 extern const struct SpriteFrameImage gTrainerBackPicTable_RSMay[];
diff --git a/include/graphics.h b/include/graphics.h
index 296dee465..e87acb556 100644
--- a/include/graphics.h
+++ b/include/graphics.h
@@ -2652,7 +2652,7 @@ extern const u32 gTrainerPalette_RSBrendan1[];
 extern const u32 gTrainerPalette_RSMay1[];
 extern const u32 gTrainerPalette_LeafBackPic[];
 extern const u32 gTrainerPalette_RedBackPic[];
-extern const u32 gTrainerPalette_PokeDudeBackPic[];
+extern const u32 gTrainerPalette_PokedudeBackPic[];
 extern const u32 gTrainerPalette_OldManBackPic[];
 extern const u32 gTrainerPalette_PokemonBreederM[];
 extern const u32 gTrainerPalette_RSPokemonBreederF[];
@@ -4354,7 +4354,7 @@ extern const u8 gBerryPouchBg1Tilemap[];
 
 extern const u8 gTrainerBackPic_Red[];
 extern const u8 gTrainerBackPic_Leaf[];
-extern const u8 gTrainerBackPic_PokeDude[];
+extern const u8 gTrainerBackPic_Pokedude[];
 extern const u8 gTrainerBackPic_OldMan[];
 extern const u8 gTrainerBackPic_RSBrendan[];
 extern const u8 gTrainerBackPic_RSMay[];
diff --git a/include/item_menu.h b/include/item_menu.h
index 4720080da..27bd73e72 100644
--- a/include/item_menu.h
+++ b/include/item_menu.h
@@ -11,9 +11,9 @@
 
 struct BagStruct
 {
-    void (*bagCallback)(void);
+    MainCallback bagCallback;
     u8 location;
-    u8 bagOpen;
+    bool8 bagOpen;
     u16 pocket;
     u16 itemsAbove[3];
     u16 cursorPos[3];
@@ -28,7 +28,7 @@ void sub_81AAC50(void);
 void sub_81AAC70(void);
 void CB2_SetUpReshowBattleScreenAfterMenu(void);
 void ResetBagCursorPositions(void);
-void InitPokeDudeBag(u8);
+void InitPokedudeBag(u8);
 void CB2_BagMenuFromStartMenu(void);
 void MoveItemSlotInList(struct ItemSlot * itemSlots_, u32 from, u32 to_);
 void ItemMenu_StartFadeToExitCallback(u8 taskId);
diff --git a/include/strings.h b/include/strings.h
index 6241bd8a9..7e8a4fbb4 100644
--- a/include/strings.h
+++ b/include/strings.h
@@ -112,8 +112,8 @@ extern const u8 gText_OhNoICantBuyThat[];
 extern const u8 gText_HowManyWouldYouLikeToSell[];
 extern const u8 gText_ICanPayThisMuch_WouldThatBeOkay[];
 extern const u8 gText_TurnedOverItemsWorthYen[];
-extern const u8 gPokeDudeText_TMTypes[];
-extern const u8 gPokeDudeText_ReadTMDescription[];
+extern const u8 gPokedudeText_TMTypes[];
+extern const u8 gPokedudeText_ReadTMDescription[];
 extern const u8 gFameCheckerText_Cancel[];
 extern const u8 gFameCheckerText_ListMenuCursor[];
 extern const u8 gFameCheckerText_FameCheckerWillBeClosed[];
@@ -134,7 +134,7 @@ extern const u8 gTeachyTvString_CatchPkmn[];
 extern const u8 gTeachyTvString_AboutTMs[];
 extern const u8 gTeachyTvString_RegisterItem[];
 extern const u8 gTeachyTvString_Cancel[];
-extern const u8 gTeachyTvText_PokeDudeSaysHello[];
+extern const u8 gTeachyTvText_PokedudeSaysHello[];
 extern const u8 gTeachyTvText_BattleScript1[];
 extern const u8 gTeachyTvText_StatusScript1[];
 extern const u8 gTeachyTvText_MatchupsScript1[];
diff --git a/include/tm_case.h b/include/tm_case.h
index bb88fc4d1..22fb021e0 100644
--- a/include/tm_case.h
+++ b/include/tm_case.h
@@ -13,6 +13,6 @@ enum TmCaseType
 
 void InitTMCase(u8 a0, void (* a1)(void), u8 a2);
 void ResetTMCaseCursorPos(void);
-void PokeDude_InitTMCase(void);
+void Pokedude_InitTMCase(void);
 
 #endif //GUARD_TM_CASE_H
-- 
cgit v1.2.3