From 26646f96eafb177b81c2d80311e5d21508eef008 Mon Sep 17 00:00:00 2001 From: Rangi Date: Fri, 1 Jun 2018 01:08:22 -0400 Subject: Some landmark name routines --- engine/landmarks.asm | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 engine/landmarks.asm (limited to 'engine') diff --git a/engine/landmarks.asm b/engine/landmarks.asm new file mode 100644 index 0000000..9e3c95d --- /dev/null +++ b/engine/landmarks.asm @@ -0,0 +1,11 @@ +INCLUDE "constants.asm" + +SECTION "GetLandmarkName", ROMX[$4AA5], BANK[$3F] + +GetLandmarkName:: + dec a + ld hl, LandmarkNames + call GetNthString + ld d, h + ld e, l + ret -- cgit v1.2.3 From c8e99019471f5f7b5e1824687043ac92bc7a424b Mon Sep 17 00:00:00 2001 From: Rangi Date: Fri, 1 Jun 2018 13:24:42 -0400 Subject: Code conventions: - Lowercase hex literals - Lowercase rgbasm keywords (rept, endr) - Use decimal literals by default, binary when bits are meaningful; hex indicates that it needs further review, e.g. to define a constant - Tabs, not spaces - Newline at end of file (rgbds sometimes complains otherwise) - Doc comments underneath function names --- engine/link/place_waiting_text.asm | 2 +- engine/menu/main_menu.asm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'engine') diff --git a/engine/link/place_waiting_text.asm b/engine/link/place_waiting_text.asm index c617dec..bfe9d7e 100644 --- a/engine/link/place_waiting_text.asm +++ b/engine/link/place_waiting_text.asm @@ -15,7 +15,7 @@ PlaceWaitingText:: ; 1:4000 .link_textbox ; TODO ; predef Predef_LinkTextbox - ld a, $1C + ld a, $1c call Predef .textbox_done hlcoord 4, 11 diff --git a/engine/menu/main_menu.asm b/engine/menu/main_menu.asm index 5701eba..536123f 100644 --- a/engine/menu/main_menu.asm +++ b/engine/menu/main_menu.asm @@ -4,7 +4,7 @@ SECTION "Main Menu Definition", ROMX[$5418], BANK[$01] MainMenuHeader: db $40 - db 0, 0, 7, 13 + db $00, $00, $07, $0d dw .data db 1 ; default option -- cgit v1.2.3