From 85cd0e5e1c89fe21c19b001686faf43c37017ff7 Mon Sep 17 00:00:00 2001 From: entrpntr Date: Mon, 15 Jun 2020 14:51:55 -0400 Subject: Fix bug comments as indicated in review. --- engine/events/halloffame.asm | 2 -- engine/events/lucky_number.asm | 4 +++- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'engine') diff --git a/engine/events/halloffame.asm b/engine/events/halloffame.asm index bd6c8a90..f74645b7 100644 --- a/engine/events/halloffame.asm +++ b/engine/events/halloffame.asm @@ -16,8 +16,6 @@ HallOfFame:: ; Bug: Gold/Silver fail to (conditionally) erase the previous save and ; initialize the current save, if the player did not save on this playthrough. -; pokecrystal does the following here (routine doesn't exist in Gold/Silver): -; farcall HallOfFame_InitSaveIfNeeded ld hl, wHallOfFameCount ld a, [hl] diff --git a/engine/events/lucky_number.asm b/engine/events/lucky_number.asm index a3f9bc5d..9e1d9b9b 100644 --- a/engine/events/lucky_number.asm +++ b/engine/events/lucky_number.asm @@ -96,7 +96,9 @@ CheckForLuckyNumberWinners: .SkipBox: inc c ld a, c - cp NUM_BOXES_JAPANESE ; fails to find winning mon in boxes 10-14 if not the active box + + ; BUG: fails to find winning mon in boxes 10-14 if not the active box + cp NUM_BOXES_JAPANESE jr c, .BoxesLoop call CloseSRAM -- cgit v1.2.3