From 91c7c35ea2b9dbbdb3cb725b6b114b20e59623e8 Mon Sep 17 00:00:00 2001 From: Rangi Date: Thu, 17 Sep 2020 16:04:12 -0400 Subject: No measurable performance difference between read and read_to_end --- tools/xor_compress.rs | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tools/xor_compress.rs b/tools/xor_compress.rs index 673b4a3..c6b78cf 100644 --- a/tools/xor_compress.rs +++ b/tools/xor_compress.rs @@ -1,18 +1,15 @@ use std::env::args; use std::process::exit; -use std::fs::write; -use std::io::{Read, Error}; +use std::fs::{read, write}; +use std::io::Error; const PROGRAM_NAME: &str = "xor-compress"; fn read_files(filenames: &[String]) -> Result, (&String, Error)> { let mut data = Vec::new(); for filename in filenames { - match std::fs::File::open(filename) { - Ok(mut f) => match f.read_to_end(&mut data) { - Ok(_) => (), - Err(err) => return Err((filename, err)), - }, + match read(filename) { + Ok(bytes) => data.extend(&bytes), Err(err) => return Err((filename, err)), } } -- cgit v1.2.3