summaryrefslogtreecommitdiff
path: root/engine/menus
diff options
context:
space:
mode:
Diffstat (limited to 'engine/menus')
-rw-r--r--engine/menus/draw_badges.asm8
-rwxr-xr-xengine/menus/party_menu.asm21
-rwxr-xr-xengine/menus/start_sub_menus.asm10
3 files changed, 10 insertions, 29 deletions
diff --git a/engine/menus/draw_badges.asm b/engine/menus/draw_badges.asm
index a74497c1..0bb433cc 100644
--- a/engine/menus/draw_badges.asm
+++ b/engine/menus/draw_badges.asm
@@ -8,12 +8,12 @@ DrawBadges:
; Tile ids for face/badge graphics.
ld de, wBadgeOrFaceTiles
ld hl, .FaceBadgeTiles
- ld bc, 8
+ ld bc, NUM_BADGES
call CopyData
; Booleans for each badge.
ld hl, wTempObtainedBadgesBooleans
- ld bc, 8
+ ld bc, NUM_BADGES
xor a
call FillMemory
@@ -22,7 +22,7 @@ DrawBadges:
ld hl, wBadgeOrFaceTiles
ld a, [wObtainedBadges]
ld b, a
- ld c, 8
+ ld c, NUM_BADGES
.CheckBadge
srl b
jr nc, .NextBadge
@@ -92,7 +92,7 @@ DrawBadges:
push bc
ld hl, wBadgeOrFaceTiles + 1
ld de, wBadgeOrFaceTiles
- ld bc, 8
+ ld bc, NUM_BADGES
call CopyData
pop bc
diff --git a/engine/menus/party_menu.asm b/engine/menus/party_menu.asm
index 14216b64..6648ab54 100755
--- a/engine/menus/party_menu.asm
+++ b/engine/menus/party_menu.asm
@@ -1,22 +1,3 @@
-; [wPartyMenuTypeOrMessageID] = menu type / message ID
-; if less than $F0, it is a menu type
-; menu types:
-; 00: normal pokemon menu (e.g. Start menu)
-; 01: use healing item on pokemon menu
-; 02: in-battle switch pokemon menu
-; 03: learn TM/HM menu
-; 04: swap pokemon positions menu
-; 05: use evolution stone on pokemon menu
-; otherwise, it is a message ID
-; f0: poison healed
-; f1: burn healed
-; f2: freeze healed
-; f3: sleep healed
-; f4: paralysis healed
-; f5: HP healed
-; f6: health returned
-; f7: revitalized
-; f8: leveled up
DrawPartyMenu_::
xor a
ldh [hAutoBGTransferEnabled], a
@@ -197,7 +178,7 @@ RedrawPartyMenu_::
push hl
set 6, [hl] ; turn off letter printing delay
ld a, [wPartyMenuTypeOrMessageID] ; message ID
- cp $F0
+ cp FIRST_PARTY_MENU_TEXT_ID
jr nc, .printItemUseMessage
add a
ld hl, PartyMenuMessagePointers
diff --git a/engine/menus/start_sub_menus.asm b/engine/menus/start_sub_menus.asm
index a845592f..6a98a10c 100755
--- a/engine/menus/start_sub_menus.asm
+++ b/engine/menus/start_sub_menus.asm
@@ -130,7 +130,7 @@ StartMenu_Pokemon::
dw .teleport
dw .softboiled
.fly
- bit 2, a ; does the player have the Thunder Badge?
+ bit BIT_THUNDERBADGE, a
jp z, .newBadgeRequired
call CheckIfInOutsideMap
jr z, .canFly
@@ -150,7 +150,7 @@ StartMenu_Pokemon::
set 1, [hl]
jp StartMenu_Pokemon
.cut
- bit 1, a ; does the player have the Cascade Badge?
+ bit BIT_CASCADEBADGE, a
jp z, .newBadgeRequired
predef UsedCut
ld a, [wActionResultOrTookBattleTurn]
@@ -158,7 +158,7 @@ StartMenu_Pokemon::
jp z, .loop
jp CloseTextDisplay
.surf
- bit 4, a ; does the player have the Soul Badge?
+ bit BIT_SOULBADGE, a
jp z, .newBadgeRequired
farcall IsSurfingAllowed
ld hl, wd728
@@ -175,13 +175,13 @@ StartMenu_Pokemon::
call GBPalWhiteOutWithDelay3
jp .goBackToMap
.strength
- bit 3, a ; does the player have the Rainbow Badge?
+ bit BIT_RAINBOWBADGE, a
jp z, .newBadgeRequired
predef PrintStrengthTxt
call GBPalWhiteOutWithDelay3
jp .goBackToMap
.flash
- bit 0, a ; does the player have the Boulder Badge?
+ bit BIT_BOULDERBADGE, a
jp z, .newBadgeRequired
xor a
ld [wMapPalOffset], a