summaryrefslogtreecommitdiff
path: root/engine
diff options
context:
space:
mode:
Diffstat (limited to 'engine')
-rw-r--r--engine/battle/core.asm10
-rw-r--r--engine/items/item_effects.asm2
-rw-r--r--engine/items/town_map.asm2
-rw-r--r--engine/menus/party_menu.asm2
-rw-r--r--engine/overworld/dust_smoke.asm24
-rw-r--r--engine/predefs.asm10
6 files changed, 22 insertions, 28 deletions
diff --git a/engine/battle/core.asm b/engine/battle/core.asm
index 5cb4fa13..f325350f 100644
--- a/engine/battle/core.asm
+++ b/engine/battle/core.asm
@@ -6308,7 +6308,7 @@ LoadPlayerBackPic:
ld de, OldManPicBack
.next
ld a, BANK(RedPicBack)
- assert BANK(RedPicBack) == BANK(OldManPicBack)
+ ASSERT BANK(RedPicBack) == BANK(OldManPicBack)
call UncompressSpriteFromDE
predef ScaleSpriteByTwo
ld hl, wOAMBuffer
@@ -6900,9 +6900,9 @@ ResetCryModifiers:
; animates the mon "growing" out of the pokeball
AnimateSendingOutMon:
- ld a, [wPredefRegisters]
+ ld a, [wPredefHL]
ld h, a
- ld a, [wPredefRegisters + 1]
+ ld a, [wPredefHL + 1]
ld l, a
ldh a, [hStartTileID]
ldh [hBaseTileID], a
@@ -6940,9 +6940,9 @@ AnimateSendingOutMon:
jr CopyUncompressedPicToHL
CopyUncompressedPicToTilemap:
- ld a, [wPredefRegisters]
+ ld a, [wPredefHL]
ld h, a
- ld a, [wPredefRegisters + 1]
+ ld a, [wPredefHL + 1]
ld l, a
ldh a, [hStartTileID]
CopyUncompressedPicToHL::
diff --git a/engine/items/item_effects.asm b/engine/items/item_effects.asm
index 915d4930..8114db2b 100644
--- a/engine/items/item_effects.asm
+++ b/engine/items/item_effects.asm
@@ -2617,7 +2617,7 @@ IsKeyItem_::
ld hl, KeyItemFlags
ld de, wBuffer
ld bc, 15 ; only 11 bytes are actually used
- assert 15 >= (NUM_ITEMS + 7) / 8
+ ASSERT 15 >= (NUM_ITEMS + 7) / 8
call CopyData
pop af
dec a
diff --git a/engine/items/town_map.asm b/engine/items/town_map.asm
index 42d313d9..a12c0c8a 100644
--- a/engine/items/town_map.asm
+++ b/engine/items/town_map.asm
@@ -249,7 +249,7 @@ ToText:
db "To@"
BuildFlyLocationsList:
- ld hl, wFlyLocationsList - 1
+ ld hl, wFlyAnimUsingCoordList
ld [hl], $ff
inc hl
ld a, [wTownVisitedFlag]
diff --git a/engine/menus/party_menu.asm b/engine/menus/party_menu.asm
index ddb92f75..f77beb26 100644
--- a/engine/menus/party_menu.asm
+++ b/engine/menus/party_menu.asm
@@ -131,7 +131,7 @@ RedrawPartyMenu_::
ld l, a
ld de, wEvosMoves
ld a, BANK(EvosMovesPointerTable)
- ld bc, wEvosMoves.end - wEvosMoves
+ ld bc, wEvosMovesEnd - wEvosMoves
call FarCopyData
ld hl, wEvosMoves
ld de, .notAbleToEvolveText
diff --git a/engine/overworld/dust_smoke.asm b/engine/overworld/dust_smoke.asm
index a20a0591..bb291567 100644
--- a/engine/overworld/dust_smoke.asm
+++ b/engine/overworld/dust_smoke.asm
@@ -51,22 +51,16 @@ GetMoveBoulderDustFunctionPointer:
pop hl
ret
-MoveBoulderDustFunctionPointerTable:
-; facing down
- db $FF,$00
- dw AdjustOAMBlockYPos
-
-; facing up
- db $01,$00
- dw AdjustOAMBlockYPos
+boulder_dust_adjust: MACRO
+ db \1, \2 ; coords
+ dw \3 ; function
+ENDM
-; facing left
- db $01,$01
- dw AdjustOAMBlockXPos
-
-; facing right
- db $FF,$01
- dw AdjustOAMBlockXPos
+MoveBoulderDustFunctionPointerTable:
+ boulder_dust_adjust -1, 0, AdjustOAMBlockYPos ; down
+ boulder_dust_adjust 1, 0, AdjustOAMBlockYPos ; up
+ boulder_dust_adjust 1, 1, AdjustOAMBlockXPos ; left
+ boulder_dust_adjust -1, 1, AdjustOAMBlockXPos ; right
LoadSmokeTileFourTimes::
ld hl, vChars1 tile $7c
diff --git a/engine/predefs.asm b/engine/predefs.asm
index a9877739..faf0029e 100644
--- a/engine/predefs.asm
+++ b/engine/predefs.asm
@@ -1,20 +1,20 @@
GetPredefPointer::
-; Store the contents of the register
-; pairs (hl, de, bc) at wPredefRegisters.
+; Back up the contents of the registers (hl, de, bc).
; Then put the bank and address of predef
; wPredefID in [wPredefBank] and hl.
ld a, h
- ld [wPredefRegisters], a
+ ld [wPredefHL], a
ld a, l
- ld [wPredefRegisters + 1], a
+ ld [wPredefHL + 1], a
- ld hl, wPredefRegisters + 2
+ ld hl, wPredefDE
ld a, d
ld [hli], a
ld a, e
ld [hli], a
+ ASSERT wPredefDE + 2 == wPredefBC
ld a, b
ld [hli], a
ld [hl], c