From f07cdb4c9723bdbb1fcdbbe622d39936ae5b532f Mon Sep 17 00:00:00 2001
From: ProjectRevoTPP <projectrevotpp@hotmail.com>
Date: Wed, 17 Jan 2018 17:47:46 -0500
Subject: use Dma Large loops for every while(1) Dma loop

---
 src/field/overworld.c | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

(limited to 'src/field/overworld.c')

diff --git a/src/field/overworld.c b/src/field/overworld.c
index 86b0a5dac..a6d34e103 100644
--- a/src/field/overworld.c
+++ b/src/field/overworld.c
@@ -1664,29 +1664,12 @@ void do_load_map_stuff_loop(u8 *a1)
 
 void sub_8054BA8(void)
 {
-    u8 *addr;
-    u32 size;
-
     REG_DISPCNT = 0;
 
     ScanlineEffect_Stop();
 
     DmaClear16(3, PLTT + 2, PLTT_SIZE - 2);
-
-    addr = (void *)VRAM;
-    size = 0x18000;
-    while (1)
-    {
-        DmaFill16(3, 0, addr, 0x1000);
-        addr += 0x1000;
-        size -= 0x1000;
-        if (size <= 0x1000)
-        {
-            DmaFill16(3, 0, addr, size);
-            break;
-        }
-    }
-
+    DmaFill16Large(3, 0, (void *)(VRAM + 0x0), 0x18000, 0x1000);
     ResetOamRange(0, 128);
     LoadOam();
 }
-- 
cgit v1.2.3


From 428f712da678b3f5b9256d85c0e3248cacd8e7c2 Mon Sep 17 00:00:00 2001
From: Marcus Huderle <huderlem@gmail.com>
Date: Fri, 19 Jan 2018 21:30:16 -0800
Subject: Further document weather

---
 src/field/overworld.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/field/overworld.c')

diff --git a/src/field/overworld.c b/src/field/overworld.c
index a6d34e103..fc313693a 100644
--- a/src/field/overworld.c
+++ b/src/field/overworld.c
@@ -590,7 +590,7 @@ bool8 sub_80538D0(u16 x, u16 y)
 
 void sub_80538F0(u8 mapGroup, u8 mapNum)
 {
-    s32 i;
+    s32 paletteIndex;
 
     Overworld_SetWarpDestination(mapGroup, mapNum, -1, -1, -1);
     sub_8053F0C();
@@ -611,8 +611,8 @@ void sub_80538F0(u8 mapGroup, u8 mapNum)
     sub_8056D38(gMapHeader.mapData);
     apply_map_tileset2_palette(gMapHeader.mapData);
 
-    for (i = 6; i < 12; i++)
-        sub_807D874(i);
+    for (paletteIndex = 6; paletteIndex < 12; paletteIndex++)
+        sub_807D874(paletteIndex);
 
     sub_8072ED0();
     UpdateLocationHistoryForRoamer();
-- 
cgit v1.2.3


From 003ed9293b2c51f0481ed31f0e0459cbecbf757e Mon Sep 17 00:00:00 2001
From: Marcus Huderle <huderlem@gmail.com>
Date: Sat, 20 Jan 2018 14:17:03 -0800
Subject: More documentation of field_weather

---
 src/field/overworld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/field/overworld.c')

diff --git a/src/field/overworld.c b/src/field/overworld.c
index fc313693a..07453e4fe 100644
--- a/src/field/overworld.c
+++ b/src/field/overworld.c
@@ -612,7 +612,7 @@ void sub_80538F0(u8 mapGroup, u8 mapNum)
     apply_map_tileset2_palette(gMapHeader.mapData);
 
     for (paletteIndex = 6; paletteIndex < 12; paletteIndex++)
-        sub_807D874(paletteIndex);
+        ApplyWeatherGammaShiftToPal(paletteIndex);
 
     sub_8072ED0();
     UpdateLocationHistoryForRoamer();
-- 
cgit v1.2.3