From a49ca6ef4153c16f5f5f1f968cc704e07b669d96 Mon Sep 17 00:00:00 2001 From: Rangi Date: Wed, 8 Jul 2020 10:31:44 -0400 Subject: Factor out MapBadgeFlags and EscapeRopeTilesets data tables --- data/maps/badge_maps.asm | 10 ++++++++++ data/tilesets/escape_rope_tilesets.asm | 3 +++ engine/events/hidden_objects/gym_statues.asm | 13 ++----------- engine/items/item_effects.asm | 4 +--- 4 files changed, 16 insertions(+), 14 deletions(-) create mode 100644 data/maps/badge_maps.asm create mode 100644 data/tilesets/escape_rope_tilesets.asm diff --git a/data/maps/badge_maps.asm b/data/maps/badge_maps.asm new file mode 100644 index 00000000..81d95757 --- /dev/null +++ b/data/maps/badge_maps.asm @@ -0,0 +1,10 @@ +MapBadgeFlags: + db PEWTER_GYM, %00000001 + db CERULEAN_GYM, %00000010 + db VERMILION_GYM,%00000100 + db CELADON_GYM, %00001000 + db FUCHSIA_GYM, %00010000 + db SAFFRON_GYM, %00100000 + db CINNABAR_GYM, %01000000 + db VIRIDIAN_GYM, %10000000 + db $ff diff --git a/data/tilesets/escape_rope_tilesets.asm b/data/tilesets/escape_rope_tilesets.asm new file mode 100644 index 00000000..6acf8e77 --- /dev/null +++ b/data/tilesets/escape_rope_tilesets.asm @@ -0,0 +1,3 @@ +EscapeRopeTilesets: + db FOREST, CEMETERY, CAVERN, FACILITY, INTERIOR + db $ff ; terminator diff --git a/engine/events/hidden_objects/gym_statues.asm b/engine/events/hidden_objects/gym_statues.asm index 97b01a3a..1c7eb970 100644 --- a/engine/events/hidden_objects/gym_statues.asm +++ b/engine/events/hidden_objects/gym_statues.asm @@ -6,7 +6,7 @@ GymStatues: ld a, [wSpritePlayerStateData1FacingDirection] cp SPRITE_FACING_UP ret nz - ld hl, .BadgeFlags + ld hl, MapBadgeFlags ld a, [wCurMap] ld b, a .loop @@ -28,16 +28,7 @@ GymStatues: .haveBadge jp PrintPredefTextID -.BadgeFlags: - db PEWTER_GYM, %00000001 - db CERULEAN_GYM, %00000010 - db VERMILION_GYM,%00000100 - db CELADON_GYM, %00001000 - db FUCHSIA_GYM, %00010000 - db SAFFRON_GYM, %00100000 - db CINNABAR_GYM, %01000000 - db VIRIDIAN_GYM, %10000000 - db $ff +INCLUDE "data/maps/badge_maps.asm" GymStatueText1:: text_far _GymStatueText1 diff --git a/engine/items/item_effects.asm b/engine/items/item_effects.asm index b04f11fb..a8ff1e06 100755 --- a/engine/items/item_effects.asm +++ b/engine/items/item_effects.asm @@ -1525,9 +1525,7 @@ ItemUseEscapeRope: .notUsable jp ItemUseNotTime -EscapeRopeTilesets: - db FOREST, CEMETERY, CAVERN, FACILITY, INTERIOR - db $ff ; terminator +INCLUDE "data/tilesets/escape_rope_tilesets.asm" ItemUseRepel: ld b, 100 -- cgit v1.2.3