From b6e0d649e7a80e06fb21e3858bcb1c1beb270980 Mon Sep 17 00:00:00 2001 From: SnorlaxMonster Date: Sat, 19 Jun 2021 21:56:40 +1000 Subject: Correct comments on SwitchAndTeleportEffect The comments in the SwitchAndTeleportEffect section incorrectly stated that the random number was generated in the half-open interval [0, playerLevel + enemyLevel), instead of the closed interval [0, playerLevel + enemyLevel]. --- engine/battle/effects.asm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/engine/battle/effects.asm b/engine/battle/effects.asm index 6f860cd2..283a794b 100644 --- a/engine/battle/effects.asm +++ b/engine/battle/effects.asm @@ -855,14 +855,14 @@ SwitchAndTeleportEffect: jr nc, .playerMoveWasSuccessful ; if so, teleport will always succeed add b ld c, a - inc c ; c = sum of player level and enemy level + inc c ; c = playerLevel + enemyLevel + 1 .rejectionSampleLoop1 call BattleRandom cp c ; get a random number between 0 and c jr nc, .rejectionSampleLoop1 srl b srl b ; b = enemyLevel / 4 - cp b ; is rand[0, playerLevel + enemyLevel) >= (enemyLevel / 4)? + cp b ; is rand[0, playerLevel + enemyLevel] >= (enemyLevel / 4)? jr nc, .playerMoveWasSuccessful ; if so, allow teleporting ld c, 50 call DelayFrames -- cgit v1.2.3