summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKurausukun <lord.uber1@gmail.com>2020-09-15 18:59:56 -0400
committerKurausukun <lord.uber1@gmail.com>2020-09-15 18:59:56 -0400
commitecb8847e6cfceaa3ba4b87a15e141f77181c4fa9 (patch)
tree57f09143a8c9479cd4f091b0e46b452391dc0ef9
parent412e61c2b3eefc3cc4771f7b3d1ee859e5bb5e81 (diff)
Updated Reduce Noise and Improve Sound Quality (Implementing a New Mixer) (markdown)
-rw-r--r--Reduce-Noise-and-Improve-Sound-Quality-(Implementing-a-New-Mixer).md10
1 files changed, 10 insertions, 0 deletions
diff --git a/Reduce-Noise-and-Improve-Sound-Quality-(Implementing-a-New-Mixer).md b/Reduce-Noise-and-Improve-Sound-Quality-(Implementing-a-New-Mixer).md
index 1fb8969..4183821 100644
--- a/Reduce-Noise-and-Improve-Sound-Quality-(Implementing-a-New-Mixer).md
+++ b/Reduce-Noise-and-Improve-Sound-Quality-(Implementing-a-New-Mixer).md
@@ -38,6 +38,16 @@ Here, `[size]` is the length of one frame of audio, which varies by the sample r
```
Just find the sample rate you're using and use its corresponding frame size as the size of the array. For example, for the default sample rate, the size of the array is 0xE0 (note that the size of the array actually needs to be the frame size x 4; this is why this array is of type `u32` rather than `char` or `u8`).
+Additionally, if you are planning on building the `modern` target, you will need to change
+```c
+struct SoundInfo gSoundInfo = {0};
+```
+to
+```c
+EWRAM_DATA struct SoundInfo gSoundInfo = {0};
+```
+In the vanilla build, we rely on `sym_ewram.txt` to put that symbol in the EWRAM section, but the `modern` target does not use `sym_ewram.txt`, which means that if we do not add this macro, the linker will attempt to put it into IWRAM, which will overflow the section and cause it not to build.
+
Next, remove the following from [common_syms/m4a.txt](https://github.com/pret/pokeemerald/blob/master/common_syms/m4a.txt):
```
gSoundInfo