summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGriffinR <griffin.richards@comcast.net>2019-10-08 02:25:31 -0400
committerGriffinR <griffin.richards@comcast.net>2019-10-08 02:25:31 -0400
commit70d1d8956e47a2258133389373278183a8fb9ef8 (patch)
treefe7f1afed1554974ccd581c649fab2025d52b2eb
parent628301d6d59def09c4c21f85f949e93a98838606 (diff)
Document elite_four.inc and the E4 map scripts
-rw-r--r--data/maps/EverGrandeCity_ChampionsRoom/scripts.inc154
-rw-r--r--data/maps/EverGrandeCity_DrakesRoom/map.json2
-rw-r--r--data/maps/EverGrandeCity_DrakesRoom/scripts.inc61
-rw-r--r--data/maps/EverGrandeCity_GlaciasRoom/map.json2
-rw-r--r--data/maps/EverGrandeCity_GlaciasRoom/scripts.inc60
-rw-r--r--data/maps/EverGrandeCity_PhoebesRoom/map.json2
-rw-r--r--data/maps/EverGrandeCity_PhoebesRoom/scripts.inc60
-rw-r--r--data/maps/EverGrandeCity_SidneysRoom/map.json2
-rw-r--r--data/maps/EverGrandeCity_SidneysRoom/scripts.inc61
-rw-r--r--data/scripts/elite_four.inc24
-rw-r--r--data/scripts/movement.inc6
11 files changed, 211 insertions, 223 deletions
diff --git a/data/maps/EverGrandeCity_ChampionsRoom/scripts.inc b/data/maps/EverGrandeCity_ChampionsRoom/scripts.inc
index 8e4e93770..2b2a6e8ac 100644
--- a/data/maps/EverGrandeCity_ChampionsRoom/scripts.inc
+++ b/data/maps/EverGrandeCity_ChampionsRoom/scripts.inc
@@ -1,140 +1,140 @@
EverGrandeCity_ChampionsRoom_MapScripts:: @ 82289EF
map_script MAP_SCRIPT_ON_TRANSITION, EverGrandeCity_ChampionsRoom_OnTransition
- map_script MAP_SCRIPT_ON_WARP_INTO_MAP_TABLE, EverGrandeCity_ChampionsRoom_MapScript2_228A05
- map_script MAP_SCRIPT_ON_FRAME_TABLE, EverGrandeCity_ChampionsRoom_MapScript2_228A14
+ map_script MAP_SCRIPT_ON_WARP_INTO_MAP_TABLE, EverGrandeCity_ChampionsRoom_MapScript2_OnWarp
+ map_script MAP_SCRIPT_ON_FRAME_TABLE, EverGrandeCity_ChampionsRoom_MapScript2_OnFrame
.byte 0
EverGrandeCity_ChampionsRoom_OnTransition: @ 82289FF
call Common_EventScript_SetupRivalGfxId
end
-EverGrandeCity_ChampionsRoom_MapScript2_228A05: @ 8228A05
- map_script_2 VAR_TEMP_1, 0, EverGrandeCity_ChampionsRoom_EventScript_228A0F
+EverGrandeCity_ChampionsRoom_MapScript2_OnWarp: @ 8228A05
+ map_script_2 VAR_TEMP_1, 0, EverGrandeCity_ChampionsRoom_EventScript_PlayerTurnNorth
.2byte 0
-EverGrandeCity_ChampionsRoom_EventScript_228A0F:: @ 8228A0F
+EverGrandeCity_ChampionsRoom_EventScript_PlayerTurnNorth:: @ 8228A0F
turnobject EVENT_OBJ_ID_PLAYER, DIR_NORTH
end
-EverGrandeCity_ChampionsRoom_MapScript2_228A14: @ 8228A14
- map_script_2 VAR_TEMP_1, 0, EverGrandeCity_ChampionsRoom_EventScript_228A1E
+EverGrandeCity_ChampionsRoom_MapScript2_OnFrame: @ 8228A14
+ map_script_2 VAR_TEMP_1, 0, EverGrandeCity_ChampionsRoom_EventScript_EnterRoom
.2byte 0
-EverGrandeCity_ChampionsRoom_EventScript_228A1E:: @ 8228A1E
+EverGrandeCity_ChampionsRoom_EventScript_EnterRoom:: @ 8228A1E
lockall
- applymovement EVENT_OBJ_ID_PLAYER, EverGrandeCity_ChampionsRoom_Movement_2725C1
+ applymovement EVENT_OBJ_ID_PLAYER, Common_Movement_WalkUp4
waitmovement 0
delay 40
- applymovement EVENT_OBJ_ID_PLAYER, EverGrandeCity_ChampionsRoom_Movement_228A42
+ applymovement EVENT_OBJ_ID_PLAYER, EverGrandeCity_ChampionsRoom_Movement_PlayerApproachWallace
waitmovement 0
setvar VAR_TEMP_1, 1
- goto EverGrandeCity_ChampionsRoom_EventScript_228A45
+ goto EverGrandeCity_ChampionsRoom_EventScript_Wallace
releaseall
end
-EverGrandeCity_ChampionsRoom_Movement_228A42: @ 8228A42
+EverGrandeCity_ChampionsRoom_Movement_PlayerApproachWallace: @ 8228A42
walk_up
walk_up
step_end
-EverGrandeCity_ChampionsRoom_EventScript_228A45:: @ 8228A45
+EverGrandeCity_ChampionsRoom_EventScript_Wallace:: @ 8228A45
playbgm MUS_DAIGO, 0
- msgbox EverGrandeCity_ChampionsRoom_Text_228C4C, MSGBOX_DEFAULT
- trainerbattle_no_intro TRAINER_WALLACE, EverGrandeCity_ChampionsRoom_Text_228EAC
- goto EverGrandeCity_ChampionsRoom_EventScript_228A61
+ msgbox EverGrandeCity_ChampionsRoom_Text_PreBattleSpeech, MSGBOX_DEFAULT
+ trainerbattle_no_intro TRAINER_WALLACE, EverGrandeCity_ChampionsRoom_Text_Defeat
+ goto EverGrandeCity_ChampionsRoom_EventScript_Defeated
end
-EverGrandeCity_ChampionsRoom_EventScript_228A61:: @ 8228A61
+EverGrandeCity_ChampionsRoom_EventScript_Defeated:: @ 8228A61
playse SE_DOOR
setmetatile 6, 1, METATILE_EliteFour_OpenDoorChampion_Frame, 0
setmetatile 6, 2, METATILE_EliteFour_OpenDoorChampion_Opening, 0
special DrawWholeMapView
- msgbox EverGrandeCity_ChampionsRoom_Text_228F66, MSGBOX_DEFAULT
+ msgbox EverGrandeCity_ChampionsRoom_Text_PostBattleSpeech, MSGBOX_DEFAULT
closemessage
playse SE_DOOR
checkplayergender
compare VAR_RESULT, MALE
- call_if_eq EverGrandeCity_ChampionsRoom_EventScript_228ABC
+ call_if_eq EverGrandeCity_ChampionsRoom_EventScript_PlayMayMusic
compare VAR_RESULT, FEMALE
- call_if_eq EverGrandeCity_ChampionsRoom_EventScript_228AC1
+ call_if_eq EverGrandeCity_ChampionsRoom_EventScript_PlayBrendanMusic
addobject 2
- call EverGrandeCity_ChampionsRoom_EventScript_228BFD
+ call EverGrandeCity_ChampionsRoom_EventScript_RivalApproachPlayer
checkplayergender
compare VAR_RESULT, MALE
- goto_if_eq EverGrandeCity_ChampionsRoom_EventScript_228AC6
+ goto_if_eq EverGrandeCity_ChampionsRoom_EventScript_MayAdvice
compare VAR_RESULT, FEMALE
- goto_if_eq EverGrandeCity_ChampionsRoom_EventScript_228AFB
+ goto_if_eq EverGrandeCity_ChampionsRoom_EventScript_BrendanAdvice
end
-EverGrandeCity_ChampionsRoom_EventScript_228ABC:: @ 8228ABC
+EverGrandeCity_ChampionsRoom_EventScript_PlayMayMusic:: @ 8228ABC
playbgm MUS_GIRL_SUP, 0
return
-EverGrandeCity_ChampionsRoom_EventScript_228AC1:: @ 8228AC1
+EverGrandeCity_ChampionsRoom_EventScript_PlayBrendanMusic:: @ 8228AC1
playbgm MUS_BOY_SUP, 0
return
-EverGrandeCity_ChampionsRoom_EventScript_228AC6:: @ 8228AC6
- msgbox EverGrandeCity_ChampionsRoom_Text_2290CA, MSGBOX_DEFAULT
+EverGrandeCity_ChampionsRoom_EventScript_MayAdvice:: @ 8228AC6
+ msgbox EverGrandeCity_ChampionsRoom_Text_MayAdvice, MSGBOX_DEFAULT
delay 40
playse SE_PIN
applymovement 2, Common_Movement_ExclamationMark
waitmovement 0
applymovement 2, Common_Movement_Delay48
waitmovement 0
- call EverGrandeCity_ChampionsRoom_EventScript_228C12
- msgbox EverGrandeCity_ChampionsRoom_Text_22910B, MSGBOX_DEFAULT
- goto EverGrandeCity_ChampionsRoom_EventScript_228B30
+ call EverGrandeCity_ChampionsRoom_EventScript_RivalLookBackAndForth
+ msgbox EverGrandeCity_ChampionsRoom_Text_MayItsAlreadyOver, MSGBOX_DEFAULT
+ goto EverGrandeCity_ChampionsRoom_EventScript_BirchArrivesExitForHoF
end
-EverGrandeCity_ChampionsRoom_EventScript_228AFB:: @ 8228AFB
- msgbox EverGrandeCity_ChampionsRoom_Text_229152, MSGBOX_DEFAULT
+EverGrandeCity_ChampionsRoom_EventScript_BrendanAdvice:: @ 8228AFB
+ msgbox EverGrandeCity_ChampionsRoom_Text_BrendanAdvice, MSGBOX_DEFAULT
delay 40
playse SE_PIN
applymovement 2, Common_Movement_ExclamationMark
waitmovement 0
applymovement 2, Common_Movement_Delay48
waitmovement 0
- call EverGrandeCity_ChampionsRoom_EventScript_228C12
- msgbox EverGrandeCity_ChampionsRoom_Text_2291A2, MSGBOX_DEFAULT
- goto EverGrandeCity_ChampionsRoom_EventScript_228B30
+ call EverGrandeCity_ChampionsRoom_EventScript_RivalLookBackAndForth
+ msgbox EverGrandeCity_ChampionsRoom_Text_BrendanYouveWon, MSGBOX_DEFAULT
+ goto EverGrandeCity_ChampionsRoom_EventScript_BirchArrivesExitForHoF
end
-EverGrandeCity_ChampionsRoom_EventScript_228B30:: @ 8228B30
+EverGrandeCity_ChampionsRoom_EventScript_BirchArrivesExitForHoF:: @ 8228B30
closemessage
addobject 3
- applymovement 3, EverGrandeCity_ChampionsRoom_Movement_228C43
+ applymovement 3, EverGrandeCity_ChampionsRoom_Movement_BirchArrives
waitmovement 0
applymovement EVENT_OBJ_ID_PLAYER, Common_Movement_WalkInPlaceRight
waitmovement 0
- msgbox EverGrandeCity_ChampionsRoom_Text_2291E6, MSGBOX_DEFAULT
+ msgbox EverGrandeCity_ChampionsRoom_Text_BirchArriveRatePokedex, MSGBOX_DEFAULT
call ProfBirch_EventScript_RatePokedex
- msgbox EverGrandeCity_ChampionsRoom_Text_22934D, MSGBOX_DEFAULT
+ msgbox EverGrandeCity_ChampionsRoom_Text_BirchCongratulations, MSGBOX_DEFAULT
applymovement 1, Common_Movement_WalkInPlaceUp
waitmovement 0
delay 20
applymovement 1, Common_Movement_WalkInPlaceDown
waitmovement 0
- msgbox EverGrandeCity_ChampionsRoom_Text_229399, MSGBOX_DEFAULT
+ msgbox EverGrandeCity_ChampionsRoom_Text_WallaceComeWithMe, MSGBOX_DEFAULT
closemessage
delay 30
- applymovement 1, EverGrandeCity_ChampionsRoom_Movement_228C3B
- applymovement EVENT_OBJ_ID_PLAYER, EverGrandeCity_ChampionsRoom_Movement_228C1D
+ applymovement 1, EverGrandeCity_ChampionsRoom_Movement_WallaceExitStart
+ applymovement EVENT_OBJ_ID_PLAYER, EverGrandeCity_ChampionsRoom_Movement_PlayerExitStart
applymovement 3, Common_Movement_WalkInPlaceUp
- applymovement 2, EverGrandeCity_ChampionsRoom_Movement_228C38
+ applymovement 2, EverGrandeCity_ChampionsRoom_Movement_RivalFollows
waitmovement 0
delay 20
applymovement EVENT_OBJ_ID_PLAYER, Common_Movement_WalkInPlaceDown
waitmovement 0
- msgbox EverGrandeCity_ChampionsRoom_Text_2293EB, MSGBOX_DEFAULT
+ msgbox EverGrandeCity_ChampionsRoom_Text_WallaceWaitOutside, MSGBOX_DEFAULT
checkplayergender
compare VAR_RESULT, MALE
- call_if_eq EverGrandeCity_ChampionsRoom_EventScript_228BEB
+ call_if_eq EverGrandeCity_ChampionsRoom_EventScript_MayCongratulations
compare VAR_RESULT, FEMALE
- call_if_eq EverGrandeCity_ChampionsRoom_EventScript_228BF4
+ call_if_eq EverGrandeCity_ChampionsRoom_EventScript_BrendanCongratulations
closemessage
- applymovement 1, EverGrandeCity_ChampionsRoom_Movement_228C3F
- applymovement EVENT_OBJ_ID_PLAYER, EverGrandeCity_ChampionsRoom_Movement_228C20
+ applymovement 1, EverGrandeCity_ChampionsRoom_Movement_WallaceExit
+ applymovement EVENT_OBJ_ID_PLAYER, EverGrandeCity_ChampionsRoom_Movement_PlayerExit
waitmovement 0
setflag FLAG_HIDE_PETALBURG_GYM_GREETER
warp MAP_EVER_GRANDE_CITY_HALL_OF_FAME, 255, 7, 16
@@ -142,32 +142,32 @@ EverGrandeCity_ChampionsRoom_EventScript_228B30:: @ 8228B30
releaseall
end
-EverGrandeCity_ChampionsRoom_EventScript_228BEB:: @ 8228BEB
- msgbox EverGrandeCity_ChampionsRoom_Text_229479, MSGBOX_DEFAULT
+EverGrandeCity_ChampionsRoom_EventScript_MayCongratulations:: @ 8228BEB
+ msgbox EverGrandeCity_ChampionsRoom_Text_MayCongratulations, MSGBOX_DEFAULT
return
-EverGrandeCity_ChampionsRoom_EventScript_228BF4:: @ 8228BF4
- msgbox EverGrandeCity_ChampionsRoom_Text_2294F5, MSGBOX_DEFAULT
+EverGrandeCity_ChampionsRoom_EventScript_BrendanCongratulations:: @ 8228BF4
+ msgbox EverGrandeCity_ChampionsRoom_Text_BrendanCongratulations, MSGBOX_DEFAULT
return
-EverGrandeCity_ChampionsRoom_EventScript_228BFD:: @ 8228BFD
- applymovement 2, EverGrandeCity_ChampionsRoom_Movement_228C26
+EverGrandeCity_ChampionsRoom_EventScript_RivalApproachPlayer:: @ 8228BFD
+ applymovement 2, EverGrandeCity_ChampionsRoom_Movement_RivalApproachPlayer
waitmovement 0
applymovement EVENT_OBJ_ID_PLAYER, Common_Movement_WalkInPlaceLeft
waitmovement 0
return
-EverGrandeCity_ChampionsRoom_EventScript_228C12:: @ 8228C12
- applymovement 2, EverGrandeCity_ChampionsRoom_Movement_228C2F
+EverGrandeCity_ChampionsRoom_EventScript_RivalLookBackAndForth:: @ 8228C12
+ applymovement 2, EverGrandeCity_ChampionsRoom_Movement_RivalLookBackAndForth
waitmovement 0
return
-EverGrandeCity_ChampionsRoom_Movement_228C1D: @ 8228C1D
+EverGrandeCity_ChampionsRoom_Movement_PlayerExitStart: @ 8228C1D
walk_up
walk_up
step_end
-EverGrandeCity_ChampionsRoom_Movement_228C20: @ 8228C20
+EverGrandeCity_ChampionsRoom_Movement_PlayerExit: @ 8228C20
walk_up
delay_16
walk_up
@@ -175,7 +175,7 @@ EverGrandeCity_ChampionsRoom_Movement_228C20: @ 8228C20
set_invisible
step_end
-EverGrandeCity_ChampionsRoom_Movement_228C26: @ 8228C26
+EverGrandeCity_ChampionsRoom_Movement_RivalApproachPlayer: @ 8228C26
walk_up
walk_up
walk_up
@@ -186,7 +186,7 @@ EverGrandeCity_ChampionsRoom_Movement_228C26: @ 8228C26
walk_in_place_fastest_right
step_end
-EverGrandeCity_ChampionsRoom_Movement_228C2F: @ 8228C2F
+EverGrandeCity_ChampionsRoom_Movement_RivalLookBackAndForth: @ 8228C2F
walk_in_place_fastest_up
delay_16
walk_in_place_fastest_right
@@ -197,24 +197,24 @@ EverGrandeCity_ChampionsRoom_Movement_228C2F: @ 8228C2F
delay_16
step_end
-EverGrandeCity_ChampionsRoom_Movement_228C38: @ 8228C38
+EverGrandeCity_ChampionsRoom_Movement_RivalFollows: @ 8228C38
walk_right
walk_up
step_end
-EverGrandeCity_ChampionsRoom_Movement_228C3B: @ 8228C3B
+EverGrandeCity_ChampionsRoom_Movement_WallaceExitStart: @ 8228C3B
walk_up
walk_up
walk_in_place_fastest_down
step_end
-EverGrandeCity_ChampionsRoom_Movement_228C3F: @ 8228C3F
+EverGrandeCity_ChampionsRoom_Movement_WallaceExit: @ 8228C3F
walk_up
delay_8
set_invisible
step_end
-EverGrandeCity_ChampionsRoom_Movement_228C43: @ 8228C43
+EverGrandeCity_ChampionsRoom_Movement_BirchArrives: @ 8228C43
walk_up
walk_up
walk_up
@@ -225,7 +225,7 @@ EverGrandeCity_ChampionsRoom_Movement_228C43: @ 8228C43
walk_in_place_fastest_left
step_end
-EverGrandeCity_ChampionsRoom_Text_228C4C: @ 8228C4C
+EverGrandeCity_ChampionsRoom_Text_PreBattleSpeech: @ 8228C4C
.string "WALLACE: Welcome, {PLAYER}{KUN}.\p"
.string "That incident in SOOTOPOLIS CITY…\n"
.string "That was superb work, putting an end\l"
@@ -248,7 +248,7 @@ EverGrandeCity_ChampionsRoom_Text_228C4C: @ 8228C4C
.string "their POKéMON in HOENN?\p"
.string "Show me right here and now!$"
-EverGrandeCity_ChampionsRoom_Text_228EAC: @ 8228EAC
+EverGrandeCity_ChampionsRoom_Text_Defeat: @ 8228EAC
.string "I, the CHAMPION, fall in defeat…\p"
.string "That was wonderful work.\n"
.string "You were elegant, infuriatingly so.\l"
@@ -257,7 +257,7 @@ EverGrandeCity_ChampionsRoom_Text_228EAC: @ 8228EAC
.string "You are a truly noble POKéMON\n"
.string "TRAINER!$"
-EverGrandeCity_ChampionsRoom_Text_228F66: @ 8228F66
+EverGrandeCity_ChampionsRoom_Text_PostBattleSpeech: @ 8228F66
.string "WALLACE: The POKéMON you sent into\n"
.string "battle…\p"
.string "At times they danced like a spring\n"
@@ -272,29 +272,29 @@ EverGrandeCity_ChampionsRoom_Text_228F66: @ 8228F66
.string "I now proclaim you to be the new\n"
.string "HOENN region…$"
-EverGrandeCity_ChampionsRoom_Text_2290CA: @ 82290CA
+EverGrandeCity_ChampionsRoom_Text_MayAdvice: @ 82290CA
.string "MAY: {PLAYER}{KUN}!\p"
.string "Here's some advice before you challenge\n"
.string "the CHAMPION…$"
-EverGrandeCity_ChampionsRoom_Text_22910B: @ 822910B
+EverGrandeCity_ChampionsRoom_Text_MayItsAlreadyOver: @ 822910B
.string "MAY: Huh?\n"
.string "What, what, what?\p"
.string "{PLAYER}{KUN}…\n"
.string "Could it be that…\l"
.string "It's already over?$"
-EverGrandeCity_ChampionsRoom_Text_229152: @ 8229152
+EverGrandeCity_ChampionsRoom_Text_BrendanAdvice: @ 8229152
.string "BRENDAN: {PLAYER}!\p"
.string "How would you like some advice before\n"
.string "you challenge the CHAMPION?…$"
-EverGrandeCity_ChampionsRoom_Text_2291A2: @ 82291A2
+EverGrandeCity_ChampionsRoom_Text_BrendanYouveWon: @ 82291A2
.string "BRENDAN: {PLAYER}…\p"
.string "Are you trying to tell me…\n"
.string "You've beaten the CHAMPION?$"
-EverGrandeCity_ChampionsRoom_Text_2291E6: @ 82291E6
+EverGrandeCity_ChampionsRoom_Text_BirchArriveRatePokedex: @ 82291E6
.string "PROF. BIRCH: See?\n"
.string "What did I tell you, {RIVAL}?\p"
.string "Didn't I tell you that you don't need\n"
@@ -310,25 +310,25 @@ EverGrandeCity_ChampionsRoom_Text_2291E6: @ 82291E6
.string "What became of your POKéDEX?\n"
.string "Here, let me see.$"
-EverGrandeCity_ChampionsRoom_Text_22934D: @ 822934D
+EverGrandeCity_ChampionsRoom_Text_BirchCongratulations: @ 822934D
.string "PROF. BIRCH: Anyways,\n"
.string "congratulations!\p"
.string "Now, go proudly into the final room!$"
-EverGrandeCity_ChampionsRoom_Text_229399: @ 8229399
+EverGrandeCity_ChampionsRoom_Text_WallaceComeWithMe: @ 8229399
.string "WALLACE: {PLAYER}{KUN}…\p"
.string "No, let me rephrase that properly.\p"
.string "The new CHAMPION!\p"
.string "Come with me.$"
-EverGrandeCity_ChampionsRoom_Text_2293EB: @ 82293EB
+EverGrandeCity_ChampionsRoom_Text_WallaceWaitOutside: @ 82293EB
.string "WALLACE: I'm sorry, but…\p"
.string "From here on, only those TRAINERS who\n"
.string "have become CHAMPIONS may enter.\p"
.string "You'll have to wait outside with\n"
.string "PROF. BIRCH.$"
-EverGrandeCity_ChampionsRoom_Text_229479: @ 8229479
+EverGrandeCity_ChampionsRoom_Text_MayCongratulations: @ 8229479
.string "MAY: Groan…\p"
.string "… … … … … … … …\n"
.string "… … … … … … … …\p"
@@ -337,7 +337,7 @@ EverGrandeCity_ChampionsRoom_Text_229479: @ 8229479
.string "{PLAYER}{KUN}!\n"
.string "Honestly, congratulations!$"
-EverGrandeCity_ChampionsRoom_Text_2294F5: @ 82294F5
+EverGrandeCity_ChampionsRoom_Text_BrendanCongratulations: @ 82294F5
.string "BRENDAN: Whaaaat?! … … … … …\n"
.string "… … … … … … … …\p"
.string "It can't be helped if that's the rule.\p"
diff --git a/data/maps/EverGrandeCity_DrakesRoom/map.json b/data/maps/EverGrandeCity_DrakesRoom/map.json
index 4fb0d16ef..5ff910790 100644
--- a/data/maps/EverGrandeCity_DrakesRoom/map.json
+++ b/data/maps/EverGrandeCity_DrakesRoom/map.json
@@ -24,7 +24,7 @@
"movement_range_y": 0,
"trainer_type": "0",
"trainer_sight_or_berry_tree_id": "0",
- "script": "EverGrandeCity_DrakesRoom_EventScript_2286F3",
+ "script": "EverGrandeCity_DrakesRoom_EventScript_Drake",
"flag": "0"
}
],
diff --git a/data/maps/EverGrandeCity_DrakesRoom/scripts.inc b/data/maps/EverGrandeCity_DrakesRoom/scripts.inc
index bfc1b6027..3acc0da74 100644
--- a/data/maps/EverGrandeCity_DrakesRoom/scripts.inc
+++ b/data/maps/EverGrandeCity_DrakesRoom/scripts.inc
@@ -1,67 +1,68 @@
EverGrandeCity_DrakesRoom_MapScripts:: @ 822869C
- map_script MAP_SCRIPT_ON_FRAME_TABLE, EverGrandeCity_DrakesRoom_MapScript2_2286BB
- map_script MAP_SCRIPT_ON_LOAD, EverGrandeCity_DrakesRoom_MapScript1_2286D2
- map_script MAP_SCRIPT_ON_WARP_INTO_MAP_TABLE, EverGrandeCity_DrakesRoom_MapScript2_227F3E
+ map_script MAP_SCRIPT_ON_FRAME_TABLE, EverGrandeCity_DrakesRoom_MapScript2_OnFrame
+ map_script MAP_SCRIPT_ON_LOAD, EverGrandeCity_DrakesRoom_MapScript1_OnLoad
+ map_script MAP_SCRIPT_ON_WARP_INTO_MAP_TABLE, EverGrandeCity_SidneysRoom_MapScript2_OnWarp
.byte 0
-EverGrandeCity_DrakesRoom_MapScript2_2286AC: @ 82286AC
- map_script_2 VAR_TEMP_1, 0, EverGrandeCity_DrakesRoom_EventScript_2286B6
+@ Unused, Drake uses Sidneys identical OnWarp for some reason
+EverGrandeCity_DrakesRoom_MapScript2_OnWarp: @ 82286AC
+ map_script_2 VAR_TEMP_1, 0, EverGrandeCity_DrakesRoom_EventScript_PlayerTurnNorth
.2byte 0
-EverGrandeCity_DrakesRoom_EventScript_2286B6:: @ 82286B6
+EverGrandeCity_DrakesRoom_EventScript_PlayerTurnNorth:: @ 82286B6
turnobject EVENT_OBJ_ID_PLAYER, DIR_NORTH
end
-EverGrandeCity_DrakesRoom_MapScript2_2286BB: @ 82286BB
- map_script_2 VAR_ELITE_4_STATE, 3, EverGrandeCity_DrakesRoom_EventScript_2286C5
+EverGrandeCity_DrakesRoom_MapScript2_OnFrame: @ 82286BB
+ map_script_2 VAR_ELITE_4_STATE, 3, EverGrandeCity_DrakesRoom_EventScript_WalkInCloseDoor
.2byte 0
-EverGrandeCity_DrakesRoom_EventScript_2286C5:: @ 82286C5
+EverGrandeCity_DrakesRoom_EventScript_WalkInCloseDoor:: @ 82286C5
lockall
- call EverGrandeCity_DrakesRoom_EventScript_272475
+ call PokemonLeague_EliteFour_EventScript_WalkInCloseDoor
setvar VAR_ELITE_4_STATE, 4
releaseall
end
-EverGrandeCity_DrakesRoom_MapScript1_2286D2: @ 82286D2
- call_if_set FLAG_DEFEATED_ELITE_4_DRAKE, EverGrandeCity_DrakesRoom_EventScript_2286E7
+EverGrandeCity_DrakesRoom_MapScript1_OnLoad: @ 82286D2
+ call_if_set FLAG_DEFEATED_ELITE_4_DRAKE, EverGrandeCity_DrakesRoom_EventScript_ResetAdvanceToNextRoom
compare VAR_ELITE_4_STATE, 4
- call_if_eq EverGrandeCity_DrakesRoom_EventScript_2286ED
+ call_if_eq EverGrandeCity_DrakesRoom_EventScript_CloseDoor
end
-EverGrandeCity_DrakesRoom_EventScript_2286E7:: @ 82286E7
- call EverGrandeCity_DrakesRoom_EventScript_2724BC
+EverGrandeCity_DrakesRoom_EventScript_ResetAdvanceToNextRoom:: @ 82286E7
+ call PokemonLeague_EliteFour_EventScript_ResetAdvanceToNextRoom
return
-EverGrandeCity_DrakesRoom_EventScript_2286ED:: @ 82286ED
- call EverGrandeCity_DrakesRoom_EventScript_27255F
+EverGrandeCity_DrakesRoom_EventScript_CloseDoor:: @ 82286ED
+ call PokemonLeague_EliteFour_EventScript_CloseDoor
return
-EverGrandeCity_DrakesRoom_EventScript_2286F3:: @ 82286F3
+EverGrandeCity_DrakesRoom_EventScript_Drake:: @ 82286F3
lock
faceplayer
- goto_if_set FLAG_DEFEATED_ELITE_4_DRAKE, EverGrandeCity_DrakesRoom_EventScript_22871A
+ goto_if_set FLAG_DEFEATED_ELITE_4_DRAKE, EverGrandeCity_DrakesRoom_EventScript_PostBattleSpeech
playbgm MUS_SITENNOU, 0
- msgbox EverGrandeCity_DrakesRoom_Text_22873E, MSGBOX_DEFAULT
- trainerbattle_no_intro TRAINER_DRAKE, EverGrandeCity_DrakesRoom_Text_228895
- goto EverGrandeCity_DrakesRoom_EventScript_228724
+ msgbox EverGrandeCity_DrakesRoom_Text_PreBattleSpeech, MSGBOX_DEFAULT
+ trainerbattle_no_intro TRAINER_DRAKE, EverGrandeCity_DrakesRoom_Text_Defeat
+ goto EverGrandeCity_DrakesRoom_EventScript_Defeated
end
-EverGrandeCity_DrakesRoom_EventScript_22871A:: @ 822871A
- msgbox EverGrandeCity_DrakesRoom_Text_2288B0, MSGBOX_DEFAULT
+EverGrandeCity_DrakesRoom_EventScript_PostBattleSpeech:: @ 822871A
+ msgbox EverGrandeCity_DrakesRoom_Text_PostBattleSpeech, MSGBOX_DEFAULT
release
end
-EverGrandeCity_DrakesRoom_EventScript_228724:: @ 8228724
+EverGrandeCity_DrakesRoom_EventScript_Defeated:: @ 8228724
setvar VAR_0x8004, 0
special sub_813BF7C
setflag FLAG_DEFEATED_ELITE_4_DRAKE
- call EverGrandeCity_DrakesRoom_EventScript_2723F8
- msgbox EverGrandeCity_DrakesRoom_Text_2288B0, MSGBOX_DEFAULT
+ call PokemonLeague_EliteFour_SetAdvanceToNextRoomMetatiles
+ msgbox EverGrandeCity_DrakesRoom_Text_PostBattleSpeech, MSGBOX_DEFAULT
release
end
-EverGrandeCity_DrakesRoom_Text_22873E: @ 822873E
+EverGrandeCity_DrakesRoom_Text_PreBattleSpeech: @ 822873E
.string "I am the last of the POKéMON LEAGUE\n"
.string "ELITE FOUR, DRAKE the DRAGON master!\p"
.string "In their natural state, POKéMON are\n"
@@ -74,10 +75,10 @@ EverGrandeCity_DrakesRoom_Text_22873E: @ 822873E
.string "If you don't, then you will never\n"
.string "prevail over me!$"
-EverGrandeCity_DrakesRoom_Text_228895: @ 8228895
+EverGrandeCity_DrakesRoom_Text_Defeat: @ 8228895
.string "Superb, it should be said.$"
-EverGrandeCity_DrakesRoom_Text_2288B0: @ 82288B0
+EverGrandeCity_DrakesRoom_Text_PostBattleSpeech: @ 82288B0
.string "You deserve every credit for coming\n"
.string "this far as a TRAINER of POKéMON.\p"
.string "You do seem to know what is needed.\p"
diff --git a/data/maps/EverGrandeCity_GlaciasRoom/map.json b/data/maps/EverGrandeCity_GlaciasRoom/map.json
index ea3116460..8d220202e 100644
--- a/data/maps/EverGrandeCity_GlaciasRoom/map.json
+++ b/data/maps/EverGrandeCity_GlaciasRoom/map.json
@@ -24,7 +24,7 @@
"movement_range_y": 0,
"trainer_type": "0",
"trainer_sight_or_berry_tree_id": "0",
- "script": "EverGrandeCity_GlaciasRoom_EventScript_228469",
+ "script": "EverGrandeCity_GlaciasRoom_EventScript_Glacia",
"flag": "0"
}
],
diff --git a/data/maps/EverGrandeCity_GlaciasRoom/scripts.inc b/data/maps/EverGrandeCity_GlaciasRoom/scripts.inc
index 00e829930..b260f4dee 100644
--- a/data/maps/EverGrandeCity_GlaciasRoom/scripts.inc
+++ b/data/maps/EverGrandeCity_GlaciasRoom/scripts.inc
@@ -1,65 +1,65 @@
EverGrandeCity_GlaciasRoom_MapScripts:: @ 8228412
- map_script MAP_SCRIPT_ON_FRAME_TABLE, EverGrandeCity_GlaciasRoom_MapScript2_228431
- map_script MAP_SCRIPT_ON_LOAD, EverGrandeCity_GlaciasRoom_MapScript1_228448
- map_script MAP_SCRIPT_ON_WARP_INTO_MAP_TABLE, EverGrandeCity_GlaciasRoom_MapScript2_228422
+ map_script MAP_SCRIPT_ON_FRAME_TABLE, EverGrandeCity_GlaciasRoom_MapScript2_OnFrame
+ map_script MAP_SCRIPT_ON_LOAD, EverGrandeCity_GlaciasRoom_MapScript1_OnLoad
+ map_script MAP_SCRIPT_ON_WARP_INTO_MAP_TABLE, EverGrandeCity_GlaciasRoom_MapScript2_OnWarp
.byte 0
-EverGrandeCity_GlaciasRoom_MapScript2_228422: @ 8228422
- map_script_2 VAR_TEMP_1, 0, EverGrandeCity_GlaciasRoom_EventScript_22842C
+EverGrandeCity_GlaciasRoom_MapScript2_OnWarp: @ 8228422
+ map_script_2 VAR_TEMP_1, 0, EverGrandeCity_GlaciasRoom_EventScript_PlayerTurnNorth
.2byte 0
-EverGrandeCity_GlaciasRoom_EventScript_22842C:: @ 822842C
+EverGrandeCity_GlaciasRoom_EventScript_PlayerTurnNorth:: @ 822842C
turnobject EVENT_OBJ_ID_PLAYER, DIR_NORTH
end
-EverGrandeCity_GlaciasRoom_MapScript2_228431: @ 8228431
- map_script_2 VAR_ELITE_4_STATE, 2, EverGrandeCity_GlaciasRoom_EventScript_22843B
+EverGrandeCity_GlaciasRoom_MapScript2_OnFrame: @ 8228431
+ map_script_2 VAR_ELITE_4_STATE, 2, EverGrandeCity_GlaciasRoom_EventScript_WalkInCloseDoor
.2byte 0
-EverGrandeCity_GlaciasRoom_EventScript_22843B:: @ 822843B
+EverGrandeCity_GlaciasRoom_EventScript_WalkInCloseDoor:: @ 822843B
lockall
- call EverGrandeCity_GlaciasRoom_EventScript_272475
+ call PokemonLeague_EliteFour_EventScript_WalkInCloseDoor
setvar VAR_ELITE_4_STATE, 3
releaseall
end
-EverGrandeCity_GlaciasRoom_MapScript1_228448: @ 8228448
- call_if_set FLAG_DEFEATED_ELITE_4_GLACIA, EverGrandeCity_GlaciasRoom_EventScript_22845D
+EverGrandeCity_GlaciasRoom_MapScript1_OnLoad: @ 8228448
+ call_if_set FLAG_DEFEATED_ELITE_4_GLACIA, EverGrandeCity_GlaciasRoom_EventScript_ResetAdvanceToNextRoom
compare VAR_ELITE_4_STATE, 3
- call_if_eq EverGrandeCity_GlaciasRoom_EventScript_228463
+ call_if_eq EverGrandeCity_GlaciasRoom_EventScript_CloseDoor
end
-EverGrandeCity_GlaciasRoom_EventScript_22845D:: @ 822845D
- call EverGrandeCity_GlaciasRoom_EventScript_2724BC
+EverGrandeCity_GlaciasRoom_EventScript_ResetAdvanceToNextRoom:: @ 822845D
+ call PokemonLeague_EliteFour_EventScript_ResetAdvanceToNextRoom
return
-EverGrandeCity_GlaciasRoom_EventScript_228463:: @ 8228463
- call EverGrandeCity_GlaciasRoom_EventScript_27255F
+EverGrandeCity_GlaciasRoom_EventScript_CloseDoor:: @ 8228463
+ call PokemonLeague_EliteFour_EventScript_CloseDoor
return
-EverGrandeCity_GlaciasRoom_EventScript_228469:: @ 8228469
+EverGrandeCity_GlaciasRoom_EventScript_Glacia:: @ 8228469
lock
faceplayer
- goto_if_set FLAG_DEFEATED_ELITE_4_GLACIA, EverGrandeCity_GlaciasRoom_EventScript_228490
+ goto_if_set FLAG_DEFEATED_ELITE_4_GLACIA, EverGrandeCity_GlaciasRoom_EventScript_PostBattleSpeech
playbgm MUS_SITENNOU, 0
- msgbox EverGrandeCity_GlaciasRoom_Text_2284AC, MSGBOX_DEFAULT
- trainerbattle_no_intro TRAINER_GLACIA, EverGrandeCity_GlaciasRoom_Text_2285B4
- goto EverGrandeCity_GlaciasRoom_EventScript_22849A
+ msgbox EverGrandeCity_GlaciasRoom_Text_PreBattleSpeech, MSGBOX_DEFAULT
+ trainerbattle_no_intro TRAINER_GLACIA, EverGrandeCity_GlaciasRoom_Text_Defeat
+ goto EverGrandeCity_GlaciasRoom_EventScript_Defeated
end
-EverGrandeCity_GlaciasRoom_EventScript_228490:: @ 8228490
- msgbox EverGrandeCity_GlaciasRoom_Text_228640, MSGBOX_DEFAULT
+EverGrandeCity_GlaciasRoom_EventScript_PostBattleSpeech:: @ 8228490
+ msgbox EverGrandeCity_GlaciasRoom_Text_PostBattleSpeech, MSGBOX_DEFAULT
release
end
-EverGrandeCity_GlaciasRoom_EventScript_22849A:: @ 822849A
+EverGrandeCity_GlaciasRoom_EventScript_Defeated:: @ 822849A
setflag FLAG_DEFEATED_ELITE_4_GLACIA
- call EverGrandeCity_GlaciasRoom_EventScript_2723F8
- msgbox EverGrandeCity_GlaciasRoom_Text_228640, MSGBOX_DEFAULT
+ call PokemonLeague_EliteFour_SetAdvanceToNextRoomMetatiles
+ msgbox EverGrandeCity_GlaciasRoom_Text_PostBattleSpeech, MSGBOX_DEFAULT
release
end
-EverGrandeCity_GlaciasRoom_Text_2284AC: @ 82284AC
+EverGrandeCity_GlaciasRoom_Text_PreBattleSpeech: @ 82284AC
.string "Welcome, my name is GLACIA\n"
.string "of the ELITE FOUR.\p"
.string "I've traveled from afar to HOENN\n"
@@ -70,14 +70,14 @@ EverGrandeCity_GlaciasRoom_Text_2284AC: @ 82284AC
.string "It would please me to no end if I could\n"
.string "go all out against you!$"
-EverGrandeCity_GlaciasRoom_Text_2285B4: @ 82285B4
+EverGrandeCity_GlaciasRoom_Text_Defeat: @ 82285B4
.string "You and your POKéMON…\n"
.string "How hot your spirits burn!\p"
.string "The all-consuming heat overwhelms.\p"
.string "It's no surprise that my icy skills\n"
.string "failed to harm you.$"
-EverGrandeCity_GlaciasRoom_Text_228640: @ 8228640
+EverGrandeCity_GlaciasRoom_Text_PostBattleSpeech: @ 8228640
.string "Advance to the next room.\p"
.string "And there, confirm the truly fearsome\n"
.string "side of the POKéMON LEAGUE.$"
diff --git a/data/maps/EverGrandeCity_PhoebesRoom/map.json b/data/maps/EverGrandeCity_PhoebesRoom/map.json
index a0072fd08..73ee3357d 100644
--- a/data/maps/EverGrandeCity_PhoebesRoom/map.json
+++ b/data/maps/EverGrandeCity_PhoebesRoom/map.json
@@ -24,7 +24,7 @@
"movement_range_y": 0,
"trainer_type": "0",
"trainer_sight_or_berry_tree_id": "0",
- "script": "EverGrandeCity_PhoebesRoom_EventScript_2281CB",
+ "script": "EverGrandeCity_PhoebesRoom_EventScript_Phoebe",
"flag": "0"
}
],
diff --git a/data/maps/EverGrandeCity_PhoebesRoom/scripts.inc b/data/maps/EverGrandeCity_PhoebesRoom/scripts.inc
index b5a3a9999..f3b4f739f 100644
--- a/data/maps/EverGrandeCity_PhoebesRoom/scripts.inc
+++ b/data/maps/EverGrandeCity_PhoebesRoom/scripts.inc
@@ -1,65 +1,65 @@
EverGrandeCity_PhoebesRoom_MapScripts:: @ 8228174
- map_script MAP_SCRIPT_ON_LOAD, EverGrandeCity_PhoebesRoom_MapScript1_2281AA
- map_script MAP_SCRIPT_ON_WARP_INTO_MAP_TABLE, EverGrandeCity_PhoebesRoom_MapScript2_228184
- map_script MAP_SCRIPT_ON_FRAME_TABLE, EverGrandeCity_PhoebesRoom_MapScript2_228193
+ map_script MAP_SCRIPT_ON_LOAD, EverGrandeCity_PhoebesRoom_MapScript1_OnLoad
+ map_script MAP_SCRIPT_ON_WARP_INTO_MAP_TABLE, EverGrandeCity_PhoebesRoom_MapScript2_OnWarp
+ map_script MAP_SCRIPT_ON_FRAME_TABLE, EverGrandeCity_PhoebesRoom_MapScript2_OnFrame
.byte 0
-EverGrandeCity_PhoebesRoom_MapScript2_228184: @ 8228184
- map_script_2 VAR_TEMP_1, 0, EverGrandeCity_PhoebesRoom_EventScript_22818E
+EverGrandeCity_PhoebesRoom_MapScript2_OnWarp: @ 8228184
+ map_script_2 VAR_TEMP_1, 0, EverGrandeCity_PhoebesRoom_EventScript_PlayerTurnNorth
.2byte 0
-EverGrandeCity_PhoebesRoom_EventScript_22818E:: @ 822818E
+EverGrandeCity_PhoebesRoom_EventScript_PlayerTurnNorth:: @ 822818E
turnobject EVENT_OBJ_ID_PLAYER, DIR_NORTH
end
-EverGrandeCity_PhoebesRoom_MapScript2_228193: @ 8228193
- map_script_2 VAR_ELITE_4_STATE, 1, EverGrandeCity_PhoebesRoom_EventScript_22819D
+EverGrandeCity_PhoebesRoom_MapScript2_OnFrame: @ 8228193
+ map_script_2 VAR_ELITE_4_STATE, 1, EverGrandeCity_PhoebesRoom_EventScript_WalkInCloseDoor
.2byte 0
-EverGrandeCity_PhoebesRoom_EventScript_22819D:: @ 822819D
+EverGrandeCity_PhoebesRoom_EventScript_WalkInCloseDoor:: @ 822819D
lockall
- call EverGrandeCity_PhoebesRoom_EventScript_272475
+ call PokemonLeague_EliteFour_EventScript_WalkInCloseDoor
setvar VAR_ELITE_4_STATE, 2
releaseall
end
-EverGrandeCity_PhoebesRoom_MapScript1_2281AA: @ 82281AA
- call_if_set FLAG_DEFEATED_ELITE_4_PHOEBE, EverGrandeCity_PhoebesRoom_EventScript_2281BF
+EverGrandeCity_PhoebesRoom_MapScript1_OnLoad: @ 82281AA
+ call_if_set FLAG_DEFEATED_ELITE_4_PHOEBE, EverGrandeCity_PhoebesRoom_EventScript_ResetAdvanceToNextRoom
compare VAR_ELITE_4_STATE, 2
- call_if_eq EverGrandeCity_PhoebesRoom_EventScript_2281C5
+ call_if_eq EverGrandeCity_PhoebesRoom_EventScript_CloseDoor
end
-EverGrandeCity_PhoebesRoom_EventScript_2281BF:: @ 82281BF
- call EverGrandeCity_PhoebesRoom_EventScript_2724BC
+EverGrandeCity_PhoebesRoom_EventScript_ResetAdvanceToNextRoom:: @ 82281BF
+ call PokemonLeague_EliteFour_EventScript_ResetAdvanceToNextRoom
return
-EverGrandeCity_PhoebesRoom_EventScript_2281C5:: @ 82281C5
- call EverGrandeCity_PhoebesRoom_EventScript_27255F
+EverGrandeCity_PhoebesRoom_EventScript_CloseDoor:: @ 82281C5
+ call PokemonLeague_EliteFour_EventScript_CloseDoor
return
-EverGrandeCity_PhoebesRoom_EventScript_2281CB:: @ 82281CB
+EverGrandeCity_PhoebesRoom_EventScript_Phoebe:: @ 82281CB
lock
faceplayer
- goto_if_set FLAG_DEFEATED_ELITE_4_PHOEBE, EverGrandeCity_PhoebesRoom_EventScript_2281F2
+ goto_if_set FLAG_DEFEATED_ELITE_4_PHOEBE, EverGrandeCity_PhoebesRoom_EventScript_PostBattleSpeech
playbgm MUS_SITENNOU, 0
- msgbox EverGrandeCity_PhoebesRoom_Text_22820E, MSGBOX_DEFAULT
- trainerbattle_no_intro TRAINER_PHOEBE, EverGrandeCity_PhoebesRoom_Text_228325
- goto EverGrandeCity_PhoebesRoom_EventScript_2281FC
+ msgbox EverGrandeCity_PhoebesRoom_Text_PreBattleSpeech, MSGBOX_DEFAULT
+ trainerbattle_no_intro TRAINER_PHOEBE, EverGrandeCity_PhoebesRoom_Text_Defeat
+ goto EverGrandeCity_PhoebesRoom_EventScript_Defeated
end
-EverGrandeCity_PhoebesRoom_EventScript_2281F2:: @ 82281F2
- msgbox EverGrandeCity_PhoebesRoom_Text_228343, MSGBOX_DEFAULT
+EverGrandeCity_PhoebesRoom_EventScript_PostBattleSpeech:: @ 82281F2
+ msgbox EverGrandeCity_PhoebesRoom_Text_PostBattleSpeech, MSGBOX_DEFAULT
release
end
-EverGrandeCity_PhoebesRoom_EventScript_2281FC:: @ 82281FC
+EverGrandeCity_PhoebesRoom_EventScript_Defeated:: @ 82281FC
setflag FLAG_DEFEATED_ELITE_4_PHOEBE
- call EverGrandeCity_PhoebesRoom_EventScript_2723F8
- msgbox EverGrandeCity_PhoebesRoom_Text_228343, MSGBOX_DEFAULT
+ call PokemonLeague_EliteFour_SetAdvanceToNextRoomMetatiles
+ msgbox EverGrandeCity_PhoebesRoom_Text_PostBattleSpeech, MSGBOX_DEFAULT
release
end
-EverGrandeCity_PhoebesRoom_Text_22820E: @ 822820E
+EverGrandeCity_PhoebesRoom_Text_PreBattleSpeech: @ 822820E
.string "Ahahaha!\p"
.string "I'm PHOEBE of the ELITE FOUR.\n"
.string "I did my training on MT. PYRE.\p"
@@ -70,11 +70,11 @@ EverGrandeCity_PhoebesRoom_Text_22820E: @ 822820E
.string "So, come on, just try and see if you can\n"
.string "even inflict damage on my POKéMON!$"
-EverGrandeCity_PhoebesRoom_Text_228325: @ 8228325
+EverGrandeCity_PhoebesRoom_Text_Defeat: @ 8228325
.string "Oh, darn.\n"
.string "I've gone and lost.$"
-EverGrandeCity_PhoebesRoom_Text_228343: @ 8228343
+EverGrandeCity_PhoebesRoom_Text_PostBattleSpeech: @ 8228343
.string "There's a definite bond between you\n"
.string "and your POKéMON, too.\p"
.string "I didn't recognize it, so it's only\n"
diff --git a/data/maps/EverGrandeCity_SidneysRoom/map.json b/data/maps/EverGrandeCity_SidneysRoom/map.json
index 87545b597..0aa57a944 100644
--- a/data/maps/EverGrandeCity_SidneysRoom/map.json
+++ b/data/maps/EverGrandeCity_SidneysRoom/map.json
@@ -24,7 +24,7 @@
"movement_range_y": 0,
"trainer_type": "0",
"trainer_sight_or_berry_tree_id": "0",
- "script": "EverGrandeCity_SidneysRoom_EventScript_227F64",
+ "script": "EverGrandeCity_SidneysRoom_EventScript_Sidney",
"flag": "0"
}
],
diff --git a/data/maps/EverGrandeCity_SidneysRoom/scripts.inc b/data/maps/EverGrandeCity_SidneysRoom/scripts.inc
index 432747fda..2806b64ac 100644
--- a/data/maps/EverGrandeCity_SidneysRoom/scripts.inc
+++ b/data/maps/EverGrandeCity_SidneysRoom/scripts.inc
@@ -1,8 +1,8 @@
EverGrandeCity_SidneysRoom_MapScripts:: @ 8227F01
- map_script MAP_SCRIPT_ON_LOAD, EverGrandeCity_SidneysRoom_MapScript1_227F1D
- map_script MAP_SCRIPT_ON_WARP_INTO_MAP_TABLE, EverGrandeCity_SidneysRoom_MapScript2_227F3E
+ map_script MAP_SCRIPT_ON_LOAD, EverGrandeCity_SidneysRoom_MapScript1_OnLoad
+ map_script MAP_SCRIPT_ON_WARP_INTO_MAP_TABLE, EverGrandeCity_SidneysRoom_MapScript2_OnWarp
map_script MAP_SCRIPT_ON_TRANSITION, EverGrandeCity_SidneysRoom_OnTransition
- map_script MAP_SCRIPT_ON_FRAME_TABLE, EverGrandeCity_SidneysRoom_MapScript2_227F4D
+ map_script MAP_SCRIPT_ON_FRAME_TABLE, EverGrandeCity_SidneysRoom_MapScript2_OnFrame
.byte 0
EverGrandeCity_SidneysRoom_OnTransition: @ 8227F16
@@ -10,63 +10,62 @@ EverGrandeCity_SidneysRoom_OnTransition: @ 8227F16
setflag FLAG_HIDE_EVER_GRANDE_POKEMON_CENTER_1F_SCOTT
end
-EverGrandeCity_SidneysRoom_MapScript1_227F1D: @ 8227F1D
- call_if_set FLAG_DEFEATED_ELITE_4_SIDNEY, EverGrandeCity_SidneysRoom_EventScript_227F32
+EverGrandeCity_SidneysRoom_MapScript1_OnLoad: @ 8227F1D
+ call_if_set FLAG_DEFEATED_ELITE_4_SIDNEY, EverGrandeCity_SidneysRoom_EventScript_ResetAdvanceToNextRoom
compare VAR_ELITE_4_STATE, 1
- call_if_eq EverGrandeCity_SidneysRoom_EventScript_227F38
+ call_if_eq EverGrandeCity_SidneysRoom_EventScript_CloseDoor
end
-EverGrandeCity_SidneysRoom_EventScript_227F32:: @ 8227F32
- call EverGrandeCity_SidneysRoom_EventScript_2724BC
+EverGrandeCity_SidneysRoom_EventScript_ResetAdvanceToNextRoom:: @ 8227F32
+ call PokemonLeague_EliteFour_EventScript_ResetAdvanceToNextRoom
return
-EverGrandeCity_SidneysRoom_EventScript_227F38:: @ 8227F38
- call EverGrandeCity_SidneysRoom_EventScript_27255F
+EverGrandeCity_SidneysRoom_EventScript_CloseDoor:: @ 8227F38
+ call PokemonLeague_EliteFour_EventScript_CloseDoor
return
-EverGrandeCity_DrakesRoom_MapScript2_227F3E: @ 8227F3E
-EverGrandeCity_SidneysRoom_MapScript2_227F3E: @ 8227F3E
- map_script_2 VAR_TEMP_1, 0, EverGrandeCity_SidneysRoom_EventScript_227F48
+EverGrandeCity_SidneysRoom_MapScript2_OnWarp: @ 8227F3E
+ map_script_2 VAR_TEMP_1, 0, EverGrandeCity_SidneysRoom_EventScript_PlayerTurnNorth
.2byte 0
-EverGrandeCity_SidneysRoom_EventScript_227F48:: @ 8227F48
+EverGrandeCity_SidneysRoom_EventScript_PlayerTurnNorth:: @ 8227F48
turnobject EVENT_OBJ_ID_PLAYER, DIR_NORTH
end
-EverGrandeCity_SidneysRoom_MapScript2_227F4D: @ 8227F4D
- map_script_2 VAR_ELITE_4_STATE, 0, EverGrandeCity_SidneysRoom_EventScript_227F57
+EverGrandeCity_SidneysRoom_MapScript2_OnFrame: @ 8227F4D
+ map_script_2 VAR_ELITE_4_STATE, 0, EverGrandeCity_SidneysRoom_EventScript_WalkInCloseDoor
.2byte 0
-EverGrandeCity_SidneysRoom_EventScript_227F57:: @ 8227F57
+EverGrandeCity_SidneysRoom_EventScript_WalkInCloseDoor:: @ 8227F57
lockall
- call EverGrandeCity_SidneysRoom_EventScript_272475
+ call PokemonLeague_EliteFour_EventScript_WalkInCloseDoor
setvar VAR_ELITE_4_STATE, 1
releaseall
end
-EverGrandeCity_SidneysRoom_EventScript_227F64:: @ 8227F64
+EverGrandeCity_SidneysRoom_EventScript_Sidney:: @ 8227F64
lock
faceplayer
- goto_if_set FLAG_DEFEATED_ELITE_4_SIDNEY, EverGrandeCity_SidneysRoom_EventScript_227F8B
+ goto_if_set FLAG_DEFEATED_ELITE_4_SIDNEY, EverGrandeCity_SidneysRoom_EventScript_PostBattleSpeech
playbgm MUS_SITENNOU, 0
- msgbox EverGrandeCity_SidneysRoom_Text_227FA7, MSGBOX_DEFAULT
- trainerbattle_no_intro TRAINER_SIDNEY, EverGrandeCity_SidneysRoom_Text_2280A2
- goto EverGrandeCity_SidneysRoom_EventScript_227F95
+ msgbox EverGrandeCity_SidneysRoom_Text_PreBattleSpeech, MSGBOX_DEFAULT
+ trainerbattle_no_intro TRAINER_SIDNEY, EverGrandeCity_SidneysRoom_Text_Defeat
+ goto EverGrandeCity_SidneysRoom_EventScript_Defeated
end
-EverGrandeCity_SidneysRoom_EventScript_227F8B:: @ 8227F8B
- msgbox EverGrandeCity_SidneysRoom_Text_2280EC, MSGBOX_DEFAULT
+EverGrandeCity_SidneysRoom_EventScript_PostBattleSpeech:: @ 8227F8B
+ msgbox EverGrandeCity_SidneysRoom_Text_PostBattleSpeech, MSGBOX_DEFAULT
release
end
-EverGrandeCity_SidneysRoom_EventScript_227F95:: @ 8227F95
+EverGrandeCity_SidneysRoom_EventScript_Defeated:: @ 8227F95
setflag FLAG_DEFEATED_ELITE_4_SIDNEY
- call EverGrandeCity_SidneysRoom_EventScript_2723F8
- msgbox EverGrandeCity_SidneysRoom_Text_2280EC, MSGBOX_DEFAULT
+ call PokemonLeague_EliteFour_SetAdvanceToNextRoomMetatiles
+ msgbox EverGrandeCity_SidneysRoom_Text_PostBattleSpeech, MSGBOX_DEFAULT
release
end
-EverGrandeCity_SidneysRoom_Text_227FA7: @ 8227FA7
+EverGrandeCity_SidneysRoom_Text_PreBattleSpeech: @ 8227FA7
.string "Welcome, challenger!\n"
.string "I'm SIDNEY of the ELITE FOUR.\p"
.string "I like that look you're giving me.\n"
@@ -76,11 +75,11 @@ EverGrandeCity_SidneysRoom_Text_227FA7: @ 8227FA7
.string "a battle that can only be staged\l"
.string "here in the POKéMON LEAGUE!$"
-EverGrandeCity_SidneysRoom_Text_2280A2: @ 82280A2
+EverGrandeCity_SidneysRoom_Text_Defeat: @ 82280A2
.string "Well, how do you like that? I lost!\n"
.string "Eh, it was fun, so it doesn't matter.$"
-EverGrandeCity_SidneysRoom_Text_2280EC: @ 82280EC
+EverGrandeCity_SidneysRoom_Text_PostBattleSpeech: @ 82280EC
.string "Well, listen to what this loser has\n"
.string "to say.\p"
.string "You've got what it takes to go far.\n"
diff --git a/data/scripts/elite_four.inc b/data/scripts/elite_four.inc
index c6b8d5578..e7aada698 100644
--- a/data/scripts/elite_four.inc
+++ b/data/scripts/elite_four.inc
@@ -1,9 +1,5 @@
-EverGrandeCity_DrakesRoom_EventScript_2723F8:: @ 82723F8
-EverGrandeCity_GlaciasRoom_EventScript_2723F8:: @ 82723F8
-EverGrandeCity_PhoebesRoom_EventScript_2723F8:: @ 82723F8
-EverGrandeCity_SidneysRoom_EventScript_2723F8:: @ 82723F8
PokemonLeague_EliteFour_SetAdvanceToNextRoomMetatiles:: @ 82723F8
- applymovement EVENT_OBJ_ID_PLAYER, EverGrandeCity_SidneysRoom_Movement_2725C6
+ applymovement EVENT_OBJ_ID_PLAYER, Common_Movement_Delay32
waitmovement 0
playse SE_DOOR
setmetatile 6, 1, METATILE_EliteFour_OpenDoor_Frame, 0
@@ -21,11 +17,8 @@ PokemonLeague_EliteFour_SetAdvanceToNextRoomMetatiles:: @ 82723F8
special DrawWholeMapView
return
-EverGrandeCity_DrakesRoom_EventScript_272475:: @ 8272475
-EverGrandeCity_GlaciasRoom_EventScript_272475:: @ 8272475
-EverGrandeCity_PhoebesRoom_EventScript_272475:: @ 8272475
-EverGrandeCity_SidneysRoom_EventScript_272475:: @ 8272475
- applymovement EVENT_OBJ_ID_PLAYER, EverGrandeCity_SidneysRoom_Movement_2725BA
+PokemonLeague_EliteFour_EventScript_WalkInCloseDoor:: @ 8272475
+ applymovement EVENT_OBJ_ID_PLAYER, Common_Movement_WalkUp6
waitmovement 0
playse SE_TRACK_DOOR
setmetatile 5, 12, METATILE_EliteFour_EntryDoor_ClosedTop, 1
@@ -37,10 +30,8 @@ EverGrandeCity_SidneysRoom_EventScript_272475:: @ 8272475
special DrawWholeMapView
return
-EverGrandeCity_DrakesRoom_EventScript_2724BC:: @ 82724BC
-EverGrandeCity_GlaciasRoom_EventScript_2724BC:: @ 82724BC
-EverGrandeCity_PhoebesRoom_EventScript_2724BC:: @ 82724BC
-EverGrandeCity_SidneysRoom_EventScript_2724BC:: @ 82724BC
+@ Essentially unused, only necessary when re-entering an Elite Four room after defeating the member, which isnt normally possible
+PokemonLeague_EliteFour_EventScript_ResetAdvanceToNextRoom:: @ 82724BC
setmetatile 6, 1, METATILE_EliteFour_OpenDoor_Frame, 0
setmetatile 6, 2, METATILE_EliteFour_OpenDoor_Opening, 0
setmetatile 5, 12, METATILE_EliteFour_EntryDoor_ClosedTop, 1
@@ -61,10 +52,7 @@ EverGrandeCity_SidneysRoom_EventScript_2724BC:: @ 82724BC
setmetatile 12, 2, METATILE_EliteFour_LeftSpotlightOff, 1
return
-EverGrandeCity_DrakesRoom_EventScript_27255F:: @ 827255F
-EverGrandeCity_GlaciasRoom_EventScript_27255F:: @ 827255F
-EverGrandeCity_PhoebesRoom_EventScript_27255F:: @ 827255F
-EverGrandeCity_SidneysRoom_EventScript_27255F:: @ 827255F
+PokemonLeague_EliteFour_EventScript_CloseDoor:: @ 827255F
setmetatile 5, 12, METATILE_EliteFour_EntryDoor_ClosedTop, 1
setmetatile 6, 12, METATILE_EliteFour_EntryDoor_ClosedTop, 1
setmetatile 7, 12, METATILE_EliteFour_EntryDoor_ClosedTop, 1
diff --git a/data/scripts/movement.inc b/data/scripts/movement.inc
index b7abceae4..a50c5eeda 100644
--- a/data/scripts/movement.inc
+++ b/data/scripts/movement.inc
@@ -70,7 +70,7 @@ Route121_Movement_2725B8: @ 82725B8
walk_in_place_right
step_end
-EverGrandeCity_SidneysRoom_Movement_2725BA: @ 82725BA
+Common_Movement_WalkUp6: @ 82725BA
walk_up
walk_up
walk_up
@@ -79,14 +79,14 @@ EverGrandeCity_SidneysRoom_Movement_2725BA: @ 82725BA
walk_up
step_end
-EverGrandeCity_ChampionsRoom_Movement_2725C1: @ 82725C1
+Common_Movement_WalkUp4: @ 82725C1
walk_up
walk_up
walk_up
walk_up
step_end
-EverGrandeCity_SidneysRoom_Movement_2725C6: @ 82725C6
+Common_Movement_Delay32: @ 82725C6
delay_16
delay_16
step_end