summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRangi <remy.oukaour+rangi42@gmail.com>2018-07-17 18:16:15 -0400
committerRangi <remy.oukaour+rangi42@gmail.com>2018-07-17 18:16:15 -0400
commit9a95b1e9e88f2f38280a5b364f59c6938ff7f4d5 (patch)
treeeda90d4213c434076d99f0bb12c34a257bc5033b
parentb6b88543a90f220ace29e93df6c13cd5c19b154e (diff)
parent210a4b50369554e6d7b2ea9b610b2d16f2376c7a (diff)
Merge branch 'master' of https://github.com/pret/pokecrystal.wiki
-rw-r--r--Code-cleanup.md10
1 files changed, 10 insertions, 0 deletions
diff --git a/Code-cleanup.md b/Code-cleanup.md
index 9feb984..5989dcf 100644
--- a/Code-cleanup.md
+++ b/Code-cleanup.md
@@ -6,6 +6,16 @@ These are all general issues with the pokecrystal code. Keep an eye out for oppo
Reformat code to adhere to [STYLE.md](../tree/master/STYLE.md). (Converting labels to `.snake_case` is one that stands out.)
+### Take advantage of up-to-date rgbds features
+
+As of 0.3.7, we have these features that are little-used:
+
+- `~` works for bytes, so we can do `~X` instead of `$ff ^ X`
+- `HIGH()` and `LOW()` work for constants
+- `BANK(@)` gets the current bank; `BANK("Section Name")` is also valid (some labels can thus be removed)
+- `\` continues lines, like in C or Python, which could help clean up long macros (`trainer`, `npctrade`) and implement new ones (like for data/trainers/attributes.asm or data/pokemon/base_stats/\*.asm)
+
+
### Meaningless temporary labels
Look for `UnknownText_*`, `UnknownScript_*`, `Unknown_*`, and `Function_*`.