summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRangi <remy.oukaour+rangi42@gmail.com>2018-06-25 14:14:06 -0400
committerRangi <remy.oukaour+rangi42@gmail.com>2018-06-25 14:14:06 -0400
commite16a11db12d74f41c836ef036560fe7976d620a5 (patch)
treef3b05bbf5dcc2008d288e69c22b797e8c61dbac2
parent4ce2dcec85f867a2dd389827d15781b02471f86a (diff)
Note PRs
-rw-r--r--Expand-tilesets-from-192-to-255-tiles.md48
1 files changed, 25 insertions, 23 deletions
diff --git a/Expand-tilesets-from-192-to-255-tiles.md b/Expand-tilesets-from-192-to-255-tiles.md
index 21148a4..422cf0d 100644
--- a/Expand-tilesets-from-192-to-255-tiles.md
+++ b/Expand-tilesets-from-192-to-255-tiles.md
@@ -554,6 +554,8 @@ Edit [engine/events/halloffame.asm](../blob/master/engine/events/halloffame.asm)
## 10. Correct other implicit assumptions about tiles
+These changes were already made to pokecrystal by pull requests [#530](../pull/530) and [#534](../pull/534) as of June 25, 2018, so if your copy is newer than that you can skip this step.
+
Edit [engine/pokemon/correct_nick_errors.asm](../blob/master/engine/pokemon/correct_nick_errors.asm):
```diff
@@ -572,7 +574,29 @@ Edit [engine/pokemon/correct_nick_errors.asm](../blob/master/engine/pokemon/corr
db -1 ; end
```
-Edit [engine/link/link_2.asm](../blob/master/engine/link/link_2.asm) (this was already done for pokecrystal [as of June 24, 2018](../pull/530/files#diff-dbdfd305a9c556d3eff6d19cb4bce1c8)):
+Edit [engine/pokegear/pokegear.asm](../blob/master/engine/pokegear/pokegear.asm):
+
+```diff
+ .jump_return
+ push de
+ hlcoord 0, 12
+ lb bc, 4, 18
+ call TextBox
+ hlcoord 1, 14
+- ld [hl], $72
++ ld [hl], "“"
+ pop de
+ hlcoord 2, 14
+ call PlaceString
+ ld h, b
+ ld l, c
+- ld [hl], $73
++ ld [hl], "”"
+ call WaitBGMap
+ ret
+```
+
+And edit [engine/link/link_2.asm](../blob/master/engine/link/link_2.asm):
```diff
LinkTextbox2:
@@ -623,28 +647,6 @@ Edit [engine/link/link_2.asm](../blob/master/engine/link/link_2.asm) (this was a
ret
```
-And edit [engine/pokegear/pokegear.asm](../blob/master/engine/pokegear/pokegear.asm) (this was already done for pokecrystal [as of June 25, 2018](../pull/534/files#diff-3ce949d911b8c7bce6331fc5828a5d86L2012)):
-
-```diff
- .jump_return
- push de
- hlcoord 0, 12
- lb bc, 4, 18
- call TextBox
- hlcoord 1, 14
-- ld [hl], $72
-+ ld [hl], "“"
- pop de
- hlcoord 2, 14
- call PlaceString
- ld h, b
- ld l, c
-- ld [hl], $73
-+ ld [hl], "”"
- call WaitBGMap
- ret
-```
-
Now the game will work just like before:
![Screenshot](screenshots/255-tiles-overworld.png)