summaryrefslogtreecommitdiff
path: root/Add-a-new-map-and-landmark.md
diff options
context:
space:
mode:
authorRangi <remy.oukaour+rangi42@gmail.com>2018-06-24 22:48:58 -0400
committerRangi <remy.oukaour+rangi42@gmail.com>2018-06-24 22:48:58 -0400
commitcd7e915b044213918291bc9d26ce6f6682405737 (patch)
tree9d8d958b719591e37209bba292b2e2b80bec187b /Add-a-new-map-and-landmark.md
parent662cd29ce7cd56e419cde80480b656799ed47780 (diff)
Remove address comments
Diffstat (limited to 'Add-a-new-map-and-landmark.md')
-rw-r--r--Add-a-new-map-and-landmark.md12
1 files changed, 4 insertions, 8 deletions
diff --git a/Add-a-new-map-and-landmark.md b/Add-a-new-map-and-landmark.md
index 28d1378..f6855e1 100644
--- a/Add-a-new-map-and-landmark.md
+++ b/Add-a-new-map-and-landmark.md
@@ -118,7 +118,7 @@ The roof type controls which nine roof tiles get used. This only applies to maps
Edit [data/maps/roofs.asm](../blob/master/data/maps/roofs.asm):
```diff
- MapGroupRoofs: ; 1c021i
+ MapGroupRoofs:
; entries correspond to map groups
; values are indexes for Roofs (see below)
db -1 ; 0
@@ -126,7 +126,6 @@ Edit [data/maps/roofs.asm](../blob/master/data/maps/roofs.asm):
...
db ROOF_NEW_BARK ; 26 (Cherrygrove)
+ db ROOF_GOLDENROD ; 27 (Global Terminal)
- ; 1c03c
```
Roof tiles, like all graphics, are only loaded when you warp to a map. Walking across map connections, like from Route 34 to Goldenrod City, will not reload graphics. So if two maps are connected, even if they're in different groups, their roof types have to match. We're going to connect the Global Terminal to Goldenrod City's west edge later, so it has to use the same roof type.
@@ -170,18 +169,17 @@ The outdoor sprite set is the set of sprites it's possible to use in outdoor map
Edit [data/maps/outdoor_sprites.asm](../blob/master/data/maps/outdoor_sprites.asm):
```diff
- OutdoorSprites: ; 144b8
+ OutdoorSprites:
; entries correspond to map groups
dw OlivineGroupSprites
...
dw CherrygroveGroupSprites
+ dw GlobalTerminalSprites
- ; 144ec
...
+GlobalTerminalSprites:
- GoldenrodGroupSprites: ; 14673
+ GoldenrodGroupSprites:
db SPRITE_SUICUNE
db SPRITE_SILVER_TROPHY
db SPRITE_POKE_BALL
@@ -205,7 +203,6 @@ Edit [data/maps/outdoor_sprites.asm](../blob/master/data/maps/outdoor_sprites.as
db SPRITE_DAY_CARE_MON_2
db SPRITE_FRUIT_TREE
db SPRITE_SLOWPOKE
- ; 1468a
```
The Global Terminal is going to be connected to the west edge of Goldenrod City, so they'll have to have identical sprite sets; to save space, they can literally use the same data. Note that, for instance, `OlivineGroupSprites` and `CianwoodGroupSprites` are two different sets but have identical contents, since you can Surf from Olivine City to Cianwood City.
@@ -350,7 +347,7 @@ The Town Map will cycle through landmarks in their constant order.
Now edit [data/maps/landmarks.asm](../blob/master/data/maps/landmarks.asm):
```diff
- Landmarks: ; 0x1ca8c3
+ Landmarks:
; entries correspond to constants/landmark_constants.asm
landmark 0, 0, SpecialMapName
...
@@ -359,7 +356,6 @@ Now edit [data/maps/landmarks.asm](../blob/master/data/maps/landmarks.asm):
landmark 60, 92, Route35Name
...
landmark 148, 132, FastShipName
- ; 0x1caa43
NewBarkTownName: db "NEW BARK¯TOWN@"
...