summaryrefslogtreecommitdiff
path: root/Add-a-new-party-menu-icon.md
diff options
context:
space:
mode:
authorRangi <remy.oukaour+rangi42@gmail.com>2018-06-24 22:48:58 -0400
committerRangi <remy.oukaour+rangi42@gmail.com>2018-06-24 22:48:58 -0400
commitcd7e915b044213918291bc9d26ce6f6682405737 (patch)
tree9d8d958b719591e37209bba292b2e2b80bec187b /Add-a-new-party-menu-icon.md
parent662cd29ce7cd56e419cde80480b656799ed47780 (diff)
Remove address comments
Diffstat (limited to 'Add-a-new-party-menu-icon.md')
-rw-r--r--Add-a-new-party-menu-icon.md12
1 files changed, 5 insertions, 7 deletions
diff --git a/Add-a-new-party-menu-icon.md b/Add-a-new-party-menu-icon.md
index 5b9cca6..6fac8f8 100644
--- a/Add-a-new-party-menu-icon.md
+++ b/Add-a-new-party-menu-icon.md
@@ -55,9 +55,9 @@ And edit [gfx/icons.asm](../blob/master/gfx/icons.asm):
```diff
Icons:
NullIcon:
- PoliwagIcon: INCBIN "gfx/icons/poliwag.2bpp" ; 0x8ec0d
+ PoliwagIcon: INCBIN "gfx/icons/poliwag.2bpp"
...
- BigmonIcon: INCBIN "gfx/icons/bigmon.2bpp" ; 0x8fe8d
+ BigmonIcon: INCBIN "gfx/icons/bigmon.2bpp"
+CelebiIcon: INCBIN "gfx/icons/celebi.2bpp"
```
@@ -67,7 +67,7 @@ And edit [gfx/icons.asm](../blob/master/gfx/icons.asm):
Edit [data/pokemon/menu_icons.asm](../blob/master/data/pokemon/menu_icons.asm):
```diff
- MonMenuIcons: ; 8eac4
+ MonMenuIcons:
...
- db ICON_HUMANSHAPE ; CELEBI
+ db ICON_CELEBI ; CELEBI
@@ -122,7 +122,7 @@ One section, "Mon Icons 1", contains icons #1 to #128. The next, "Mon Icons 2",
Now edit [engine/gfx/mon_icons.asm](../blob/master/engine/gfx/mon_icons.asm):
```diff
- LoadOverworldMonIcon: ; 8e82b
+ LoadOverworldMonIcon:
ld a, e
+ push af
call ReadMonMenuIcon
@@ -139,11 +139,10 @@ Now edit [engine/gfx/mon_icons.asm](../blob/master/engine/gfx/mon_icons.asm):
+ pop af
+ call GetIconBank
ret
- ; 8e83f
...
- GetIcon: ; 8ea1e
+ GetIcon:
; Load icon graphics into VRAM starting from tile hl.
...
@@ -154,7 +153,6 @@ Now edit [engine/gfx/mon_icons.asm](../blob/master/engine/gfx/mon_icons.asm):
pop hl
ret
- ; 8ea3f
+
+GetIconBank:
+ lb bc, BANK("Mon Icons 1"), 8