diff options
| author | Rangi <35663410+Rangi42@users.noreply.github.com> | 2018-07-17 16:58:46 -0400 |
|---|---|---|
| committer | Rangi <35663410+Rangi42@users.noreply.github.com> | 2018-07-17 16:58:46 -0400 |
| commit | 287758e12a26890ed64c0b42a2da6bfcfa051f98 (patch) | |
| tree | 724e1775d71de47f1cc5e080167a58edc473df8a /Code-cleanup.md | |
| parent | 8e24c0a3070f735f588a78991f0174eff64d5346 (diff) | |
Updated Code cleanup (markdown)
Diffstat (limited to 'Code-cleanup.md')
| -rw-r--r-- | Code-cleanup.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Code-cleanup.md b/Code-cleanup.md index e88872e..97f9251 100644 --- a/Code-cleanup.md +++ b/Code-cleanup.md @@ -6,7 +6,7 @@ These are all general issues with the pokecrystal code. Keep an eye out for oppo - `BANK(Label)` (mostly finished for WRAM labels, but still a problem with mobile code) - `SomeLabelEnd - SomeLabel` (some structs and sub-structs still have hard-coded sizes like this) - `(SomeGFXLabel.End - SomeGFXLabel) / LEN_2BPP_TILE` (pokered and pokegold-spaceworld already do this) - - `SOME_BIT_F` bit flags, and `1 << SOME_BIT_F` masks (various hex and binary literals indicate an opportunity for this) + - `SOME_BIT_F` bit flags, and `1 << SOME_BIT_F` masks (various hex and binary literals indicate an opportunity for this) (you can often use the `maskbits` macro for `and $MASK`) - Jumptable indexes (look for raw values being loaded into `[wJumptableIndex]`) - **Text label styles** in [data/text/](../tree/master/data/text/) should be consistent, not a mixture of `Text_*`, `*Text`, and `BattleText_*`. Likewise for the [engine/](../tree/master/engine/) labels that just `text_jump` to one of them. |