diff options
author | i0brendan0 <19826742+i0brendan0@users.noreply.github.com> | 2018-06-02 01:12:52 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-06-02 01:12:52 -0500 |
commit | 158144f9cbebdb076262dc45c05253cb8fbc1acf (patch) | |
tree | e3f50ac74f7616a00f7fbbb84d3db77f250c8ad3 | |
parent | 51bbfee89192cd93c49e3c400ca8745cc3e77e30 (diff) |
undo protect message bug
-rw-r--r-- | docs/bugs_and_glitches.md | 27 |
1 files changed, 0 insertions, 27 deletions
diff --git a/docs/bugs_and_glitches.md b/docs/bugs_and_glitches.md index ce2715d92..efe951263 100644 --- a/docs/bugs_and_glitches.md +++ b/docs/bugs_and_glitches.md @@ -53,7 +53,6 @@ These are known bugs and glitches in the original Pokémon Crystal game: code th - [`TryObjectEvent` arbitrary code execution](#tryobjectevent-arbitrary-code-execution) - [`Special_CheckBugContestContestantFlag` can read beyond its data table](#special_checkbugcontestcontestantflag-can-read-beyond-its-data-table) - [`ClearWRAM` only clears WRAM bank 1](#clearwram-only-clears-wram-bank-1) -- [Moves erroneously say they have missed when the opponent uses Protect or Detect](#moves-erroneously-say-they-have-missed-when-the-opponent-uses-protect-or-detect) ## Thick Club and Light Ball can decrease damage done with boosted (Special) Attack @@ -1493,29 +1492,3 @@ ClearWRAM:: ; 25a ``` **Fix:** Change `jr nc, .bank_loop` to `jr c, .bank_loop`. - -## Moves erroneously say they have missed when the opponent uses Protect or Detect - -In [battle/effect_commands.asm](battle/effect_commands.asm): - -```asm -BattleCommand_CheckHit: ; 34d32 -; checkhit - - call .DreamEater - jp z, .Miss - - call .Protect - jp nz, .Miss -``` - -**Fix:** Change `jp nz, .Miss` to `jp nz, .Failed` and add - -```asm -.Failed: - ld a, 1 - ld [wEffectFailed], a - ret -``` - -at [line 1781](battle/effect_commands.asm#L1718). |