diff options
| author | Rangi <35663410+Rangi42@users.noreply.github.com> | 2020-12-18 09:26:31 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-12-18 09:26:31 -0500 |
| commit | 9978126309d41e55c70a86fef08127c817f48bf9 (patch) | |
| tree | c813ead2bf2c2d32a11e602ac7e53f29d0f327d5 | |
| parent | 3550a87360308167d2751f17daa88c8ccd545e73 (diff) | |
| parent | 49458edf94af31a3bf87c227c7f20870c6c38206 (diff) | |
Merge pull request #792 from nbasu02/document-stat-up-hit-fix
Document fix for StatUpHit effects when opponent is KO'd
| -rw-r--r-- | docs/bugs_and_glitches.md | 41 |
1 files changed, 41 insertions, 0 deletions
diff --git a/docs/bugs_and_glitches.md b/docs/bugs_and_glitches.md index b7873bc05..a3cc96930 100644 --- a/docs/bugs_and_glitches.md +++ b/docs/bugs_and_glitches.md @@ -37,6 +37,7 @@ Fixes in the [multi-player battle engine](#multi-player-battle-engine) category - [Dragon Scale, not Dragon Fang, boosts Dragon-type moves](#dragon-scale-not-dragon-fang-boosts-dragon-type-moves) - [HP bar animation is slow for high HP](#hp-bar-animation-is-slow-for-high-hp) - [HP bar animation off-by-one error for low HP](#hp-bar-animation-off-by-one-error-for-low-hp) + - [Moves that do damage and increase your stats do not increase stats after a KO](#moves-that-do-damage-and-increase-your-stats-do-not-increase-stats-after-a-ko) - [Single-player battle engine](#single-player-battle-engine) - [A Transformed Pokémon can use Sketch and learn otherwise unobtainable moves](#a-transformed-pokémon-can-use-sketch-and-learn-otherwise-unobtainable-moves) - [Catching a Transformed Pokémon always catches a Ditto](#catching-a-transformed-pokémon-always-catches-a-ditto) @@ -764,6 +765,46 @@ This bug existed for all battles in Gold and Silver, and was only fixed for sing jr .loop ``` +### Moves that do damage and increase your stats do not increase stats after a KO + +`BattleCommand_CheckFaint` "ends the move effect if the opponent faints", and these moves attempt to raise the user's stats *after* `checkfaint`. Note that fixing this can lead to stats being increased at the end of battle, but will not have any negative effects. + +**Fix:** Edit [data/moves/effects.asm](https://github.com/pret/pokecrystal/blob/master/data/moves/effects.asm): + +```diff + DefenseUpHit: + ... + criticaltext + supereffectivetext ++ defenseup + checkfaint + buildopponentrage +- defenseup + statupmessage + endmove + + AttackUpHit: + ... + criticaltext + supereffectivetext ++ attackup + checkfaint + buildopponentrage +- attackup + statupmessage + endmove + + AllUpHit: + ... + criticaltext + supereffectivetext ++ allstatsup + checkfaint + buildopponentrage +- allstatsup + endmove +``` + ## Single-player battle engine |