diff options
| author | Rangi <remy.oukaour+rangi42@gmail.com> | 2018-06-12 23:29:15 -0400 |
|---|---|---|
| committer | Rangi <remy.oukaour+rangi42@gmail.com> | 2018-06-12 23:29:15 -0400 |
| commit | fbe82a7fe0f310ade7436d4d8f352ee04e05a1ec (patch) | |
| tree | d474f9d2ee1876cdee83564ddd2e44986eb8a4a4 /docs/design_flaws.md | |
| parent | 6130fc5cd6b002f827d307c64a432e960629cb9b (diff) | |
Note which labels are only needed for locating banks (relevant to issue #485)
Diffstat (limited to 'docs/design_flaws.md')
| -rw-r--r-- | docs/design_flaws.md | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/docs/design_flaws.md b/docs/design_flaws.md index 6b015a56a..7494d5d68 100644 --- a/docs/design_flaws.md +++ b/docs/design_flaws.md @@ -393,10 +393,10 @@ GetDexEntryPointer: ; 44333 ret .PokedexEntryBanks: - db BANK(PokedexEntries1) - db BANK(PokedexEntries2) - db BANK(PokedexEntries3) - db BANK(PokedexEntries4) + db BANK("Pokedex Entries 001-064") + db BANK("Pokedex Entries 065-128") + db BANK("Pokedex Entries 129-192") + db BANK("Pokedex Entries 193-251") ``` `GetPokedexEntryBank` in [engine/items/item_effects.asm](/engine/items/item_effects.asm): @@ -419,10 +419,10 @@ GetPokedexEntryBank: ret .PokedexEntryBanks: - db BANK(PokedexEntries1) - db BANK(PokedexEntries2) - db BANK(PokedexEntries3) - db BANK(PokedexEntries4) + db BANK("Pokedex Entries 001-064") + db BANK("Pokedex Entries 065-128") + db BANK("Pokedex Entries 129-192") + db BANK("Pokedex Entries 193-251") ``` And `PokedexShow_GetDexEntryBank` in [engine/pokegear/radio.asm](/engine/pokegear/radio.asm): @@ -446,10 +446,10 @@ PokedexShow_GetDexEntryBank: ret .PokedexEntryBanks: - db BANK(PokedexEntries1) - db BANK(PokedexEntries2) - db BANK(PokedexEntries3) - db BANK(PokedexEntries4) + db BANK("Pokedex Entries 001-064") + db BANK("Pokedex Entries 065-128") + db BANK("Pokedex Entries 129-192") + db BANK("Pokedex Entries 193-251") ``` **Fix:** Use `dba` instead of `dw` in `PokedexDataPointerTable`, and modify the code that accesses it to match. |