diff options
| author | Remy Oukaour <remy.oukaour@gmail.com> | 2017-12-15 01:01:57 -0500 |
|---|---|---|
| committer | Remy Oukaour <remy.oukaour@gmail.com> | 2017-12-15 01:01:57 -0500 |
| commit | 2b6dd505c1674e0d99d649515a8efe868035db09 (patch) | |
| tree | 1e406bb8ffdc3bf0e946e740ccb5c59f7aceaf27 /docs | |
| parent | d334a331fabe25c4094c4c7e4cd9e270f51c1a30 (diff) | |
Document another bug
Remove an unused file
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/bugs_and_glitches.md | 22 |
1 files changed, 22 insertions, 0 deletions
diff --git a/docs/bugs_and_glitches.md b/docs/bugs_and_glitches.md index 31e61dfc0..fe0a973dc 100644 --- a/docs/bugs_and_glitches.md +++ b/docs/bugs_and_glitches.md @@ -27,6 +27,7 @@ - [Dragon Scale, not Dragon Fang, boosts Dragon-type moves](#dragon-scale-not-dragon-fang-boosts-dragon-type-moves) - [Daisy's massages don't always increase happiness](#daisys-massages-dont-always-increase-happiness) - [Magikarp in Lake of Rage are shorter, not longer](#magikarp-in-lake-of-rage-are-shorter-not-longer) +- [Magikarp lengths can be miscalculated](#magikarp-lengths-can-be-miscalculated) - [Battle transitions fail to account for the enemy's level](#battle-transitions-fail-to-account-for-the-enemys-level) - [Slot machine payout sound effects cut each other off](#slot-machine-payout-sound-effects-cut-each-other-off) - [Team Rocket battle music is not used for Executives or Scientists](#team-rocket-battle-music-is-not-used-for-executives-or-scientists) @@ -736,6 +737,27 @@ This is a bug with `LoadEnemyMon.CheckMagikarpArea` in [battle/core.asm](/battle **Fix:** Change both `jr z, .Happiness` to `jr nz, .Happiness`. +## Magikarp lengths can be miscalculated + +This is a bug with `CalcMagikarpLength.BCLessThanDE` in [event/magikarp.asm](/event/magikarp.asm): + +```asm +.BCLessThanDE: ; fbc9a +; Intention: Return bc < de. +; Reality: Return b < d. + ld a, b + cp d + ret c + ret nc ; whoops + ld a, c + cp e + ret +; fbca1 +``` + +**Fix:** Delete `ret nc`. + + ## Battle transitions fail to account for the enemy's level ([Video](https://www.youtube.com/watch?v=eij_1060SMc)) |