summaryrefslogtreecommitdiff
path: root/engine/battle/effect_commands.asm
diff options
context:
space:
mode:
authorRangi <remy.oukaour+rangi42@gmail.com>2019-01-05 20:29:45 -0500
committerRangi <remy.oukaour+rangi42@gmail.com>2019-01-05 20:30:46 -0500
commit5207615cdcc9ce8fadd4cb76cf0040cc5a407275 (patch)
tree2509ab46a2680056e35ee73a0c9200b1638253f6 /engine/battle/effect_commands.asm
parent3650232398d6d75a5bcdfc99c3c3bb73ddd54751 (diff)
Document a bugfix: 1/256 failure rate for 100% effect chance
Diffstat (limited to 'engine/battle/effect_commands.asm')
-rw-r--r--engine/battle/effect_commands.asm2
1 files changed, 2 insertions, 0 deletions
diff --git a/engine/battle/effect_commands.asm b/engine/battle/effect_commands.asm
index 76d6ee375..69171740b 100644
--- a/engine/battle/effect_commands.asm
+++ b/engine/battle/effect_commands.asm
@@ -1877,6 +1877,8 @@ BattleCommand_EffectChance:
ld hl, wEnemyMoveStruct + MOVE_CHANCE
.got_move_chance
+ ; BUG: 1/256 chance to fail even for a 100% effect chance,
+ ; since carry is not set if BattleRandom == [hl] == 255
call BattleRandom
cp [hl]
pop hl