diff options
author | Rangi <remy.oukaour+rangi42@gmail.com> | 2020-12-23 16:29:30 -0500 |
---|---|---|
committer | Rangi <remy.oukaour+rangi42@gmail.com> | 2020-12-23 16:29:30 -0500 |
commit | 99e66c25577e367d6c7ca75fea8b466b54c3317a (patch) | |
tree | 56183dddfd540a395086a7540060c374f9541723 /engine/events | |
parent | 1a054661ecac2d6075961e486213b6880c0afc4e (diff) |
Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
Diffstat (limited to 'engine/events')
-rw-r--r-- | engine/events/battle_tower/battle_tower.asm | 8 | ||||
-rw-r--r-- | engine/events/battle_tower/load_trainer.asm | 6 | ||||
-rw-r--r-- | engine/events/buena.asm | 8 | ||||
-rw-r--r-- | engine/events/bug_contest/caught_mon.asm | 4 | ||||
-rw-r--r-- | engine/events/bug_contest/display_stats.asm | 2 | ||||
-rw-r--r-- | engine/events/bug_contest/judging.asm | 6 | ||||
-rw-r--r-- | engine/events/haircut.asm | 2 | ||||
-rw-r--r-- | engine/events/halloffame.asm | 4 | ||||
-rw-r--r-- | engine/events/happiness_egg.asm | 4 | ||||
-rw-r--r-- | engine/events/kurt.asm | 30 | ||||
-rw-r--r-- | engine/events/lucky_number.asm | 2 | ||||
-rw-r--r-- | engine/events/misc_scripts.asm | 4 | ||||
-rw-r--r-- | engine/events/mom_phone.asm | 2 | ||||
-rw-r--r-- | engine/events/move_deleter.asm | 2 | ||||
-rw-r--r-- | engine/events/move_tutor.asm | 4 | ||||
-rw-r--r-- | engine/events/name_rater.asm | 2 | ||||
-rw-r--r-- | engine/events/npc_trade.asm | 34 | ||||
-rw-r--r-- | engine/events/odd_egg.asm | 34 | ||||
-rw-r--r-- | engine/events/pokecenter_pc.asm | 32 | ||||
-rw-r--r-- | engine/events/specials.asm | 6 |
20 files changed, 98 insertions, 98 deletions
diff --git a/engine/events/battle_tower/battle_tower.asm b/engine/events/battle_tower/battle_tower.asm index 50daff895..8eabc71ca 100644 --- a/engine/events/battle_tower/battle_tower.asm +++ b/engine/events/battle_tower/battle_tower.asm @@ -269,7 +269,7 @@ ReadBTTrainerParty: jr nc, .skip_mon_1 ld a, [wBT_OTTempMon1] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetPokemonName ld l, e ld h, d @@ -283,7 +283,7 @@ ReadBTTrainerParty: farcall CheckStringForErrors jr nc, .skip_mon_2 ld a, [wBT_OTTempMon2] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetPokemonName ld l, e ld h, d @@ -297,7 +297,7 @@ ReadBTTrainerParty: farcall CheckStringForErrors jr nc, .skip_mon_3 ld a, [wBT_OTTempMon3] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetPokemonName ld l, e ld h, d @@ -1289,7 +1289,7 @@ endr ld a, EGG_TICKET ld [wCurItem], a ld a, 1 - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a ld a, -1 ld [wCurItemQuantity], a ld hl, wNumItems diff --git a/engine/events/battle_tower/load_trainer.asm b/engine/events/battle_tower/load_trainer.asm index 0368a1268..bcf0583f9 100644 --- a/engine/events/battle_tower/load_trainer.asm +++ b/engine/events/battle_tower/load_trainer.asm @@ -168,13 +168,13 @@ LoadRandomBattleTowerMon: ld bc, NICKNAMED_MON_STRUCT_LENGTH call CopyBytes - ld a, [wNamedObjectIndexBuffer] + ld a, [wNamedObjectIndex] push af push de ld hl, -NICKNAMED_MON_STRUCT_LENGTH add hl, de ld a, [hl] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a ld bc, PARTYMON_STRUCT_LENGTH add hl, bc push hl @@ -187,7 +187,7 @@ LoadRandomBattleTowerMon: pop de pop af - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a pop bc dec c jp nz, .loop diff --git a/engine/events/buena.asm b/engine/events/buena.asm index dca125ece..62cb8bb4a 100644 --- a/engine/events/buena.asm +++ b/engine/events/buena.asm @@ -87,7 +87,7 @@ BuenaPrize: ld [wMenuSelectionQuantity], a call Buena_GetPrize ld a, [hl] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetItemName ld hl, .BuenaIsThatRightText call BuenaPrintText @@ -107,7 +107,7 @@ BuenaPrize: push hl ld [wCurItem], a ld a, $1 - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a ld hl, wNumItems call ReceiveItem pop hl @@ -224,7 +224,7 @@ Buena_PrizeMenu: ld hl, .MenuHeader call CopyMenuHeader ld a, [wMenuSelection] - ld [wMenuCursorBuffer], a + ld [wMenuCursorPosition], a xor a ld [wWhichIndexSet], a ldh [hBGMapMode], a @@ -276,7 +276,7 @@ endr call Buena_GetPrize ld a, [hl] push de - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetItemName pop hl call PlaceString diff --git a/engine/events/bug_contest/caught_mon.asm b/engine/events/bug_contest/caught_mon.asm index b2cc044aa..533eae2b1 100644 --- a/engine/events/bug_contest/caught_mon.asm +++ b/engine/events/bug_contest/caught_mon.asm @@ -2,7 +2,7 @@ BugContest_SetCaughtContestMon: ld a, [wContestMon] and a jr z, .firstcatch - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a farcall DisplayAlreadyCaughtText farcall DisplayCaughtContestMonStats lb bc, 14, 7 @@ -12,7 +12,7 @@ BugContest_SetCaughtContestMon: .firstcatch call .generatestats ld a, [wTempEnemyMonSpecies] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetPokemonName ld hl, .ContestCaughtMonText call PrintText diff --git a/engine/events/bug_contest/display_stats.asm b/engine/events/bug_contest/display_stats.asm index e35852479..b18aa1cbe 100644 --- a/engine/events/bug_contest/display_stats.asm +++ b/engine/events/bug_contest/display_stats.asm @@ -36,7 +36,7 @@ DisplayCaughtContestMonStats: call PlaceString ld a, [wContestMon] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetPokemonName ld de, wStringBuffer1 hlcoord 1, 2 diff --git a/engine/events/bug_contest/judging.asm b/engine/events/bug_contest/judging.asm index abb9d60da..3b4e9f1c6 100644 --- a/engine/events/bug_contest/judging.asm +++ b/engine/events/bug_contest/judging.asm @@ -5,21 +5,21 @@ _BugContestJudging: ld a, [wBugContestThirdPlaceWinnerID] call LoadContestantName ld a, [wBugContestThirdPlaceMon] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetPokemonName ld hl, ContestJudging_ThirdPlaceText call PrintText ld a, [wBugContestSecondPlaceWinnerID] call LoadContestantName ld a, [wBugContestSecondPlaceMon] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetPokemonName ld hl, ContestJudging_SecondPlaceText call PrintText ld a, [wBugContestFirstPlaceWinnerID] call LoadContestantName ld a, [wBugContestFirstPlaceMon] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetPokemonName ld hl, ContestJudging_FirstPlaceText call PrintText diff --git a/engine/events/haircut.asm b/engine/events/haircut.asm index ea83826a5..932e196b8 100644 --- a/engine/events/haircut.asm +++ b/engine/events/haircut.asm @@ -3,7 +3,7 @@ BillsGrandfather: jr c, .cancel ld a, [wCurPartySpecies] ld [wScriptVar], a - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetPokemonName jp CopyPokemonName_Buffer1_Buffer3 diff --git a/engine/events/halloffame.asm b/engine/events/halloffame.asm index d49c7aa1b..45eb7ade5 100644 --- a/engine/events/halloffame.asm +++ b/engine/events/halloffame.asm @@ -462,7 +462,7 @@ DisplayHOFMon: call Textbox ld a, [wTempMonSpecies] ld [wCurPartySpecies], a - ld [wDeciramBuffer], a + ld [wTextDecimalByte], a ld hl, wTempMonDVs predef GetUnownLetter xor a @@ -477,7 +477,7 @@ DisplayHOFMon: ld [hli], a ld [hl], "<DOT>" hlcoord 3, 13 - ld de, wDeciramBuffer + ld de, wTextDecimalByte lb bc, PRINTNUM_LEADINGZEROS | 1, 3 call PrintNum call GetBasePokemonName diff --git a/engine/events/happiness_egg.asm b/engine/events/happiness_egg.asm index bb2e949cb..ac3e165b9 100644 --- a/engine/events/happiness_egg.asm +++ b/engine/events/happiness_egg.asm @@ -11,7 +11,7 @@ GetFirstPokemonHappiness: jr .loop .done - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a ld a, [hl] ld [wScriptVar], a call GetPokemonName @@ -19,7 +19,7 @@ GetFirstPokemonHappiness: CheckFirstMonIsEgg: ld a, [wPartySpecies] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a cp EGG ld a, TRUE jr z, .egg diff --git a/engine/events/kurt.asm b/engine/events/kurt.asm index 03baaed94..9ce7f2e52 100644 --- a/engine/events/kurt.asm +++ b/engine/events/kurt.asm @@ -41,7 +41,7 @@ SelectApricornForKurt: call Kurt_SelectQuantity pop bc jr nc, .loop - ld a, [wItemQuantityChangeBuffer] + ld a, [wItemQuantityChange] ld [wKurtApricornQuantity], a call Kurt_GiveUpSelectedQuantityOfSelectedApricorn @@ -55,7 +55,7 @@ Kurt_SelectApricorn: ld hl, .MenuHeader call CopyMenuHeader ld a, [wMenuSelection] - ld [wMenuCursorBuffer], a + ld [wMenuCursorPosition], a xor a ldh [hBGMapMode], a call InitScrollingMenu @@ -104,7 +104,7 @@ Kurt_SelectApricorn: ld [wCurItem], a call Kurt_GetQuantityOfApricorn ret z - ld a, [wItemQuantityChangeBuffer] + ld a, [wItemQuantityChange] ld [wMenuSelectionQuantity], a farcall PlaceMenuItemQuantity ret @@ -114,10 +114,10 @@ Kurt_SelectQuantity: ld [wMenuSelection], a call Kurt_GetQuantityOfApricorn jr z, .done - ld a, [wItemQuantityChangeBuffer] - ld [wItemQuantityBuffer], a + ld a, [wItemQuantityChange] + ld [wItemQuantity], a ld a, $1 - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a ld hl, .MenuHeader call LoadMenuHeader .loop @@ -137,8 +137,8 @@ Kurt_SelectQuantity: ld a, b cp -1 jr z, .done - ld a, [wItemQuantityChangeBuffer] - ld [wItemQuantityChangeBuffer], a ; What is the point of this operation? + ld a, [wItemQuantityChange] + ld [wItemQuantityChange], a ; What is the point of this operation? scf .done @@ -167,7 +167,7 @@ PlaceApricornQuantity: add hl, de ld [hl], "×" inc hl - ld de, wItemQuantityChangeBuffer + ld de, wItemQuantityChange lb bc, PRINTNUM_LEADINGZEROS | 1, 2 jp PrintNum @@ -198,7 +198,7 @@ Kurt_GetQuantityOfApricorn: .done2 ld a, b - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a and a pop bc ret @@ -309,7 +309,7 @@ Kurt_GiveUpSelectedQuantityOfSelectedApricorn: ld [wCurItemQuantity], a call Kurt_GetRidOfItem pop hl - ld a, [wItemQuantityChangeBuffer] + ld a, [wItemQuantityChange] and a jr z, .done push hl @@ -332,7 +332,7 @@ Kurt_GiveUpSelectedQuantityOfSelectedApricorn: jr .loop4 .done - ld a, [wItemQuantityChangeBuffer] + ld a, [wItemQuantityChange] and a pop bc pop de @@ -369,7 +369,7 @@ Kurt_GetRidOfItem: jr z, .done cp c jr nz, .done - ld a, [wItemQuantityChangeBuffer] + ld a, [wItemQuantityChange] ld c, a ld a, [hl] sub c @@ -382,13 +382,13 @@ Kurt_GetRidOfItem: push bc ld hl, wNumItems ld a, b - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a call TossItem pop bc ld a, c sub b .done - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a pop bc ret diff --git a/engine/events/lucky_number.asm b/engine/events/lucky_number.asm index 66ec205c1..1c2329b37 100644 --- a/engine/events/lucky_number.asm +++ b/engine/events/lucky_number.asm @@ -109,7 +109,7 @@ CheckForLuckyNumberWinners: and a push af ld a, [wCurPartySpecies] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetPokemonName ld hl, .LuckyNumberMatchPartyText pop af diff --git a/engine/events/misc_scripts.asm b/engine/events/misc_scripts.asm index e90063327..24e4088e3 100644 --- a/engine/events/misc_scripts.asm +++ b/engine/events/misc_scripts.asm @@ -39,14 +39,14 @@ FindItemInBallScript:: xor a ld [wScriptVar], a ld a, [wItemBallItemID] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetItemName ld hl, wStringBuffer3 call CopyName2 ld a, [wItemBallItemID] ld [wCurItem], a ld a, [wItemBallQuantity] - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a ld hl, wNumItems call ReceiveItem ret nc diff --git a/engine/events/mom_phone.asm b/engine/events/mom_phone.asm index 3ff5f2b3e..9fde8afbd 100644 --- a/engine/events/mom_phone.asm +++ b/engine/events/mom_phone.asm @@ -146,7 +146,7 @@ Mom_GiveItemOrDoll: ld a, [hl] ld [wCurItem], a ld a, 1 - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a ld hl, wNumPCItems call ReceiveItem ret diff --git a/engine/events/move_deleter.asm b/engine/events/move_deleter.asm index f9f83fab6..2d6841e47 100644 --- a/engine/events/move_deleter.asm +++ b/engine/events/move_deleter.asm @@ -28,7 +28,7 @@ MoveDeletion: ld a, [wMenuCursorY] push af ld a, [wCurSpecies] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetMoveName ld hl, .AskDeleteMoveText call PrintText diff --git a/engine/events/move_tutor.asm b/engine/events/move_tutor.asm index 11d9d3fb0..07c8b8bd4 100644 --- a/engine/events/move_tutor.asm +++ b/engine/events/move_tutor.asm @@ -6,9 +6,9 @@ MoveTutor: ld b, SCGB_PACKPALS call GetSGBLayout xor a - ld [wItemAttributeParamBuffer], a + ld [wItemAttributeValue], a call .GetMoveTutorMove - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a ld [wPutativeTMHMMove], a call GetMoveName call CopyName1 diff --git a/engine/events/name_rater.asm b/engine/events/name_rater.asm index e2b24c4c7..d3a1dc58f 100644 --- a/engine/events/name_rater.asm +++ b/engine/events/name_rater.asm @@ -29,7 +29,7 @@ _NameRater: xor a ; PARTYMON ld [wMonType], a ld a, [wCurPartySpecies] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a ld [wCurSpecies], a call GetBaseData ld b, NAME_MON diff --git a/engine/events/npc_trade.asm b/engine/events/npc_trade.asm index 6b32aff56..36cf380ac 100644 --- a/engine/events/npc_trade.asm +++ b/engine/events/npc_trade.asm @@ -21,7 +21,7 @@ NPCTrade:: jr c, .done ld e, NPCTRADE_GIVEMON - call GetTradeAttribute + call GetTradeAttr ld a, [wCurPartySpecies] cp [hl] ld a, TRADE_DIALOG_WRONG @@ -72,7 +72,7 @@ CheckTradeGender: ld [wMonType], a ld e, NPCTRADE_GENDER - call GetTradeAttribute + call GetTradeAttr ld a, [hl] and a ; TRADE_GENDER_EITHER jr z, .matching @@ -106,19 +106,19 @@ TradeFlagAction: Trade_GetDialog: ld e, NPCTRADE_DIALOG - call GetTradeAttribute + call GetTradeAttr ld a, [hl] ld [wTradeDialog], a ret DoNPCTrade: ld e, NPCTRADE_GIVEMON - call GetTradeAttribute + call GetTradeAttr ld a, [hl] ld [wPlayerTrademonSpecies], a ld e, NPCTRADE_GETMON - call GetTradeAttribute + call GetTradeAttr ld a, [hl] ld [wOTTrademonSpecies], a @@ -164,7 +164,7 @@ DoNPCTrade: ld [wPlayerTrademonCaughtData], a ld e, NPCTRADE_DIALOG - call GetTradeAttribute + call GetTradeAttr ld a, [hl] cp TRADE_DIALOGSET_GIRL ld a, CAUGHT_BY_GIRL @@ -187,7 +187,7 @@ DoNPCTrade: predef TryAddMonToParty ld e, NPCTRADE_DIALOG - call GetTradeAttribute + call GetTradeAttr ld a, [hl] cp TRADE_DIALOGSET_GIRL ld b, CAUGHT_BY_UNKNOWN @@ -197,7 +197,7 @@ DoNPCTrade: farcall SetGiftPartyMonCaughtData ld e, NPCTRADE_NICK - call GetTradeAttribute + call GetTradeAttr ld de, wOTTrademonNickname call CopyTradeName @@ -208,7 +208,7 @@ DoNPCTrade: call CopyTradeName ld e, NPCTRADE_OT_NAME - call GetTradeAttribute + call GetTradeAttr push hl ld de, wOTTrademonOTName call CopyTradeName @@ -223,7 +223,7 @@ DoNPCTrade: call CopyTradeName ld e, NPCTRADE_DVS - call GetTradeAttribute + call GetTradeAttr ld de, wOTTrademonDVs call Trade_CopyTwoBytes @@ -234,7 +234,7 @@ DoNPCTrade: call Trade_CopyTwoBytes ld e, NPCTRADE_OT_ID - call GetTradeAttribute + call GetTradeAttr ld de, wOTTrademonID + 1 call Trade_CopyTwoBytesReverseEndian @@ -245,7 +245,7 @@ DoNPCTrade: call Trade_CopyTwoBytes ld e, NPCTRADE_ITEM - call GetTradeAttribute + call GetTradeAttr push hl ld hl, wPartyMon1Item ld bc, PARTYMON_STRUCT_LENGTH @@ -272,7 +272,7 @@ DoNPCTrade: pop af ret -GetTradeAttribute: +GetTradeAttr: ld d, 0 push de ld a, [wJumptableIndex] @@ -302,7 +302,7 @@ Trade_GetAttributeOfLastPartymon: GetTradeMonName: push de - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetBasePokemonName ld hl, wStringBuffer1 pop de @@ -345,7 +345,7 @@ Trade_CopyTwoBytesReverseEndian: GetTradeMonNames: ld e, NPCTRADE_GETMON - call GetTradeAttribute + call GetTradeAttr ld a, [hl] call GetTradeMonName @@ -353,7 +353,7 @@ GetTradeMonNames: call CopyTradeName ld e, NPCTRADE_GIVEMON - call GetTradeAttribute + call GetTradeAttr ld a, [hl] call GetTradeMonName @@ -369,7 +369,7 @@ GetTradeMonNames: dec hl push hl ld e, NPCTRADE_GENDER - call GetTradeAttribute + call GetTradeAttr ld a, [hl] pop hl and a ; TRADE_GENDER_EITHER diff --git a/engine/events/odd_egg.asm b/engine/events/odd_egg.asm index 406d5242f..9216e0e73 100644 --- a/engine/events/odd_egg.asm +++ b/engine/events/odd_egg.asm @@ -51,26 +51,26 @@ _GiveOddEgg: ld a, EGG_TICKET ld [wCurItem], a ld a, 1 - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a ld a, -1 ld [wCurItemQuantity], a ld hl, wNumItems call TossItem - ; load species in wcd2a + ; load species in wMobileMonSpecies ld a, EGG - ld [wMobileMonSpeciesBuffer], a + ld [wMobileMonSpecies], a - ; load pointer to (wMobileMonSpeciesBuffer - 1) in wMobileMonSpeciesPointerBuffer - ld a, LOW(wMobileMonSpeciesBuffer - 1) - ld [wMobileMonSpeciesPointerBuffer], a - ld a, HIGH(wMobileMonSpeciesBuffer - 1) - ld [wMobileMonSpeciesPointerBuffer + 1], a - ; load pointer to wOddEgg in wMobileMonStructurePointerBuffer + ; load pointer to (wMobileMonSpecies - 1) in wMobileMonSpeciesPointer + ld a, LOW(wMobileMonSpecies - 1) + ld [wMobileMonSpeciesPointer], a + ld a, HIGH(wMobileMonSpecies - 1) + ld [wMobileMonSpeciesPointer + 1], a + ; load pointer to wOddEgg in wMobileMonStructPointer ld a, LOW(wOddEgg) - ld [wMobileMonStructurePointerBuffer], a + ld [wMobileMonStructPointer], a ld a, HIGH(wOddEgg) - ld [wMobileMonStructurePointerBuffer + 1], a + ld [wMobileMonStructPointer + 1], a ; load Odd Egg Name in wTempOddEggNickname ld hl, .Odd @@ -78,16 +78,16 @@ _GiveOddEgg: ld bc, MON_NAME_LENGTH call CopyBytes - ; load pointer to wTempOddEggNickname in wMobileMonOTNamePointerBuffer + ; load pointer to wTempOddEggNickname in wMobileMonOTNamePointer ld a, LOW(wTempOddEggNickname) - ld [wMobileMonOTNamePointerBuffer], a + ld [wMobileMonOTNamePointer], a ld a, HIGH(wTempOddEggNickname) - ld [wMobileMonOTNamePointerBuffer + 1], a - ; load pointer to wOddEggName in wMobileMonNicknamePointerBuffer + ld [wMobileMonOTNamePointer + 1], a + ; load pointer to wOddEggName in wMobileMonNicknamePointer ld a, LOW(wOddEggName) - ld [wMobileMonNicknamePointerBuffer], a + ld [wMobileMonNicknamePointer], a ld a, HIGH(wOddEggName) - ld [wMobileMonNicknamePointerBuffer + 1], a + ld [wMobileMonNicknamePointer + 1], a farcall AddMobileMonToParty ret diff --git a/engine/events/pokecenter_pc.asm b/engine/events/pokecenter_pc.asm index 74645a92c..9a8a3334b 100644 --- a/engine/events/pokecenter_pc.asm +++ b/engine/events/pokecenter_pc.asm @@ -342,13 +342,13 @@ PlayerWithdrawItemMenu: .Submenu: ; check if the item has a quantity farcall _CheckTossableItem - ld a, [wItemAttributeParamBuffer] + ld a, [wItemAttributeValue] and a jr z, .askquantity ; items without quantity are always ×1 ld a, 1 - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a jr .withdraw .askquantity @@ -360,15 +360,15 @@ PlayerWithdrawItemMenu: jr c, .done .withdraw - ld a, [wItemQuantityChangeBuffer] - ld [wPCItemQuantityChangeBuffer], a + ld a, [wItemQuantityChange] + ld [wPCItemQuantityChange], a ld a, [wCurItemQuantity] ld [wPCItemQuantity], a ld hl, wNumItems call ReceiveItem jr nc, .PackFull - ld a, [wPCItemQuantityChangeBuffer] - ld [wItemQuantityChangeBuffer], a + ld a, [wPCItemQuantityChange] + ld [wItemQuantityChange], a ld a, [wPCItemQuantity] ld [wCurItemQuantity], a ld hl, wNumPCItems @@ -469,7 +469,7 @@ PlayerDepositItemMenu: ld a, FALSE ld [wSpriteUpdatesEnabled], a farcall CheckItemMenu - ld a, [wItemAttributeParamBuffer] + ld a, [wItemAttributeValue] ld hl, .dw rst JumpTable pop af @@ -490,7 +490,7 @@ PlayerDepositItemMenu: ret .tossable - ld a, [wPCItemQuantityChangeBuffer] + ld a, [wPCItemQuantityChange] push af ld a, [wPCItemQuantity] push af @@ -498,16 +498,16 @@ PlayerDepositItemMenu: pop af ld [wPCItemQuantity], a pop af - ld [wPCItemQuantityChangeBuffer], a + ld [wPCItemQuantityChange], a ret .DepositItem: farcall _CheckTossableItem - ld a, [wItemAttributeParamBuffer] + ld a, [wItemAttributeValue] and a jr z, .AskQuantity ld a, 1 - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a jr .ContinueDeposit .AskQuantity: @@ -521,15 +521,15 @@ PlayerDepositItemMenu: jr c, .DeclinedToDeposit .ContinueDeposit: - ld a, [wItemQuantityChangeBuffer] - ld [wPCItemQuantityChangeBuffer], a + ld a, [wItemQuantityChange] + ld [wPCItemQuantityChange], a ld a, [wCurItemQuantity] ld [wPCItemQuantity], a ld hl, wNumPCItems call ReceiveItem jr nc, .NoRoomInPC - ld a, [wPCItemQuantityChangeBuffer] - ld [wItemQuantityChangeBuffer], a + ld a, [wPCItemQuantityChange] + ld [wItemQuantityChange], a ld a, [wPCItemQuantity] ld [wCurItemQuantity], a ld hl, wNumItems @@ -580,7 +580,7 @@ PCItemsJoypad: ld c, 18 call Textbox ld a, [wPCItemsCursor] - ld [wMenuCursorBuffer], a + ld [wMenuCursorPosition], a ld a, [wPCItemsScrollPosition] ld [wMenuScrollPosition], a call ScrollingMenu diff --git a/engine/events/specials.asm b/engine/events/specials.asm index 1d6648973..09014cc6b 100644 --- a/engine/events/specials.asm +++ b/engine/events/specials.asm @@ -34,7 +34,7 @@ GameCornerPrizeMonCheckDex: call SetSeenAndCaughtMon call FadeToMenu ld a, [wScriptVar] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a farcall NewPokedexEntry call ExitAllMenus ret @@ -144,7 +144,7 @@ GetMysteryGiftItem: ld a, [sMysteryGiftItem] ld [wCurItem], a ld a, 1 - ld [wItemQuantityChangeBuffer], a + ld [wItemQuantityChange], a ld hl, wNumItems call ReceiveItem jr nc, .no_room @@ -152,7 +152,7 @@ GetMysteryGiftItem: ld [sMysteryGiftItem], a call CloseSRAM ld a, [wCurItem] - ld [wNamedObjectIndexBuffer], a + ld [wNamedObjectIndex], a call GetItemName ld hl, .ReceiveItemText call PrintText |