diff options
| author | mid-kid <esteve.varela@gmail.com> | 2018-07-26 23:26:14 +0200 |
|---|---|---|
| committer | mid-kid <esteve.varela@gmail.com> | 2018-07-26 23:34:05 +0200 |
| commit | a91b59ab5dd2468e3f48079d45f90a9625a29fe3 (patch) | |
| tree | c2bf44977a2149040b08c1ddee972b804a12e90c /engine | |
| parent | e43c89bc80bb1bb7ff2fc93bb5288f2c0211ea0b (diff) | |
Remove a documented bug that's not really a bug
I mean, technically, being able to read beyond a data table's size is
bad practice, but there's so many cases of this that it's not worth
mentioning.
For most of these cases, at least, it's safe to assume the index won't
ever get high enough to surpass such a table's length, because it's
either hardcoded or decided by the game without the use of
uncontrollable data. As such, they don't expose any actual bugs.
Diffstat (limited to 'engine')
| -rw-r--r-- | engine/events/bug_contest/contest_2.asm | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/engine/events/bug_contest/contest_2.asm b/engine/events/bug_contest/contest_2.asm index 9cf70a03e..ddfad8644 100644 --- a/engine/events/bug_contest/contest_2.asm +++ b/engine/events/bug_contest/contest_2.asm @@ -58,9 +58,6 @@ SelectRandomBugContestContestants: CheckBugContestContestantFlag: ; Checks the flag of the Bug Catching Contestant whose index is loaded in a. -; Bug: If a >= NUM_BUG_CONTESTANTS when this is called, -; it will read beyond the table. - ld hl, BugCatchingContestantEventFlagTable ld e, a ld d, 0 |