summaryrefslogtreecommitdiff
path: root/macros/scripts
diff options
context:
space:
mode:
authoryenatch <yenatch@gmail.com>2017-12-28 22:17:13 -0500
committerGitHub <noreply@github.com>2017-12-28 22:17:13 -0500
commitb97a1acf3d676ca1c776e37ff4cfa48164ffc92b (patch)
tree59b5db70690a9f9041e4964adae1722b4d178a1b /macros/scripts
parent82a05a1752b476caab8951fe03f539dcc1a63669 (diff)
parentb9a68fec2589eb6969be63e6ed1eb3fca312c307 (diff)
Merge pull request #445 from roukaour/master
Rename Pokémon animation files; consistent (x, y) coords; document design flaws
Diffstat (limited to 'macros/scripts')
-rw-r--r--macros/scripts/events.asm4
-rw-r--r--macros/scripts/maps.asm28
2 files changed, 16 insertions, 16 deletions
diff --git a/macros/scripts/events.asm b/macros/scripts/events.asm
index a494a33af..694a7cd12 100644
--- a/macros/scripts/events.asm
+++ b/macros/scripts/events.asm
@@ -538,13 +538,13 @@ jumptextfaceplayer: MACRO
dw \1 ; text_pointer
ENDM
-; IF _CRYSTAL
+; if _CRYSTAL
enum farjumptext_command ; $52
farjumptext: MACRO
db farjumptext_command
dba \1
ENDM
-; ENDC
+; endc
enum jumptext_command ; $53
jumptext: MACRO
diff --git a/macros/scripts/maps.asm b/macros/scripts/maps.asm
index 6ab4a3f61..e9703531d 100644
--- a/macros/scripts/maps.asm
+++ b/macros/scripts/maps.asm
@@ -10,39 +10,39 @@ scene_script: MACRO
ENDM
warp_def: MACRO
-;\1: y: top to bottom, starts at 0
-;\2: x: left to right, starts at 0
+;\1: x: left to right, starts at 0
+;\2: y: top to bottom, starts at 0
;\3: warp destination: starts at 1
;\4: map id: from constants/map_constants.asm
- db \1, \2, \3
+ db \2, \1, \3
map \4
ENDM
coord_event: MACRO
-;\1: scene id: controlled by setscene/setmapscene
+;\1: x: left to right, starts at 0
;\2: y: top to bottom, starts at 0
-;\3: x: left to right, starts at 0
+;\3: scene id: controlled by setscene/setmapscene
;\4: script pointer
- db \1, \2, \3, $0
+ db \3, \2, \1, $0
dw \4
db $0, $0
ENDM
bg_event: MACRO
-;\1: y: top to bottom, starts at 0
-;\2: x: left to right, starts at 0
+;\1: x: left to right, starts at 0
+;\2: y: top to bottom, starts at 0
;\3: function: a BGEVENT_* constant
;\4: script pointer
- db \1, \2, \3
+ db \2, \1, \3
dw \4
ENDM
object_event: MACRO
-;\1: sprite: a SPRITE_* constant
+;\1: x: left to right, starts at 0
;\2: y: top to bottom, starts at 0
-;\3: x: left to right, starts at 0
+;\3: sprite: a SPRITE_* constant
;\4: movement function: a SPRITEMOVEDATA_* constant
-;\5, \6: movement radius: y, x
+;\5, \6: movement radius: x, y
;\7, \8: hour limits: h1, h2 (0-23)
; * if h1 < h2, the object_event will only appear from h1 to h2
; * if h1 > h2, the object_event will not appear from h2 to h1
@@ -54,8 +54,8 @@ object_event: MACRO
;\11: sight range: applies to OBJECTTYPE_TRAINER
;\12: script pointer
;\13: event flag: an EVENT_* constant, or -1 to always appear
- db \1, \2 + 4, \3 + 4, \4
- dn \5, \6
+ db \3, \2 + 4, \1 + 4, \4
+ dn \6, \5
db \7, \8
shift
dn \8, \9