summaryrefslogtreecommitdiff
path: root/engine
diff options
context:
space:
mode:
Diffstat (limited to 'engine')
-rw-r--r--engine/battle/core.asm14
-rw-r--r--engine/battle/move_effects/beat_up.asm2
-rw-r--r--engine/battle/read_trainer_party.asm2
-rw-r--r--engine/events/battle_tower/battle_tower.asm2
-rw-r--r--engine/events/bug_contest/display_stats.asm2
-rw-r--r--engine/events/daycare.asm20
-rw-r--r--engine/events/haircut.asm2
-rw-r--r--engine/events/magikarp.asm2
-rw-r--r--engine/events/move_tutor.asm2
-rw-r--r--engine/events/name_rater.asm12
-rw-r--r--engine/events/npc_trade.asm6
-rw-r--r--engine/events/odd_egg.asm10
-rw-r--r--engine/events/overworld.asm24
-rw-r--r--engine/events/poisonstep.asm2
-rw-r--r--engine/events/poke_seer.asm6
-rw-r--r--engine/events/shuckle.asm8
-rw-r--r--engine/events/sweet_scent.asm2
-rw-r--r--engine/items/item_effects.asm2
-rw-r--r--engine/items/pack.asm2
-rw-r--r--engine/items/tmhm.asm2
-rw-r--r--engine/link/init_list.asm4
-rw-r--r--engine/link/link.asm20
-rw-r--r--engine/movie/trade_animation.asm6
-rw-r--r--engine/pokemon/bills_pc.asm16
-rw-r--r--engine/pokemon/breeding.asm6
-rw-r--r--engine/pokemon/caught_data.asm2
-rw-r--r--engine/pokemon/correct_party_errors.asm2
-rw-r--r--engine/pokemon/european_mail.asm2
-rw-r--r--engine/pokemon/evolve.asm2
-rw-r--r--engine/pokemon/learn.asm2
-rw-r--r--engine/pokemon/mail.asm2
-rw-r--r--engine/pokemon/mon_menu.asm8
-rw-r--r--engine/pokemon/mon_stats.asm2
-rw-r--r--engine/pokemon/move_mon.asm50
-rw-r--r--engine/pokemon/move_mon_wo_mail.asm8
-rw-r--r--engine/pokemon/party_menu.asm4
-rw-r--r--engine/pokemon/search.asm6
-rw-r--r--engine/pokemon/stats_screen.asm14
-rw-r--r--engine/pokemon/switchpartymons.asm4
-rw-r--r--engine/printer/print_party.asm2
40 files changed, 143 insertions, 143 deletions
diff --git a/engine/battle/core.asm b/engine/battle/core.asm
index aa197bea2..654559b89 100644
--- a/engine/battle/core.asm
+++ b/engine/battle/core.asm
@@ -3885,7 +3885,7 @@ InitBattleMon:
ld hl, wPartyMonNicknames
ld a, [wCurBattleMon]
call SkipNames
- ld de, wBattleMonNick
+ ld de, wBattleMonNickname
ld bc, MON_NAME_LENGTH
call CopyBytes
ld hl, wBattleMonAttack
@@ -3965,7 +3965,7 @@ InitEnemyMon:
ld hl, wOTPartyMonNicknames
ld a, [wCurPartyMon]
call SkipNames
- ld de, wEnemyMonNick
+ ld de, wEnemyMonNickname
ld bc, MON_NAME_LENGTH
call CopyBytes
ld hl, wEnemyMonAttack
@@ -4642,7 +4642,7 @@ CheckDanger:
ret
PrintPlayerHUD:
- ld de, wBattleMonNick
+ ld de, wBattleMonNickname
hlcoord 10, 7
call Battle_DummyFunction
call PlaceString
@@ -4728,7 +4728,7 @@ DrawEnemyHUD:
ld [wCurSpecies], a
ld [wCurPartySpecies], a
call GetBaseData
- ld de, wEnemyMonNick
+ ld de, wEnemyMonNickname
hlcoord 1, 0
call Battle_DummyFunction
call PlaceString
@@ -6394,7 +6394,7 @@ LoadEnemyMon:
; Update enemy nick
ld hl, wStringBuffer1
- ld de, wEnemyMonNick
+ ld de, wEnemyMonNickname
ld bc, MON_NAME_LENGTH
call CopyBytes
@@ -7112,7 +7112,7 @@ GiveExperiencePoints:
ld [wStringBuffer2], a
ld a, [wCurPartyMon]
ld hl, wPartyMonNicknames
- call GetNick
+ call GetNickname
ld hl, Text_MonGainedExpPoint
call BattleTextbox
ld a, [wStringBuffer2 + 1]
@@ -7523,7 +7523,7 @@ AnimateExpBar:
ld c, $40
call .LoopBarAnimation
call PrintPlayerHUD
- ld hl, wBattleMonNick
+ ld hl, wBattleMonNickname
ld de, wStringBuffer1
ld bc, MON_NAME_LENGTH
call CopyBytes
diff --git a/engine/battle/move_effects/beat_up.asm b/engine/battle/move_effects/beat_up.asm
index a52ecabed..2bd6cb458 100644
--- a/engine/battle/move_effects/beat_up.asm
+++ b/engine/battle/move_effects/beat_up.asm
@@ -28,7 +28,7 @@ BattleCommand_BeatUp:
.got_mon
ld a, [wCurBeatUpPartyMon]
ld hl, wPartyMonNicknames
- call GetNick
+ call GetNickname
ld a, MON_HP
call GetBeatupMonLocation
ld a, [hli]
diff --git a/engine/battle/read_trainer_party.asm b/engine/battle/read_trainer_party.asm
index cf7de20c6..238c316f6 100644
--- a/engine/battle/read_trainer_party.asm
+++ b/engine/battle/read_trainer_party.asm
@@ -14,7 +14,7 @@ ReadTrainerParty:
ld [hl], a
ld hl, wOTPartyMons
- ld bc, wOTPartyMonsEnd - wOTPartyMons
+ ld bc, PARTYMON_STRUCT_LENGTH * PARTY_LENGTH
xor a
call ByteFill
diff --git a/engine/events/battle_tower/battle_tower.asm b/engine/events/battle_tower/battle_tower.asm
index 5d1ca4844..6b58203ca 100644
--- a/engine/events/battle_tower/battle_tower.asm
+++ b/engine/events/battle_tower/battle_tower.asm
@@ -1258,7 +1258,7 @@ BattleTowerAction_EggTicket: ; BattleTowerAction $0e
cp EGG
jr nz, .not_egg
push hl
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld de, NAME_LENGTH_JAPANESE
ld a, b
and a
diff --git a/engine/events/bug_contest/display_stats.asm b/engine/events/bug_contest/display_stats.asm
index b18aa1cbe..220eeb4e4 100644
--- a/engine/events/bug_contest/display_stats.asm
+++ b/engine/events/bug_contest/display_stats.asm
@@ -48,7 +48,7 @@ DisplayCaughtContestMonStats:
ld [wTempMonLevel], a
call PrintLevel
- ld de, wEnemyMonNick
+ ld de, wEnemyMonNickname
hlcoord 1, 8
call PlaceString
diff --git a/engine/events/daycare.asm b/engine/events/daycare.asm
index d5930575e..b44264692 100644
--- a/engine/events/daycare.asm
+++ b/engine/events/daycare.asm
@@ -40,7 +40,7 @@ DayCareMan:
.AskWithdrawMon:
farcall GetBreedMon1LevelGrowth
- ld hl, wBreedMon1Nick
+ ld hl, wBreedMon1Nickname
call GetPriceToRetrieveBreedmon
call DayCare_AskWithdrawBreedMon
jr c, .print_text
@@ -78,7 +78,7 @@ DayCareLady:
.AskWithdrawMon:
farcall GetBreedMon2LevelGrowth
- ld hl, wBreedMon2Nick
+ ld hl, wBreedMon2Nickname
call GetPriceToRetrieveBreedmon
call DayCare_AskWithdrawBreedMon
jr c, .print_text
@@ -137,7 +137,7 @@ DayCareAskDepositPokemon:
jr c, .HoldingMail
ld hl, wPartyMonNicknames
ld a, [wCurPartyMon]
- call GetNick
+ call GetNickname
and a
ret
@@ -467,13 +467,13 @@ DayCare_GiveEgg:
ld hl, wPartyMonNicknames
ld bc, MON_NAME_LENGTH
call DayCare_GetCurrentPartyMember
- ld hl, wEggNick
+ ld hl, wEggMonNickname
call CopyBytes
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld bc, NAME_LENGTH
call DayCare_GetCurrentPartyMember
- ld hl, wEggOT
+ ld hl, wEggMonOT
call CopyBytes
ld hl, wPartyMon1
@@ -550,10 +550,10 @@ DayCare_InitBreeding:
ld hl, wEggMon
ld bc, BOXMON_STRUCT_LENGTH
call ByteFill
- ld hl, wEggNick
+ ld hl, wEggMonNickname
ld bc, MON_NAME_LENGTH
call ByteFill
- ld hl, wEggOT
+ ld hl, wEggMonOT
ld bc, NAME_LENGTH
call ByteFill
ld a, [wBreedMon1DVs]
@@ -606,11 +606,11 @@ DayCare_InitBreeding:
ld [wEggMonSpecies], a
call GetBaseData
- ld hl, wEggNick
+ ld hl, wEggMonNickname
ld de, .String_EGG
call CopyName2
ld hl, wPlayerName
- ld de, wEggOT
+ ld de, wEggMonOT
ld bc, NAME_LENGTH
call CopyBytes
xor a
diff --git a/engine/events/haircut.asm b/engine/events/haircut.asm
index 932e196b8..2c8aed7b0 100644
--- a/engine/events/haircut.asm
+++ b/engine/events/haircut.asm
@@ -33,7 +33,7 @@ HaircutOrGrooming:
cp EGG
jr z, .egg
push hl
- call GetCurNick
+ call GetCurNickname
call CopyPokemonName_Buffer1_Buffer3
pop hl
call Random
diff --git a/engine/events/magikarp.asm b/engine/events/magikarp.asm
index 3b71ee594..db536c64b 100644
--- a/engine/events/magikarp.asm
+++ b/engine/events/magikarp.asm
@@ -49,7 +49,7 @@ CheckMagikarpLength:
ld [de], a
inc de
ld a, [wCurPartyMon]
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call SkipNames
call CopyBytes
ld a, MAGIKARPLENGTH_BEAT_RECORD
diff --git a/engine/events/move_tutor.asm b/engine/events/move_tutor.asm
index 07c8b8bd4..ebe860502 100644
--- a/engine/events/move_tutor.asm
+++ b/engine/events/move_tutor.asm
@@ -60,7 +60,7 @@ CheckCanLearnMoveTutorMove:
push bc
ld a, [wCurPartyMon]
ld hl, wPartyMonNicknames
- call GetNick
+ call GetNickname
pop bc
ld a, c
diff --git a/engine/events/name_rater.asm b/engine/events/name_rater.asm
index d3a1dc58f..9b6ae6bc9 100644
--- a/engine/events/name_rater.asm
+++ b/engine/events/name_rater.asm
@@ -14,7 +14,7 @@ _NameRater:
cp EGG
jr z, .egg
; ... or a Pokemon you got from a trade.
- call GetCurNick
+ call GetCurNickname
call CheckIfMonIsYourOT
jr c, .traded
; This name is good, but we can do better. How about it?
@@ -57,7 +57,7 @@ _NameRater:
.samename
push hl
- call GetCurNick
+ call GetCurNickname
ld hl, NameRaterNamedText
call PrintText
pop hl
@@ -80,7 +80,7 @@ _NameRater:
CheckIfMonIsYourOT:
; Checks to see if the partymon loaded in [wCurPartyMon] has the different OT as you. Returns carry if not.
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld bc, NAME_LENGTH
ld a, [wCurPartyMon]
call AddNTimes
@@ -138,10 +138,10 @@ CompareNewToOld:
ld a, [wCurPartyMon]
call AddNTimes
push hl
- call GetNicknameLength
+ call GetNicknamenameLength
ld b, c
ld hl, wStringBuffer2
- call GetNicknameLength
+ call GetNicknamenameLength
pop hl
ld a, c
cp b
@@ -165,7 +165,7 @@ CompareNewToOld:
scf
ret
-GetNicknameLength:
+GetNicknamenameLength:
; Gets the length of the name starting at hl and returns it in c.
ld c, 0
.loop
diff --git a/engine/events/npc_trade.asm b/engine/events/npc_trade.asm
index 36cf380ac..b0c0c9dd5 100644
--- a/engine/events/npc_trade.asm
+++ b/engine/events/npc_trade.asm
@@ -132,7 +132,7 @@ DoNPCTrade:
call GetTradeMonName
call CopyTradeName
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld bc, NAME_LENGTH
call Trade_GetAttributeOfCurrentPartymon
ld de, wPlayerTrademonOTName
@@ -196,7 +196,7 @@ DoNPCTrade:
.incomplete
farcall SetGiftPartyMonCaughtData
- ld e, NPCTRADE_NICK
+ ld e, NPCTRADE_NICKNAME
call GetTradeAttr
ld de, wOTTrademonNickname
call CopyTradeName
@@ -216,7 +216,7 @@ DoNPCTrade:
ld de, wOTTrademonSenderName
call CopyTradeName
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld bc, NAME_LENGTH
call Trade_GetAttributeOfLastPartymon
ld hl, wOTTrademonOTName
diff --git a/engine/events/odd_egg.asm b/engine/events/odd_egg.asm
index 9216e0e73..d8ef26a46 100644
--- a/engine/events/odd_egg.asm
+++ b/engine/events/odd_egg.asm
@@ -42,8 +42,8 @@ _GiveOddEgg:
ld a, NICKNAMED_MON_STRUCT_LENGTH
call AddNTimes
- ; Writes to wOddEgg, wOddEggName, and wOddEggOTName,
- ; even though OddEggs does not have data for wOddEggOTName
+ ; Writes to wOddEgg, wOddEggName, and wOddEggOT,
+ ; even though OddEggs does not have data for wOddEggOT
ld de, wOddEgg
ld bc, NICKNAMED_MON_STRUCT_LENGTH + NAME_LENGTH
call CopyBytes
@@ -78,11 +78,11 @@ _GiveOddEgg:
ld bc, MON_NAME_LENGTH
call CopyBytes
- ; load pointer to wTempOddEggNickname in wMobileMonOTNamePointer
+ ; load pointer to wTempOddEggNickname in wMobileMonOTPointer
ld a, LOW(wTempOddEggNickname)
- ld [wMobileMonOTNamePointer], a
+ ld [wMobileMonOTPointer], a
ld a, HIGH(wTempOddEggNickname)
- ld [wMobileMonOTNamePointer + 1], a
+ ld [wMobileMonOTPointer + 1], a
; load pointer to wOddEggName in wMobileMonNicknamePointer
ld a, LOW(wOddEggName)
ld [wMobileMonNicknamePointer], a
diff --git a/engine/events/overworld.asm b/engine/events/overworld.asm
index 1cb797753..ec102744e 100644
--- a/engine/events/overworld.asm
+++ b/engine/events/overworld.asm
@@ -19,13 +19,13 @@ FieldMoveJumptable:
scf
ret
-GetPartyNick:
+GetPartyNickname:
; write wCurPartyMon nickname to wStringBuffer1-3
ld hl, wPartyMonNicknames
ld a, BOXMON
ld [wMonType], a
ld a, [wCurPartyMon]
- call GetNick
+ call GetNickname
call CopyName1
; copy text from wStringBuffer2 to wStringBuffer3
ld de, wStringBuffer2
@@ -204,7 +204,7 @@ Script_CutFromMenu:
special UpdateTimePals
Script_Cut:
- callasm GetPartyNick
+ callasm GetPartyNickname
writetext UseCutText
reloadmappart
callasm CutDownTreeOrGrass
@@ -379,7 +379,7 @@ SurfFunction:
.DoSurf:
call GetSurfType
ld [wSurfingPlayerState], a
- call GetPartyNick
+ call GetPartyNickname
ld hl, SurfFromMenuScript
call QueueScript
ld a, $81
@@ -516,7 +516,7 @@ TrySurfOW::
call GetSurfType
ld [wSurfingPlayerState], a
- call GetPartyNick
+ call GetPartyNickname
ld a, BANK(AskSurfScript)
ld hl, AskSurfScript
@@ -674,7 +674,7 @@ Script_WaterfallFromMenu:
special UpdateTimePals
Script_UsedWaterfall:
- callasm GetPartyNick
+ callasm GetPartyNickname
writetext .UseWaterfallText
waitbutton
closetext
@@ -798,7 +798,7 @@ EscapeRopeOrDig:
ld de, wNextWarp
ld bc, 3
call CopyBytes
- call GetPartyNick
+ call GetPartyNickname
ld a, [wEscapeRopeOrDigType]
cp $2
jr nz, .escaperope
@@ -911,7 +911,7 @@ TeleportFunction:
ret
.DoTeleport:
- call GetPartyNick
+ call GetPartyNickname
ld hl, .TeleportScript
call QueueScript
ld a, $81
@@ -999,7 +999,7 @@ SetStrengthFlag:
add hl, de
ld a, [hl]
ld [wStrengthSpecies], a
- call GetPartyNick
+ call GetPartyNickname
ret
Script_StrengthFromMenu:
@@ -1166,7 +1166,7 @@ Script_WhirlpoolFromMenu:
special UpdateTimePals
Script_UsedWhirlpool:
- callasm GetPartyNick
+ callasm GetPartyNickname
writetext UseWhirlpoolText
reloadmappart
callasm DisappearWhirlpool
@@ -1265,7 +1265,7 @@ HeadbuttFromMenuScript:
special UpdateTimePals
HeadbuttScript:
- callasm GetPartyNick
+ callasm GetPartyNickname
writetext UseHeadbuttText
reloadmappart
@@ -1362,7 +1362,7 @@ RockSmashFromMenuScript:
special UpdateTimePals
RockSmashScript:
- callasm GetPartyNick
+ callasm GetPartyNickname
writetext UseRockSmashText
closetext
special WaitSFX
diff --git a/engine/events/poisonstep.asm b/engine/events/poisonstep.asm
index 827f69411..b7a1ce23a 100644
--- a/engine/events/poisonstep.asm
+++ b/engine/events/poisonstep.asm
@@ -128,7 +128,7 @@ DoPoisonStep::
jr z, .mon_not_fainted
ld c, HAPPINESS_POISONFAINT
farcall ChangeHappiness
- farcall GetPartyNick
+ farcall GetPartyNickname
ld hl, .PoisonFaintText
call PrintText
diff --git a/engine/events/poke_seer.asm b/engine/events/poke_seer.asm
index 8e62d5ded..9ad8d71dd 100644
--- a/engine/events/poke_seer.asm
+++ b/engine/events/poke_seer.asm
@@ -249,10 +249,10 @@ GetCaughtLocation:
GetCaughtOT:
ld a, [wCurPartyMon]
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld bc, NAME_LENGTH
call AddNTimes
- ld de, wSeerOTName
+ ld de, wSeerOT
ld bc, NAME_LENGTH
call CopyBytes
@@ -264,7 +264,7 @@ GetCaughtOT:
ld hl, .female
.got_grammar
- ld de, wSeerOTNameGrammar
+ ld de, wSeerOTGrammar
ld a, "@"
ld [de], a
ret
diff --git a/engine/events/shuckle.asm b/engine/events/shuckle.asm
index 50293cdfc..3e0e8b27f 100644
--- a/engine/events/shuckle.asm
+++ b/engine/events/shuckle.asm
@@ -42,13 +42,13 @@ GiveShuckle:
dec a
ld hl, wPartyMonNicknames
call SkipNames
- ld de, SpecialShuckleNick
+ ld de, SpecialShuckleNickname
call CopyName2
; OT.
ld a, [wPartyCount]
dec a
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call SkipNames
ld de, SpecialShuckleOT
call CopyName2
@@ -68,7 +68,7 @@ GiveShuckle:
SpecialShuckleOT:
db "MANIA@"
-SpecialShuckleNick:
+SpecialShuckleNickname:
db "SHUCKIE@"
ReturnShuckie:
@@ -94,7 +94,7 @@ ReturnShuckie:
; OT
ld a, [wCurPartyMon]
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call SkipNames
ld de, SpecialShuckleOT
.CheckOT:
diff --git a/engine/events/sweet_scent.asm b/engine/events/sweet_scent.asm
index c81aa9c3a..ceda90b11 100644
--- a/engine/events/sweet_scent.asm
+++ b/engine/events/sweet_scent.asm
@@ -8,7 +8,7 @@ SweetScentFromMenu:
.SweetScent:
reloadmappart
special UpdateTimePals
- callasm GetPartyNick
+ callasm GetPartyNickname
writetext UseSweetScentText
waitbutton
callasm SweetScentEncounter
diff --git a/engine/items/item_effects.asm b/engine/items/item_effects.asm
index b7d979fd9..1c88ea15f 100644
--- a/engine/items/item_effects.asm
+++ b/engine/items/item_effects.asm
@@ -1292,7 +1292,7 @@ RareCandy_StatBooster_GetParameters:
call GetBaseData
ld a, [wCurPartyMon]
ld hl, wPartyMonNicknames
- call GetNick
+ call GetNickname
ret
RareCandyEffect:
diff --git a/engine/items/pack.asm b/engine/items/pack.asm
index 0a50bbb7c..4a4b694dd 100644
--- a/engine/items/pack.asm
+++ b/engine/items/pack.asm
@@ -590,7 +590,7 @@ GiveItem:
push af
ld a, [wPackJumptableIndex]
push af
- call GetCurNick
+ call GetCurNickname
ld hl, wStringBuffer1
ld de, wMonOrItemNameBuffer
ld bc, MON_NAME_LENGTH
diff --git a/engine/items/tmhm.asm b/engine/items/tmhm.asm
index 9786b950f..1db310486 100644
--- a/engine/items/tmhm.asm
+++ b/engine/items/tmhm.asm
@@ -122,7 +122,7 @@ TeachTMHM:
push bc
ld a, [wCurPartyMon]
ld hl, wPartyMonNicknames
- call GetNick
+ call GetNickname
pop bc
ld a, c
diff --git a/engine/link/init_list.asm b/engine/link/init_list.asm
index 4d76ebdc8..acececd56 100644
--- a/engine/link/init_list.asm
+++ b/engine/link/init_list.asm
@@ -5,7 +5,7 @@ InitList:
cp INIT_ENEMYOT_LIST
jr nz, .check_party_ot_name
ld hl, wOTPartyCount
- ld de, wOTPartyMonOT
+ ld de, wOTPartyMonOTs
ld a, ENEMY_OT_NAME
jr .done
@@ -13,7 +13,7 @@ InitList:
cp INIT_PLAYEROT_LIST
jr nz, .check_mon_name
ld hl, wPartyCount
- ld de, wPartyMonOT
+ ld de, wPartyMonOTs
ld a, PARTY_OT_NAME
jr .done
diff --git a/engine/link/link.asm b/engine/link/link.asm
index de6ed239a..7de939430 100644
--- a/engine/link/link.asm
+++ b/engine/link/link.asm
@@ -177,9 +177,9 @@ Gen2ToGen1LinkComms:
ld hl, wTimeCapsulePlayerData
call Link_ConvertPartyStruct1to2
- ld a, LOW(wOTPartyMonOT)
+ ld a, LOW(wOTPartyMonOTs)
ld [wUnusedNamesPointer], a
- ld a, HIGH(wOTPartyMonOT)
+ ld a, HIGH(wOTPartyMonOTs)
ld [wUnusedNamesPointer + 1], a
ld de, MUSIC_NONE
@@ -432,9 +432,9 @@ Gen2ToGen2LinkComms:
ld bc, wOTPartyDataEnd - wOTPartyMons
call CopyBytes
- ld a, LOW(wOTPartyMonOT)
+ ld a, LOW(wOTPartyMonOTs)
ld [wUnusedNamesPointer], a
- ld a, HIGH(wOTPartyMonOT)
+ ld a, HIGH(wOTPartyMonOTs)
ld [wUnusedNamesPointer + 1], a
ld de, MUSIC_NONE
@@ -716,7 +716,7 @@ Link_PrepPartyData_Gen1:
dec c
jr nz, .mon_loop
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call .copy_ot_nicks
ld hl, wPartyMonNicknames
@@ -860,7 +860,7 @@ Link_PrepPartyData_Gen2:
ld bc, PARTY_LENGTH * PARTYMON_STRUCT_LENGTH
call CopyBytes
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld bc, PARTY_LENGTH * NAME_LENGTH
call CopyBytes
@@ -1005,7 +1005,7 @@ Link_ConvertPartyStruct1to2:
pop hl
ld bc, PARTY_LENGTH * REDMON_STRUCT_LENGTH
add hl, bc
- ld de, wOTPartyMonOT
+ ld de, wOTPartyMonOTs
ld bc, PARTY_LENGTH * NAME_LENGTH
call CopyBytes
ld de, wOTPartyMonNicknames
@@ -1672,7 +1672,7 @@ LinkTrade:
ld [wNamedObjectIndex], a
call GetPokemonName
ld hl, wStringBuffer1
- ld de, wBufferTrademonNick
+ ld de, wBufferTrademonNickname
ld bc, MON_NAME_LENGTH
call CopyBytes
ld a, [wCurOTTradePartyMon]
@@ -1811,7 +1811,7 @@ LinkTrade:
push af
; OT name
ld a, [wCurTradePartyMon]
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call SkipNames
ld de, wPlayerTrademonOTName
ld bc, NAME_LENGTH
@@ -1858,7 +1858,7 @@ LinkTrade:
ld [wOTTrademonSpecies], a
; OT name
ld a, [wCurOTTradePartyMon]
- ld hl, wOTPartyMonOT
+ ld hl, wOTPartyMonOTs
call SkipNames
ld de, wOTTrademonOTName
ld bc, NAME_LENGTH
diff --git a/engine/movie/trade_animation.asm b/engine/movie/trade_animation.asm
index 2cf49578c..999091280 100644
--- a/engine/movie/trade_animation.asm
+++ b/engine/movie/trade_animation.asm
@@ -212,10 +212,10 @@ RunTradeAnimScript:
call TradeAnim_GetFrontpic
ld a, [wPlayerTrademonSpecies]
ld de, wPlayerTrademonSpeciesName
- call TradeAnim_GetNickname
+ call TradeAnim_GetNicknamename
ld a, [wOTTrademonSpecies]
ld de, wOTTrademonSpeciesName
- call TradeAnim_GetNickname
+ call TradeAnim_GetNicknamename
call TradeAnim_NormalPals
ret
@@ -817,7 +817,7 @@ TradeAnim_GetFrontpic:
predef GetMonFrontpic
ret
-TradeAnim_GetNickname:
+TradeAnim_GetNicknamename:
push de
ld [wNamedObjectIndex], a
call GetPokemonName
diff --git a/engine/pokemon/bills_pc.asm b/engine/pokemon/bills_pc.asm
index 8c37d3b8f..e9a0bc82f 100644
--- a/engine/pokemon/bills_pc.asm
+++ b/engine/pokemon/bills_pc.asm
@@ -1709,7 +1709,7 @@ BillsPC_CopyMon:
call CopySpeciesToTemp
ld hl, sBoxMonNicknames
call CopyNicknameToTemp
- ld hl, sBoxMonOT
+ ld hl, sBoxMonOTs
call CopyOTNameToTemp
ld hl, sBoxMons
ld bc, BOXMON_STRUCT_LENGTH
@@ -1727,7 +1727,7 @@ BillsPC_CopyMon:
call CopySpeciesToTemp
ld hl, wPartyMonNicknames
call CopyNicknameToTemp
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call CopyOTNameToTemp
ld hl, wPartyMon1
ld bc, PARTYMON_STRUCT_LENGTH
@@ -1753,7 +1753,7 @@ BillsPC_CopyMon:
call CopyNicknameToTemp
pop hl
push hl
- ld bc, sBoxMonOT - sBox
+ ld bc, sBoxMonOTs - sBox
add hl, bc
call CopyOTNameToTemp
pop hl
@@ -1772,7 +1772,7 @@ DepositPokemon:
ld [wCurPartyMon], a
ld hl, wPartyMonNicknames
ld a, [wCurPartyMon]
- call GetNick
+ call GetNickname
ld a, PC_DEPOSIT
ld [wPokemonWithdrawDepositParameter], a
predef SendGetMonIntoFromBox
@@ -1826,7 +1826,7 @@ TryWithdrawPokemon:
call OpenSRAM
ld a, [wCurPartyMon]
ld hl, sBoxMonNicknames
- call GetNick
+ call GetNickname
call CloseSRAM
xor a
ld [wPokemonWithdrawDepositParameter], a
@@ -2051,7 +2051,7 @@ MovePKMNWitoutMail_InsertMon:
call CopySpeciesToTemp
ld hl, sBoxMonNicknames
call CopyNicknameToTemp
- ld hl, sBoxMonOT
+ ld hl, sBoxMonOTs
call CopyOTNameToTemp
ld hl, sBoxMons
ld bc, BOXMON_STRUCT_LENGTH
@@ -2084,7 +2084,7 @@ MovePKMNWitoutMail_InsertMon:
call CopySpeciesToTemp
ld hl, wPartyMonNicknames
call CopyNicknameToTemp
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call CopyOTNameToTemp
ld hl, wPartyMon1Species
ld bc, PARTYMON_STRUCT_LENGTH
@@ -2115,7 +2115,7 @@ CopyNicknameToTemp:
ld bc, MON_NAME_LENGTH
ld a, [wCurPartyMon]
call AddNTimes
- ld de, wBufferMonNick
+ ld de, wBufferMonNickname
ld bc, MON_NAME_LENGTH
call CopyBytes
ret
diff --git a/engine/pokemon/breeding.asm b/engine/pokemon/breeding.asm
index bcf5322e2..cda397179 100644
--- a/engine/pokemon/breeding.asm
+++ b/engine/pokemon/breeding.asm
@@ -303,7 +303,7 @@ HatchEggs:
ld a, [wPlayerID + 1]
ld [hl], a
ld a, [wCurPartyMon]
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld bc, NAME_LENGTH
call AddNTimes
ld d, h
@@ -870,7 +870,7 @@ DayCareMon1:
bit DAYCARELADY_HAS_MON_F, a
jr z, DayCareMonCursor
call PromptButton
- ld hl, wBreedMon2Nick
+ ld hl, wBreedMon2Nickname
call DayCareMonCompatibilityText
jp PrintText
@@ -883,7 +883,7 @@ DayCareMon2:
bit DAYCAREMAN_HAS_MON_F, a
jr z, DayCareMonCursor
call PromptButton
- ld hl, wBreedMon1Nick
+ ld hl, wBreedMon1Nickname
call DayCareMonCompatibilityText
jp PrintText
diff --git a/engine/pokemon/caught_data.asm b/engine/pokemon/caught_data.asm
index bb115a841..4589eacdf 100644
--- a/engine/pokemon/caught_data.asm
+++ b/engine/pokemon/caught_data.asm
@@ -31,7 +31,7 @@ CheckPartyFullAfterContest:
call CopyBytes
ld a, [wPartyCount]
dec a
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call SkipNames
ld d, h
ld e, l
diff --git a/engine/pokemon/correct_party_errors.asm b/engine/pokemon/correct_party_errors.asm
index cc3901096..c10be0910 100644
--- a/engine/pokemon/correct_party_errors.asm
+++ b/engine/pokemon/correct_party_errors.asm
@@ -137,7 +137,7 @@ CorrectPartyErrors: ; unreferenced
dec b
jr nz, .loop3
- ld de, wPartyMonOT
+ ld de, wPartyMonOTs
ld a, [wPartyCount]
ld b, a
ld c, 0
diff --git a/engine/pokemon/european_mail.asm b/engine/pokemon/european_mail.asm
index eb9b7d5d9..2ba5e6c97 100644
--- a/engine/pokemon/european_mail.asm
+++ b/engine/pokemon/european_mail.asm
@@ -5,7 +5,7 @@ IsMailEuropean:
; return 4 if Spanish
; return 0 if none of the above
ld c, $0
- ld hl, sPartyMon1MailAuthorNationality - sPartyMon1Mail
+ ld hl, sPartyMon1MailNationality - sPartyMon1Mail
add hl, de
ld a, [hli]
cp "E"
diff --git a/engine/pokemon/evolve.asm b/engine/pokemon/evolve.asm
index 839e2c167..0b2cc15bb 100644
--- a/engine/pokemon/evolve.asm
+++ b/engine/pokemon/evolve.asm
@@ -202,7 +202,7 @@ EvolveAfterBattle_MasterLoop:
ld [wEvolutionNewSpecies], a
ld a, [wCurPartyMon]
ld hl, wPartyMonNicknames
- call GetNick
+ call GetNickname
call CopyName1
ld hl, EvolvingText
call PrintText
diff --git a/engine/pokemon/learn.asm b/engine/pokemon/learn.asm
index 2c597c7b6..c7728249e 100644
--- a/engine/pokemon/learn.asm
+++ b/engine/pokemon/learn.asm
@@ -2,7 +2,7 @@ LearnMove:
call LoadTilemapToTempTilemap
ld a, [wCurPartyMon]
ld hl, wPartyMonNicknames
- call GetNick
+ call GetNickname
ld hl, wStringBuffer1
ld de, wMonOrItemNameBuffer
ld bc, MON_NAME_LENGTH
diff --git a/engine/pokemon/mail.asm b/engine/pokemon/mail.asm
index e9cc15517..e70f0ec53 100644
--- a/engine/pokemon/mail.asm
+++ b/engine/pokemon/mail.asm
@@ -213,7 +213,7 @@ GivePokeMail::
call CopyBytes
pop af
push af
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld bc, NAME_LENGTH
call AddNTimes
ld bc, NAME_LENGTH - 1
diff --git a/engine/pokemon/mon_menu.asm b/engine/pokemon/mon_menu.asm
index 14db39531..2607cdf58 100644
--- a/engine/pokemon/mon_menu.asm
+++ b/engine/pokemon/mon_menu.asm
@@ -109,7 +109,7 @@ PokemonActionSubmenu:
lb bc, 2, 18
call ClearBox
farcall MonSubmenu
- call GetCurNick
+ call GetCurNickname
ld a, [wMenuSelection]
ld hl, .Actions
ld de, 3
@@ -210,7 +210,7 @@ GiveTakePartyMonItem:
call ExitMenu
jr c, .cancel
- call GetCurNick
+ call GetCurNickname
ld hl, wStringBuffer1
ld de, wMonOrItemNameBuffer
ld bc, MON_NAME_LENGTH
@@ -529,7 +529,7 @@ MonMailAction:
jr nc, .BagIsFull
call GetPartyItemLocation
ld [hl], $0
- call GetCurNick
+ call GetCurNickname
ld hl, .MailDetachedText
call MenuTextboxBackup
jr .done
@@ -1119,7 +1119,7 @@ SetUpMoveScreenBG:
ld [wMonType], a
ld hl, wPartyMonNicknames
ld a, [wCurPartyMon]
- call GetNick
+ call GetNickname
hlcoord 5, 1
call PlaceString
push bc
diff --git a/engine/pokemon/mon_stats.asm b/engine/pokemon/mon_stats.asm
index caded2875..78f963ebd 100644
--- a/engine/pokemon/mon_stats.asm
+++ b/engine/pokemon/mon_stats.asm
@@ -343,7 +343,7 @@ Unused_PlaceEnemyHPLevel:
push hl
ld hl, wPartyMonNicknames
ld a, [wCurPartyMon]
- call GetNick
+ call GetNickname
pop hl
call PlaceString
call CopyMonToTempMon
diff --git a/engine/pokemon/move_mon.asm b/engine/pokemon/move_mon.asm
index e51bbfe0a..e214b5b6a 100644
--- a/engine/pokemon/move_mon.asm
+++ b/engine/pokemon/move_mon.asm
@@ -34,11 +34,11 @@ TryAddMonToParty:
ld a, -1
ld [de], a
; Now let's load the OT name.
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld a, [wMonType]
and $f
jr z, .loadOTname
- ld hl, wOTPartyMonOT
+ ld hl, wOTPartyMonOTs
.loadOTname
ldh a, [hMoveMon] ; Restore index from backup
@@ -419,13 +419,13 @@ AddTempmonToParty:
ld hl, wTempMonSpecies
call CopyBytes
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld a, [wPartyCount]
dec a
call SkipNames
ld d, h
ld e, l
- ld hl, wOTPartyMonOT
+ ld hl, wOTPartyMonOTs
ld a, [wCurPartyMon]
call SkipNames
ld bc, NAME_LENGTH
@@ -565,10 +565,10 @@ SendGetMonIntoFromBox:
ld de, wBreedMon1OT
jr z, .okay5
dec a
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld a, [wPartyCount]
jr nz, .okay6
- ld hl, sBoxMonOT
+ ld hl, sBoxMonOTs
ld a, [sBoxCount]
.okay6
@@ -578,14 +578,14 @@ SendGetMonIntoFromBox:
ld e, l
.okay5
- ld hl, sBoxMonOT
+ ld hl, sBoxMonOTs
ld a, [wPokemonWithdrawDepositParameter]
and a
jr z, .okay7
ld hl, wBreedMon1OT
cp DAY_CARE_WITHDRAW
jr z, .okay8
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
.okay7
ld a, [wCurPartyMon]
@@ -596,7 +596,7 @@ SendGetMonIntoFromBox:
call CopyBytes
ld a, [wPokemonWithdrawDepositParameter]
cp DAY_CARE_DEPOSIT
- ld de, wBreedMon1Nick
+ ld de, wBreedMon1Nickname
jr z, .okay9
dec a
ld hl, wPartyMonNicknames
@@ -616,7 +616,7 @@ SendGetMonIntoFromBox:
ld a, [wPokemonWithdrawDepositParameter]
and a
jr z, .okay11
- ld hl, wBreedMon1Nick
+ ld hl, wBreedMon1Nickname
cp DAY_CARE_WITHDRAW
jr z, .okay12
ld hl, wPartyMonNicknames
@@ -819,10 +819,10 @@ RetrieveBreedmon:
ld a, [wPokemonWithdrawDepositParameter]
and a
ld a, [wBreedMon1Species]
- ld de, wBreedMon1Nick
+ ld de, wBreedMon1Nickname
jr z, .okay
ld a, [wBreedMon2Species]
- ld de, wBreedMon2Nick
+ ld de, wBreedMon2Nickname
.okay
ld [hli], a
@@ -839,7 +839,7 @@ RetrieveBreedmon:
pop de
call CopyBytes
push hl
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld a, [wPartyCount]
dec a
call SkipNames
@@ -909,14 +909,14 @@ GetLastPartyMon:
ret
DepositMonWithDayCareMan:
- ld de, wBreedMon1Nick
+ ld de, wBreedMon1Nickname
call DepositBreedmon
xor a ; REMOVE_PARTY
ld [wPokemonWithdrawDepositParameter], a
jp RemoveMonFromPartyOrBox
DepositMonWithDayCareLady:
- ld de, wBreedMon2Nick
+ ld de, wBreedMon2Nickname
call DepositBreedmon
xor a ; REMOVE_PARTY
ld [wPokemonWithdrawDepositParameter], a
@@ -928,7 +928,7 @@ DepositBreedmon:
call SkipNames
call CopyBytes
ld a, [wCurPartyMon]
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call SkipNames
call CopyBytes
ld a, [wCurPartyMon]
@@ -967,7 +967,7 @@ SendMonIntoBox:
call ShiftBoxMon
ld hl, wPlayerName
- ld de, sBoxMonOT
+ ld de, sBoxMonOTs
ld bc, NAME_LENGTH
call CopyBytes
@@ -1071,7 +1071,7 @@ SendMonIntoBox:
ret
ShiftBoxMon:
- ld hl, sBoxMonOT
+ ld hl, sBoxMonOTs
ld bc, NAME_LENGTH
call .shift
@@ -1246,12 +1246,12 @@ RemoveMonFromPartyOrBox:
ld [hli], a
inc a
jr nz, .loop
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld d, PARTY_LENGTH - 1
ld a, [wPokemonWithdrawDepositParameter]
and a
jr z, .party
- ld hl, sBoxMonOT
+ ld hl, sBoxMonOTs
ld d, MONS_PER_BOX - 1
.party
@@ -1296,13 +1296,13 @@ RemoveMonFromPartyOrBox:
jr z, .party5
ld bc, BOXMON_STRUCT_LENGTH
add hl, bc
- ld bc, sBoxMonOT
+ ld bc, sBoxMonOTs
jr .copy
.party5
ld bc, PARTYMON_STRUCT_LENGTH
add hl, bc
- ld bc, wPartyMonOT
+ ld bc, wPartyMonOTs
.copy
call CopyDataUntil
; Shift the nicknames
@@ -1705,7 +1705,7 @@ GivePoke::
push hl
ld a, [wCurPartyMon]
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call SkipNames
ld d, h
ld e, l
@@ -1734,9 +1734,9 @@ GivePoke::
jr .skip_nickname
.send_to_box
- ld a, BANK(sBoxMonOT)
+ ld a, BANK(sBoxMonOTs)
call OpenSRAM
- ld de, sBoxMonOT
+ ld de, sBoxMonOTs
.loop
ld a, [wScriptBank]
call GetFarByte
diff --git a/engine/pokemon/move_mon_wo_mail.asm b/engine/pokemon/move_mon_wo_mail.asm
index 79f70d05e..b8e492f1e 100644
--- a/engine/pokemon/move_mon_wo_mail.asm
+++ b/engine/pokemon/move_mon_wo_mail.asm
@@ -8,12 +8,12 @@ InsertPokemonIntoBox:
ld [wNextBoxOrPartyIndex], a
ld hl, sBoxMonNicknames
ld bc, MON_NAME_LENGTH
- ld de, wBufferMonNick
+ ld de, wBufferMonNickname
call InsertDataIntoBoxOrParty
ld a, [sBoxCount]
dec a
ld [wNextBoxOrPartyIndex], a
- ld hl, sBoxMonOT
+ ld hl, sBoxMonOTs
ld bc, NAME_LENGTH
ld de, wBufferMonOT
call InsertDataIntoBoxOrParty
@@ -45,12 +45,12 @@ InsertPokemonIntoParty:
ld [wNextBoxOrPartyIndex], a
ld hl, wPartyMonNicknames
ld bc, MON_NAME_LENGTH
- ld de, wBufferMonNick
+ ld de, wBufferMonNickname
call InsertDataIntoBoxOrParty
ld a, [wPartyCount]
dec a
ld [wNextBoxOrPartyIndex], a
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
ld bc, NAME_LENGTH
ld de, wBufferMonOT
call InsertDataIntoBoxOrParty
diff --git a/engine/pokemon/party_menu.asm b/engine/pokemon/party_menu.asm
index 91a403a6b..db3d7d25d 100644
--- a/engine/pokemon/party_menu.asm
+++ b/engine/pokemon/party_menu.asm
@@ -91,7 +91,7 @@ PlacePartyNicknames:
push hl
ld hl, wPartyMonNicknames
ld a, b
- call GetNick
+ call GetNickname
pop hl
call PlaceString
pop hl
@@ -773,7 +773,7 @@ YouHaveNoPKMNString:
PrintPartyMenuActionText:
ld a, [wCurPartyMon]
ld hl, wPartyMonNicknames
- call GetNick
+ call GetNickname
ld a, [wPartyMenuActionText]
and $f
ld hl, .MenuActionTexts
diff --git a/engine/pokemon/search.asm b/engine/pokemon/search.asm
index b6da60605..522ed3493 100644
--- a/engine/pokemon/search.asm
+++ b/engine/pokemon/search.asm
@@ -58,7 +58,7 @@ CheckOwnMonAnywhere:
ld d, a
ld e, 0
ld hl, wPartyMon1Species
- ld bc, wPartyMonOT
+ ld bc, wPartyMonOTs
; Run CheckOwnMon on each Pokémon in the party.
.partymon
@@ -82,7 +82,7 @@ CheckOwnMonAnywhere:
ld d, a
ld hl, sBoxMon1Species
- ld bc, sBoxMonOT
+ ld bc, sBoxMonOTs
.openboxmon
call CheckOwnMon
jr nc, .loop
@@ -138,7 +138,7 @@ CheckOwnMonAnywhere:
ld e, l
pop hl
push de
- ld de, sBoxMonOT - sBoxCount
+ ld de, sBoxMonOTs - sBoxCount
add hl, de
ld b, h
ld c, l
diff --git a/engine/pokemon/stats_screen.asm b/engine/pokemon/stats_screen.asm
index 059732444..4c351ff91 100644
--- a/engine/pokemon/stats_screen.asm
+++ b/engine/pokemon/stats_screen.asm
@@ -430,7 +430,7 @@ StatsScreen_InitUpperHalf:
hlcoord 14, 0
call PrintLevel
ld hl, .NicknamePointers
- call GetNicknamePointer
+ call GetNicknamenamePointer
call CopyNickname
hlcoord 8, 2
call PlaceString
@@ -481,7 +481,7 @@ StatsScreen_InitUpperHalf:
dw wPartyMonNicknames
dw wOTPartyMonNicknames
dw sBoxMonNicknames
- dw wBufferMonNick
+ dw wBufferMonNickname
StatsScreen_PlaceVerticalDivider: ; unreferenced
; The Japanese stats screen has a vertical divider.
@@ -789,7 +789,7 @@ LoadBluePage:
ld de, wTempMonID
call PrintNum
ld hl, .OTNamePointers
- call GetNicknamePointer
+ call GetNicknamenamePointer
call CopyNickname
farcall CorrectNickErrors
hlcoord 2, 13
@@ -810,9 +810,9 @@ LoadBluePage:
ret
.OTNamePointers:
- dw wPartyMonOT
- dw wOTPartyMonOT
- dw sBoxMonOT
+ dw wPartyMonOTs
+ dw wOTPartyMonOTs
+ dw sBoxMonOTs
dw wBufferMonOT
IDNoString:
@@ -1157,7 +1157,7 @@ CopyNickname:
pop de
ret
-GetNicknamePointer:
+GetNicknamenamePointer:
ld a, [wMonType]
add a
ld c, a
diff --git a/engine/pokemon/switchpartymons.asm b/engine/pokemon/switchpartymons.asm
index 1ec3cf698..b6c152d7e 100644
--- a/engine/pokemon/switchpartymons.asm
+++ b/engine/pokemon/switchpartymons.asm
@@ -81,12 +81,12 @@ _SwitchPartyMons:
ld bc, PARTYMON_STRUCT_LENGTH
call CopyBytes
ld a, [wSwitchMonTo]
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call SkipNames
push hl
call .CopyNameToSwitchMonBuffer
ld a, [wSwitchMonFrom]
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call SkipNames
pop de
push hl
diff --git a/engine/printer/print_party.asm b/engine/printer/print_party.asm
index 190249b6e..3561079a3 100644
--- a/engine/printer/print_party.asm
+++ b/engine/printer/print_party.asm
@@ -192,7 +192,7 @@ PrintPartyMonPage1:
hlcoord 1, 9
ld de, PrintParty_OTString
call PlaceString
- ld hl, wPartyMonOT
+ ld hl, wPartyMonOTs
call GetCurPartyMonName
hlcoord 4, 9
call PlaceString