summaryrefslogtreecommitdiff
path: root/engine/items
AgeCommit message (Collapse)Author
2020-07-13Disassemble the final English debug ROMRangi
2020-07-10Use const_skip and const_next macros for brevityRangi
2020-06-22Identify some more labelsRangi
2020-06-21Sync PokeFluteTerminator with pokegoldRangi
2020-06-21Replace "Unreferenced" labels with "; unreferenced" commentsRangi
2020-06-17Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to ↵Rangi
OpenSRAM) To do: engine/{menus, overworld}
2020-06-17Harmonize engine/{gfx, items, link, math} with pokegoldRangi
2020-05-29Rename ScrollingMenu_UpdateDisplay.string_2485f (#726)Lhivorde
2020-05-25Group MoveDescriptions with PrintMoveDesc and rename that to ↵Rangi
PrintMoveDescription (like ItemDescriptions with PrintItemDescription)
2020-03-21Add suffixes to some constants to avoid ambiguityRangi
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`) - `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`) - `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`) - `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`) This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
2020-02-23Replace some "idiotic", "wtf", "stupid interns" comments with more common ↵Rangi
"useless", "pointless", "could have done X instead"
2020-02-13Standardize on lowercase Tilemap and Attrmapmid-kid
We used to have a mixture of TileMap and and Tilemap, as well as the similar AttrMap. Standardize on one.
2019-11-03Bit 6 of PrintNum left-aligns numbersRangi
2019-10-20#641 fixes and additions. (#646)mid-kid
Name a lot of text labels according to our conventions
2019-06-09Create constants for ScrollingMenu item formatsmid-kid
...I should've done this quite a while ago.
2019-04-09TextBox -> Textboxmid-kid
Homogenizing names.
2019-04-08Identify and eliminate wEngineBuffer1-5Rangi
2019-03-18Fix wram labeling for wPCItemsFredrik Ljungdahl
2018-11-18Resolve issue #575: Rename text commandsRangi
2018-11-05text_jump → text_farmid-kid
The previous name for this was rather misleading. It isn't an actual jump like you'd expect the `jp` instruction to behave as. Instead, it behaves more like a `farcall`. This also makes it consistent with its current command ID name of `TX_FAR`.
2018-09-22Naming screen constantsRangi
2018-09-09Curr -> CurRangi
2018-08-26hQuotient is a four-byte buffer (fixes #558)Rangi
2018-08-25Use labels instead of constants for HRAMRangi
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-17Fix some StatUp-related labelsmid-kid
2018-08-07wWeeklyFlags -> wDailyFlags2mid-kid
These are by far not always checked each week, and as such shouldn't be called that. Since they're almost always used through the `bit` instruction, it's very inconvenient to just make wDailyFlags a `dw` instead.
2018-08-07Split print_move_description and mon_menumid-kid
2018-07-29Fix reviewed issues.Rangi
Pokedex_PrintListing has a comment noting how it depends on wCurSpecies == wNamedObjectIndexBuffer; an assert would be more convenient, but is not possible since WRAM label addresses are not defined yet here.
2018-07-29Add meaningful aliases for wd265Rangi
Introduce MONICON_* constants Introduce BATTLEPLAYERACTION_* constants
2018-06-25Keep more data/ INCLUDEs with relevant routinesRangi
2018-06-25No space between labels and bodiesRangi
2018-06-25Remove more triple newlinesRangi
2018-06-24Fix triple newlines left over from removing address commentsRangi
2018-06-24Merge branch 'master' of https://github.com/pret/pokecrystalRangi
# Conflicts: # engine/items/mart.asm
2018-06-25Remove even more address commentsmid-kid
That should be all of them this time
2018-06-24Remove all address commentsmid-kid
2018-06-23wCurMartEnd - wCurMart = 16Rangi
2018-06-23Add STANDARDMART_* jumptable index constantsRangi
2018-06-12Note which labels are only needed for locating banks (relevant to issue #485)Rangi
2018-05-20Use REGISTERED_* constantsRangi
128px wide pack_menu.png matches BGB VRAM viewer, and rows+cols match hex tile IDs (e.g. $24 = row 3 col 5)
2018-05-06'rept' is not indentedRangi
2018-04-05Use constants for bit/set/res moreRangi
2018-04-04Fix snake_case filenamesmid-kid
Renamed a bunch of files, most of them one-off functions, to better fit the general snake_case naming scheme. Also renamed some awfully long filenames.
2018-04-01Fix file permissionsmid-kid
I have no idea why this was a thing (do people store this repo on FAT32 flash drives or something?), but quite a bit of files had a permission of 755. This isn't really a problem, but it's inconsistent and weird.
2018-03-25Organize the engine/ directory, take 3mid-kid
Renamed `title` to `movies`. Moved some functions from `engine/routines/` to their fitting directories, and cleaned up the base `engine/` directory. Moved `engine/pokemon/tmhm.asm` back to `engine/items/`. Made a new subdirectory: * engine/tilesets: Contains all map-related graphics routines.
2018-03-14Organize the engine/ directory, take 2mid-kid
Renamed `game` to `games` and `menu` to `menus`. Moved some functions from `engine/routines/` to their fitting subdirectories. Made two new subdirectories: * engine/rtc: Contains all RTC-related things. Menus, hardware, misc functions. * engine/items: Contains all item-related things. Pack, item effects, other item handlers.