summaryrefslogtreecommitdiff
path: root/engine/items
AgeCommit message (Collapse)Author
2022-03-09Identify some wMenuJoypad-related button constantsRangi
2022-02-22Rename `GetPokedexEntryBank` to `HeavyBall_GetDexEntryBank`Rangi
2021-11-23Use ~X instead of $ff ^ XRangi
2021-03-17Consistent labels for each nickname in RAMRangi
2021-03-08Merge pull request #806 from Rangi42/tablesRangi
Verify data table sizes with table_width and assert_table_length macros
2021-03-08Identify scrolling menu lists in WRAMRangi
Fixes #809
2021-03-04Verify data table sizes with table_width and assert_table_length macrosRangi
This was discussed in #706 It also uncovered some off-by-one issues with defining some constants. A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-01-09Rename GetFarHalfword to GetFarWordRangi
Fixes #796
2020-12-23Rename some labelsRangi
- Remove "Buffer" suffix from some byte and word quantities - Change "Ptr" to "Pointer" Fixes #789
2020-11-24Use STRING_BUFFER_LENGTH for the wStringBuffersRangi
2020-11-09Replace $0 with 0 for "ld l, a / ld h, 0" idiomRangi
2020-11-03Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobileRangi
2020-11-03Identify some more uses of wBuffer1-6Rangi
2020-11-03Identify more uses of wBuffer1-6Rangi
2020-11-03More syncing with pokegoldRangi
2020-10-29Identify the remaining (non-mobile) uses of another WRAM unionRangi
2020-10-26Comment, remove, or revise many unreferenced labelsRangi
2020-10-21Identify SwitchItemsInBag labelsRangi
Thanks to FIQ for having done so in Polished Crystal
2020-10-06Update battle anim bg function comments, and identify more unnamed labelsRangi
2020-10-05Identify some more unnamed labelsRangi
2020-10-05Identify more unnamed labelsRangi
2020-10-04Identify some more unnamed labelsRangi
2020-09-27Fix #769: document the Heavy Ball weight bank bugRangi
2020-08-18Merge pull request #756 from mid-kid/masterRangi
Rub a dub dub, thanks for the grub
2020-08-12Factor out gfx/pack/pack_menu.tilemapRangi
2020-08-03Better label 2D menu datamid-kid
2020-07-13Disassemble the final English debug ROMRangi
2020-07-10Use const_skip and const_next macros for brevityRangi
2020-06-22Identify some more labelsRangi
2020-06-21Sync PokeFluteTerminator with pokegoldRangi
2020-06-21Replace "Unreferenced" labels with "; unreferenced" commentsRangi
2020-06-17Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to ↵Rangi
OpenSRAM) To do: engine/{menus, overworld}
2020-06-17Harmonize engine/{gfx, items, link, math} with pokegoldRangi
2020-05-29Rename ScrollingMenu_UpdateDisplay.string_2485f (#726)Lhivorde
2020-05-25Group MoveDescriptions with PrintMoveDesc and rename that to ↵Rangi
PrintMoveDescription (like ItemDescriptions with PrintItemDescription)
2020-03-21Add suffixes to some constants to avoid ambiguityRangi
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`) - `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`) - `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`) - `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`) This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
2020-02-23Replace some "idiotic", "wtf", "stupid interns" comments with more common ↵Rangi
"useless", "pointless", "could have done X instead"
2020-02-13Standardize on lowercase Tilemap and Attrmapmid-kid
We used to have a mixture of TileMap and and Tilemap, as well as the similar AttrMap. Standardize on one.
2019-11-03Bit 6 of PrintNum left-aligns numbersRangi
2019-10-20#641 fixes and additions. (#646)mid-kid
Name a lot of text labels according to our conventions
2019-06-09Create constants for ScrollingMenu item formatsmid-kid
...I should've done this quite a while ago.
2019-04-09TextBox -> Textboxmid-kid
Homogenizing names.
2019-04-08Identify and eliminate wEngineBuffer1-5Rangi
2019-03-18Fix wram labeling for wPCItemsFredrik Ljungdahl
2018-11-18Resolve issue #575: Rename text commandsRangi
2018-11-05text_jump → text_farmid-kid
The previous name for this was rather misleading. It isn't an actual jump like you'd expect the `jp` instruction to behave as. Instead, it behaves more like a `farcall`. This also makes it consistent with its current command ID name of `TX_FAR`.
2018-09-22Naming screen constantsRangi
2018-09-09Curr -> CurRangi
2018-08-26hQuotient is a four-byte buffer (fixes #558)Rangi
2018-08-25Use labels instead of constants for HRAMRangi
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld