summaryrefslogtreecommitdiff
path: root/engine/pokegear
AgeCommit message (Collapse)Author
2022-01-10Use time constants more often (#867)Idain
2021-06-19Standardize capitalization of ".Jumptable"Rangi
2021-04-19Use rgbds 0.5.0Rangi
2021-03-24Sync some files with pokegoldRangi
2021-03-21The radio's "Places & People" does not comment on Mysticalman EusineRangi
2021-03-16Revise some constant definitionsRangi
2021-03-04Verify data table sizes with table_width and assert_table_length macrosRangi
This was discussed in #706 It also uncovered some off-by-one issues with defining some constants. A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-01-09Rename GetFarHalfword to GetFarWordRangi
Fixes #796
2020-12-23Rename some labelsRangi
- Remove "Buffer" suffix from some byte and word quantities - Change "Ptr" to "Pointer" Fixes #789
2020-11-17Correct some filename commentsRangi
2020-11-09Replace $0 with 0 for "ld l, a / ld h, 0" idiomRangi
2020-10-28Identify more WRAM labels, and start a <X>_DummyFunction label conventionRangi
2020-10-28Replace many '; unused' with '; unreferenced'Rangi
2020-10-26Use more assertions to ensure correct code and dataRangi
2020-10-26Comment, remove, or revise many unreferenced labelsRangi
2020-10-06Update battle anim bg function comments, and identify more unnamed labelsRangi
2020-10-05Identify more unnamed labelsRangi
2020-10-04Identify more unnamed labelsRangi
2020-08-18Merge pull request #756 from mid-kid/masterRangi
Rub a dub dub, thanks for the grub
2020-08-13Consistent constants for radio data table sizes (could still be better)Rangi
2020-08-03Prevent OaksPKMNTalk from looping forever if NUM_GRASSMON is changedmid-kid
That should cause no real problems because of a range check right after it.
2020-07-21Define JOHTO_FLYPOINT like KANTO_FLYPOINTRangi
2020-07-21Define NUM_FLYPOINTSRangi
2020-07-01Identify more labels, and use the jumptable macro when possibleRangi
2020-06-21Replace "Unreferenced" labels with "; unreferenced" commentsRangi
2020-06-17Harmonize engine/{phone, pokedex, pokegear, printer, rtc, tilesets} with ↵Rangi
pokegold To do: engine/{menus, movie, overworld, pokemon}
2020-04-04Miscellaneous fixes:Rangi
- `hSecondsBackup` -> `hUnusedBackup` - `ld bc, hBGMapAddress + 1` -> `bccoord -1, -2, 0` - Identify some `.asm_XXX` labels
2020-03-15Add a `LANDMARK_` prefix to landmark constantsRangi
Resolves #697
2020-02-13Standardize on lowercase Tilemap and Attrmapmid-kid
We used to have a mixture of TileMap and and Tilemap, as well as the similar AttrMap. Standardize on one.
2020-02-13InitSpriteAnimStruct <-> _InitSpriteAnimStructmid-kid
These were the wrong way around, as the function in home should not be prefixed
2020-02-06PnP_HiddenPlaces -> PnP_PlacesRangi
The "Places & People" radio station does not avoid these maps; it only describes these maps.
2020-01-19PHONE_DISPLAY_HEIGHT is 4, the number of visible phone entriesRangi
2019-11-18Make the map setup commands match the actual function names bettermid-kid
These functions used as map setup commands are used in other places, too, so I can't prefix them under the same. The names should match except I won't repeat "map" in a map setup command name.
2019-10-20#641 fixes and additions. (#646)mid-kid
Name a lot of text labels according to our conventions
2019-06-10Apply suggested changesmid-kid
2019-04-09TextBox -> Textboxmid-kid
Homogenizing names.
2018-11-18Resolve issue #575: Rename text commandsRangi
2018-11-05text_jump → text_farmid-kid
The previous name for this was rather misleading. It isn't an actual jump like you'd expect the `jp` instruction to behave as. Instead, it behaves more like a `farcall`. This also makes it consistent with its current command ID name of `TX_FAR`.
2018-09-09Curr -> CurRangi
2018-08-25Use labels instead of constants for HRAMRangi
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-07wWeeklyFlags -> wDailyFlags2mid-kid
These are by far not always checked each week, and as such shouldn't be called that. Since they're almost always used through the `bit` instruction, it's very inconvenient to just make wDailyFlags a `dw` instead.
2018-07-29Add meaningful aliases for wd265Rangi
Introduce MONICON_* constants Introduce BATTLEPLAYERACTION_* constants
2018-07-18Fix misnamed character codesmid-kid
Some character codes were erroneously named after their text command counterparts. This has caused a lot of confusion with naming their functions and with other things. I've also removed the `dict2` macro and expanded the `dict` macro. This really isn't something we should be doing for macros but I can't deny it looks a lot neater than repeated code.
2018-06-25Use charmap “ and ”Rangi
2018-06-25Single newline at the end of filesRangi
2018-06-24Fix triple newlines left over from removing address commentsRangi
2018-06-25Remove even more address commentsmid-kid
That should be all of them this time
2018-06-24Remove all address commentsmid-kid
2018-06-20Merge pull request #526 from atasro2/masteryenatch
reword
2018-06-14fixed a typoMCboy
being the grammar nazi i am i noticed a grammar error so i forked pokecrystal to fix it ;)