summaryrefslogtreecommitdiff
path: root/engine
AgeCommit message (Collapse)Author
2018-07-27Merge branch 'master' of https://github.com/pret/pokecrystalmid-kid
2018-07-26Remove a documented bug that's not really a bugmid-kid
I mean, technically, being able to read beyond a data table's size is bad practice, but there's so many cases of this that it's not worth mentioning. For most of these cases, at least, it's safe to assume the index won't ever get high enough to surpass such a table's length, because it's either hardcoded or decided by the game without the use of uncontrollable data. As such, they don't expose any actual bugs.
2018-07-26Consistently use the diff format in bugs_and_glitchesmid-kid
2018-07-24MON_STAT_EXP - 1 → MON_EXP + 2Rangi
2018-07-23wPokeAnimStruct matches wPokeAnimStructEndRangi
2018-07-23StringCmp → CompareBytes; CompareLong → CompareBytesLongRangi
hStringCmpString[1/2] → h[EnemyMon/PartyMon1]Speed
2018-07-23Consistent routine naming convention: 'Foo' wraps '_Foo'Rangi
2018-07-22ANIM_MON_UNUSED → ANIM_MON_HOFRangi
2018-07-21Merge branch 'master' of hyperdriveguy/pokecrystalIIMarckus
2018-07-20Add Counter and Mirror Coat bugfixHyperdriveguy
2018-07-18Fix usage of NUM_UNOWNmid-kid
2018-07-18Fix misnamed character codesmid-kid
Some character codes were erroneously named after their text command counterparts. This has caused a lot of confusion with naming their functions and with other things. I've also removed the `dict2` macro and expanded the `dict` macro. This really isn't something we should be doing for macros but I can't deny it looks a lot neater than repeated code.
2018-07-18Remove some more address commentsmid-kid
2018-07-18Make proper cmdqueue constantsmid-kid
2018-07-18Fix anim_ret_commandmid-kid
2018-07-16Fewer uses of 'Thing2 - Thing1' for sizeof(Thing)Rangi
2018-07-15More OAM coordinate consistencyRangi
2018-07-13Comments for ToggleMaptileDecorationsRangi
2018-07-11Replace more hex values with constants or decimalRangi
2018-07-10Use more options constantsRangi
2018-07-05TileAnimationPalette → AnimateWaterPaletteRangi
2018-07-04Use TRUE/FALSE for wSaveFileExistsRangi
2018-07-04Miscellaneous reorganization fixesRangi
2018-06-30" " → "┘" + 1Rangi
2018-06-30Use significant values 5, 6, and 7Rangi
2018-06-30No linebreakRangi
2018-06-28Add more collision nybble constantsRangi
2018-06-25Use specific constants for overwritten text tilesRangi
2018-06-25Use charmap valuesRangi
2018-06-25"┘" + 1 == " "Rangi
Using X+1 makes sense when X is the last control character in a contiguous group, but "┘" is not, so we can use the first non-control character
2018-06-25Use charmap “ and ”Rangi
2018-06-25Merge events_2.asm with events.asmRangi
(events_2.asm was only separate because scripting.asm intervenes; but other files have a similar "code / INCLUDE self-contained code / more code" structure to this)
2018-06-25Keep more data/ INCLUDEs with relevant routinesRangi
2018-06-25No space between labels and bodiesRangi
2018-06-25Single newline at the end of filesRangi
2018-06-25Remove more triple newlinesRangi
2018-06-24Fix triple newlines left over from removing address commentsRangi
2018-06-24Remove more address commentsRangi
2018-06-24Merge branch 'master' of https://github.com/pret/pokecrystalRangi
# Conflicts: # engine/items/mart.asm
2018-06-25Remove even more address commentsmid-kid
That should be all of them this time
2018-06-24NUM_GRASSMON * 2Rangi
2018-06-24NUM_WATERMONRangi
2018-06-24WATER_WILDDATA_LENGTHRangi
2018-06-24FISHGROUP_DATA_LENGTHRangi
2018-06-24Remove all address commentsmid-kid
2018-06-23wCurMartEnd - wCurMart = 16Rangi
2018-06-23Add STANDARDMART_* jumptable index constantsRangi
2018-06-23Use direct tile IDs, not charmap entries, since they don't correspond ↵Rangi
correctly (e.g. "┌" is not the top-right corner)
2018-06-20Merge pull request #526 from atasro2/masteryenatch
reword
2018-06-14fixed a typoMCboy
being the grammar nazi i am i noticed a grammar error so i forked pokecrystal to fix it ;)