summaryrefslogtreecommitdiff
path: root/engine
AgeCommit message (Collapse)Author
2017-12-11Document macros/map.asmRemy Oukaour
Rename MORN/DAY/NITE to MORN_F/DAY_F/NITE_F; use MORN/DAY/NITE for shifted values (cleaner for person_events) Prefix FLOOR to the `elevfloor` constants
2017-12-11Rename overworld sprite files, consistent with their constantsRemy Oukaour
2017-12-10PokeCenter → Pokecenter (consistent with the POKECENTER map constants)Remy Oukaour
2017-12-10Use new palette constantsRemy Oukaour
2017-12-10Consistent capitalization for map names, matching their constantsRemy Oukaour
2017-12-10Use correct WRAM labels for intro/title scenesRemy Oukaour
Remove outdated WRAM alias comments
2017-12-10Consistent code formatting: no redundant `a`s and spaces after commasRemy Oukaour
2017-12-09Move some gfx/unknown/ files into meaningful directoriesRemy Oukaour
2017-12-09Move some gfx/misc/ files into meaningful directoriesRemy Oukaour
2017-12-09Consistent pointer labels in WRAMRemy Oukaour
2017-12-09More WRAM cleanupRemy Oukaour
2017-12-09More WRAM organizationRemy Oukaour
2017-12-09Further WRAM organizationRemy Oukaour
2017-12-09More WRAM organizationRemy Oukaour
2017-12-09Start organizing WRAMRemy Oukaour
- Use db and dw when they're more meaningful than ds 1/2 - Use unions to group related labels
2017-12-09Define more charmap characters and use them in place of hard-coded numbersRemy Oukaour
2017-12-09Document constants with comments, actual names, and more thorough usageRemy Oukaour
2017-11-30Label all of PARTYMENUACTION_*mid-kid
It's pretty clear what it's used for. PartyMenuActionText is used for two things: 1) Storing what kind of action we're going to do (<$10) 2) Storing the text for some kind of healing stuff I'm not entirely sure (>=$f0) In the former case, if GetPartyMenuTilemapPointers is ran, it will be used to pick a sequence of actions that should be done, specified in the table, and it'll print the corresponding string using the PartyMenuStrings table. The items in the sequence of actions that should be done are in WritePartyMenuTilemap. Strangely enough, one possible value is left completely unused: PARTYMENUACTION_GIVE_MON_FEMALE. It works in the exact same way as it's male counterpart, and as such I don't believe it was used in the japanese version either, since it doesn't matter which gender your 'mon is when you put 'em in the daycare.
2017-11-29Fix some SPRITE_ANIM_FRAMESET_ constantsmid-kid
Thanks to @roukaour for the fixes.
2017-11-26Add MobileError-related labelsmid-kid
This function is called from a few different places in the mobile code, including from one special that is only executed when the BattleTowerRoomMenu special returns with a non-zero code. Since that special causes a blue "error" screen to appear, that looks the exact same as the one you'd get when trying to connect from the mobile trade corner/battle colosseum in a Pokémon Center's top floor, and this function contains a bunch of japanese strings in a jumptable, I think it's reasonable to assume it should be called "DisplayMobileError".
2017-11-25Label BattleTowerRoomMenumid-kid
All of the functions called by it are prefixed with BattleTowerRoomMenu, but a bunch of them seem more generic than that, since they're part of different mobile menus. Also called another menu jumptable BattleTowerRoomMenu2 for the lack of a better name (only the Yes/No menu functions are used in western crystal). The names of the more generic functions should be fixed when we start labelling other menus.
2017-11-21Merge pull request #395 from surskitty/masterMarcus Huderle
Some Script Labels
2017-11-16CeruleanCaveNane -> CeruleanCaveNamemid-kid
2017-11-03Label some functions in gfx/load_pics.asmpfero
A few projects I looked around in used these same labels for these functions, and it looks like they describe these functions properly. Also fixed usage of BANK() in a few places.
2017-10-29Define GetWarpSFXpfero
This function checks the current tile at the player's feet, and returns an appropriate SFX that should be played when warping from it.
2017-10-28Fix WATERTILE/WALLTILE constantspfero
WATRTILE was wrongly defined as 15, and WALLTILE as 1. Those had to be flipped around. This has allowed for us to replace inmediate values with these constants in several places to improve readability. WATRTILE was renamed to WATERTILE in the name of readability.
2017-10-25Labelling a few mom scripts.surskitty
2017-09-24Merge pull request #389 from yenatch/rgbds-3yenatch
rgbds 0.3.3
2017-09-23Fix section linkingPikalaxALT
Create linker script and float all sections
2017-08-24Fix unused Constant for Happinessi0brendan0
The HAPPINESS_TO_EVOLVE constant is what's supposed to be used to give the number for when a Pokemon should evolve by happiness. The constant was not put in place so it is never used, instead the original 220 was put.
2017-06-24Merge pull request #370 from yenatch/graphicsyenatch
png everywhere
2017-06-24Fix gfx/miscyenatch
2017-06-24pngs in gfx/unknownyenatch
2017-06-21pngs in gfx/titleyenatch
2017-06-21pngs in gfx/splashyenatch
2017-06-21pngs in gfx/pokegearyenatch
- flymap_label_border.2bpp was actually 1bpp
2017-06-09Replace ‘jp [hl]’ with ‘jp hl’Ben10do
The former is arguably misleading (as you don’t access the memory location in hl to retrieve the jump location), and is consequently deprecated in newer versions of rgbds. This fix silences these deprecation warnings.
2017-05-28Fix no newline at eof in engine/time.asmyenatch
2017-03-24Revert "Fix floating sections"Ben10do
This reverts commit e28b88f56d666484b994fc9cf28cc5d4cf50c803.
2017-03-15Fix floating sectionsAntonioND
This is needed so that rgblink doesn't move them around after modifying it's placement algorithm. Signed-off-by: AntonioND <antonio_nd@outlook.com>
2017-02-22Strip address comments.IIMarckus
2017-01-16Labels for Trainer Rankings stat tracking functionshatschky
2016-12-30Merge branch 'master' of https://github.com/PikalaxALT/pokecrystal into ↵YamaArashi
PikalaxALT-master
2016-10-29Fix an incorrect comment regarding breedingFredrik Ljungdahl
If Defense DV match and lower 3 DVs match father+mother, breeding chance isn't maximized, but prevented. Possibly done to combat in-breeding
2016-09-27Person action and facing labels, part 2PikalaxALT
2016-09-27Person action and facing labels, part 1PikalaxALT
2016-07-29pitchoffset macro to replace forceoctavePikalaxALT
2016-06-25These are actually .1bpp filesScott Norton
2016-06-13hLCDCPointer and InitListpikalaxalt
2016-06-07Fix indentation in many placespikalaxalt