summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorghoulslash <41651341+ghoulslash@users.noreply.github.com>2020-07-15 20:05:10 -0600
committerghoulslash <41651341+ghoulslash@users.noreply.github.com>2020-07-15 20:05:10 -0600
commit8f322d4b00fdbf33b8ccd4601a9f3839dbf7afe7 (patch)
tree6ab5bca9dea4de9cfe532902ed6f9c5c74ea8c85
parenteeac6db314fb5accf29332f4195c740694f57e70 (diff)
Updated Fix Snow Weather (markdown)
-rw-r--r--Fix-Snow-Weather.md10
1 files changed, 7 insertions, 3 deletions
diff --git a/Fix-Snow-Weather.md b/Fix-Snow-Weather.md
index 69b82bf..de6cec9 100644
--- a/Fix-Snow-Weather.md
+++ b/Fix-Snow-Weather.md
@@ -4,8 +4,6 @@ Credit to daniilS for the binary implementation this is based off of
In vanilla emerald (and Fire Red!) the WEATHER_SNOW is broken and will only emit a few snowflakes before stopping. Let's fix it!
-**BUG:** entering/closing a menu sometimes causes snow to isolate to specific x coordinates
-
For starters, open [src/field_weather_effects.c](../blob/master/src/field_weather_effect.c)
### Increase the number of snowflakes (optional)
@@ -39,4 +37,10 @@ Find the function `UpdateSnowflakeSprite`, and delete the following code (lines
sprite->invisible = TRUE;
sprite->callback = WaitSnowflakeSprite;
}
-``` \ No newline at end of file
+```
+
+### Fix snow spawning upon returning to the overworld
+The snow is spawned based on gSpriteCoordOffsetX/Y, which is not updated until after the weather is initialized. To fix this, open [src/field_weather.c](../blob/master/src/field_weather.c).
+
+1. First, add `#include "field_camera.h"` to the top of the file somewhere.
+2. Next, add `UpdateCameraPanning();` before `sWeatherFuncs[gWeatherPtr->currWeather].initAll();` in `Task_WeatherInit`