summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorghoulslash <41651341+ghoulslash@users.noreply.github.com>2020-07-23 22:52:17 -0600
committerghoulslash <41651341+ghoulslash@users.noreply.github.com>2020-07-23 22:52:17 -0600
commit9b74414935f09b92ae24397a99672f96bced5ee8 (patch)
tree0e02bb0cacc76a53d53a05dc908e1f1da71a7c0c
parent0e162cddeb6032c3ca44d27b28529868af126957 (diff)
Created Surfing Dismount Ground Effects (markdown)
-rw-r--r--Surfing-Dismount-Ground-Effects.md16
1 files changed, 16 insertions, 0 deletions
diff --git a/Surfing-Dismount-Ground-Effects.md b/Surfing-Dismount-Ground-Effects.md
new file mode 100644
index 0000000..d292e4e
--- /dev/null
+++ b/Surfing-Dismount-Ground-Effects.md
@@ -0,0 +1,16 @@
+### Fix Surfing Dismount Ground Effects Bug
+
+In vanilla emerald, the ground effects are not updated at the end of the surf dismount code. So if you dismount into tall grass, for example, you will appear over the grass. This is subtle but easily fixable so why not do so for consistency!
+
+**Before** &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; **After**
+
+<a href="https://imgur.com/tzppyWl"><img src="https://i.imgur.com/tzppyWl.gif" title="source: imgur.com" /></a> <a href="https://imgur.com/0VdHg2d"><img src="https://i.imgur.com/0VdHg2d.gif" title="source: imgur.com" /></a>
+
+
+This fix is very simple. Open [src/field_player_avatar.c](../blob/master/src/field_player_avatar.c) and find the function `Task_WaitStopSurfing`. Before the line `DestroyTask(taskId)`, add the following:
+```c
+playerObjEvent->triggerGroundEffectsOnMove = TRUE;
+MovementType_Player(&gSprites[gPlayerAvatar.spriteId]);
+```
+
+That's it! \ No newline at end of file