summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGriffinR <griffin.g.richards@gmail.com>2022-03-14 15:54:47 -0400
committerGriffinR <griffin.g.richards@gmail.com>2022-03-14 15:54:47 -0400
commit0a0157b62c29172eabd07f0c0eb02d6567957c2c (patch)
treeb6a7639da8361247d1ad1cb38fb6531839dd92bc
parentbb91b1b0d1cf70fa49cb0b1f2a309ad541927164 (diff)
Name unknown_16.png
-rwxr-xr-xgraphics/field_effects/pics/jump_long_grass.png (renamed from graphics/field_effects/pics/unknown_16.png)bin567 -> 567 bytes
-rw-r--r--spritesheet_rules.mk2
-rwxr-xr-xsrc/data/object_events/object_event_graphics.h2
-rwxr-xr-xsrc/field_effect_helpers.c2
4 files changed, 4 insertions, 2 deletions
diff --git a/graphics/field_effects/pics/unknown_16.png b/graphics/field_effects/pics/jump_long_grass.png
index bb4789f9f..bb4789f9f 100755
--- a/graphics/field_effects/pics/unknown_16.png
+++ b/graphics/field_effects/pics/jump_long_grass.png
Binary files differ
diff --git a/spritesheet_rules.mk b/spritesheet_rules.mk
index ae7971960..9fb184638 100644
--- a/spritesheet_rules.mk
+++ b/spritesheet_rules.mk
@@ -636,7 +636,7 @@ $(FLDEFFGFXDIR)/tall_grass.4bpp: %.4bpp: %.png
$(FLDEFFGFXDIR)/tree_disguise.4bpp: %.4bpp: %.png
$(GFX) $< $@ -mwidth 2 -mheight 4
-$(FLDEFFGFXDIR)/unknown_16.4bpp: %.4bpp: %.png
+$(FLDEFFGFXDIR)/jump_long_grass.4bpp: %.4bpp: %.png
$(GFX) $< $@ -mwidth 2 -mheight 2
$(FLDEFFGFXDIR)/unknown_17.4bpp: %.4bpp: %.png
diff --git a/src/data/object_events/object_event_graphics.h b/src/data/object_events/object_event_graphics.h
index 81d83a856..6ee56cc78 100755
--- a/src/data/object_events/object_event_graphics.h
+++ b/src/data/object_events/object_event_graphics.h
@@ -305,7 +305,7 @@ const u16 gFieldEffectObjectPalette1[] = INCBIN_U16("graphics/field_effects/pale
const u32 gFieldEffectObjectPic_GroundImpactDust[] = INCBIN_U32("graphics/field_effects/pics/ground_impact_dust.4bpp");
const u32 gFieldEffectObjectPic_JumpTallGrass[] = INCBIN_U32("graphics/field_effects/pics/jump_tall_grass.4bpp");
const u32 gUnusedGrass3[] = INCBIN_U32("graphics/field_effects/pics/unused_grass_3.4bpp");
-const u32 gFieldEffectObjectPic_JumpLongGrass[] = INCBIN_U32("graphics/field_effects/pics/unknown_16.4bpp");
+const u32 gFieldEffectObjectPic_JumpLongGrass[] = INCBIN_U32("graphics/field_effects/pics/jump_long_grass.4bpp");
const u32 gFieldEffectObjectPic_Unknown17[] = INCBIN_U32("graphics/field_effects/pics/unknown_17.4bpp");
const u32 gFieldEffectObjectPic_UnusedGrass2[] = INCBIN_U32("graphics/field_effects/pics/unused_grass_2.4bpp");
const u32 gFieldEffectObjectPic_LongGrass[] = INCBIN_U32("graphics/field_effects/pics/long_grass.4bpp");
diff --git a/src/field_effect_helpers.c b/src/field_effect_helpers.c
index 65617038d..036ff33f2 100755
--- a/src/field_effect_helpers.c
+++ b/src/field_effect_helpers.c
@@ -487,6 +487,8 @@ void UpdateLongGrassFieldEffect(struct Sprite *sprite)
#undef sCurrentMap
#undef sObjectMoved
+// Effectively unused as it's not possible in vanilla to jump onto long grass (no adjacent ledges, and can't ride the Acro Bike in it).
+// The graphics for this effect do not visually correspond to tall grass either. Perhaps these graphics were its original design?
u32 FldEff_JumpLongGrass(void)
{
u8 spriteId;