diff options
| author | GriffinR <griffin.g.richards@gmail.com> | 2020-10-11 19:16:42 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-11 19:16:42 -0400 |
| commit | 46212e0d14f411e0bce35f0e968820d2b35daeb2 (patch) | |
| tree | 3c8fc07e6358c9b71254042b3ac8fee284492e5a | |
| parent | 17a77c9018291aed9c70f0aa05ca0755a5677e87 (diff) | |
| parent | 1472111c5d158e72f4cf80c075a221e98d814250 (diff) | |
Merge pull request #1230 from GriffinRichards/fixubcomm
Fix PutAwayDecorationLoop UB comment
| -rw-r--r-- | data/scripts/secret_base.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/data/scripts/secret_base.inc b/data/scripts/secret_base.inc index 132bdd19c..4a20de9a6 100644 --- a/data/scripts/secret_base.inc +++ b/data/scripts/secret_base.inc @@ -308,7 +308,7 @@ SecretBase_EventScript_PutAwayDecorationLoop:: @ 8275D39 compare VAR_0x8005, 0 goto_if_eq SecretBase_EventScript_PutAwayDecorationLoop removeobject VAR_0x8006 - setflag VAR_0x8005 @ UB: GF likely meant setvar here; setflag 0x8005 is out of bounds + setflag VAR_0x8005 @ UB: VAR_0x8005 is set to a flag by PutAwayDecorationIteration, but ScrCmd_setflag doesn't use VarGet goto SecretBase_EventScript_PutAwayDecorationLoop end |