diff options
| author | PikalaxALT <PikalaxALT@users.noreply.github.com> | 2020-09-27 19:25:19 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-09-27 19:25:19 -0400 |
| commit | cb69835536f0bfca0ff59ea7402725ffc81c336f (patch) | |
| tree | 2d49b9a906e6947ed875546afae4cd270cede0ae | |
| parent | 46d748a219bf6d34519d89e1d351b722a2ea9521 (diff) | |
| parent | 933e180dd6fd721742af60cd209af11bab7e5ca4 (diff) | |
Merge pull request #1210 from ExpoSeed/pull-request-template
More concise pull request template
| -rw-r--r-- | .github/pull_request_template.md | 29 |
1 files changed, 17 insertions, 12 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0b38a656c..a56a168b8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,17 +1,22 @@ -# Pull request into pret/pokeemerald +<!--- Provide a general summary of your changes in the Title above --> -## Instructions -Please complete both the questionnaire and the checklist below. This is required for the PR to be merged. Failure to do this may result in a ban from contributions. - -## Questionnaire -1. What is your Discord username? (name#numbers, e.g. PikalaxALT#5823) -2. What is the purpose of this pull request? (decompilation, documentation, bug fixes, typo correction, code style refactor) +## Description +<!--- Describe your changes in detail --> +## Type of changes +<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> +- [ ] Decompilation (matching, fixing nonmatching, fakematching, etc.) +- [ ] Documentation (naming symbols, commenting, etc.) +- [ ] Style (code style refactors, typo, etc.) +- [ ] Other: <!--- replace this comment with your type of change --> ## Checklist -- [ ] I am a member of the [pret discord server](https://discord.gg/d5dubZ3). -- [ ] I have run `make compare modern` on my local machine to ensure that the project compiles correctly. +<!--- Go over all the following points, and put an `x` in all the boxes that apply. --> +- [ ] I am a member of the [pret Discord server](https://discord.gg/d5dubZ3). +- [ ] `make compare` and `make compare modern` on my local machine outputs . +- [ ] My code follows the code style of this project. - [ ] If I am fixing a bug or undefined behavior in the modern build, I have documented the bug and tested the fix locally. -- [ ] My changes are not informed by the leaked source code, or I have disclosed my use of the leaks in the discord. -- [ ] I have answered all questions truthfully, including this one. -- [ ] I am not a robot. +- [ ] All my usage, if any, of the leaked source code has been disclosed in pret's server. + +## **Discord contact info** +<!--- formatted as name#numbers, e.g. PikalaxALT#5823 --> |