summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGriffinR <griffin.g.richards@gmail.com>2021-11-17 15:11:23 -0500
committerGitHub <noreply@github.com>2021-11-17 15:11:23 -0500
commitcfb9ae40d7d8eb84d89da2bb89410c8643f46531 (patch)
treed2e154ddff1bbb1d2c3addd50de284b016827c6a
parentecb13cdbf722aacbceca1b7a2e7514e5dd1ec83a (diff)
parentec97a21f95c82f3ec8c6c42de5e71dbdf80f4049 (diff)
Merge pull request #1557 from GriffinRichards/fix-calcrom-0
Fix calcrom's handling of 0s
-rwxr-xr-x.github/calcrom/calcrom.pl9
1 files changed, 6 insertions, 3 deletions
diff --git a/.github/calcrom/calcrom.pl b/.github/calcrom/calcrom.pl
index 37ebcb4d2..9fbd95994 100755
--- a/.github/calcrom/calcrom.pl
+++ b/.github/calcrom/calcrom.pl
@@ -104,16 +104,19 @@ my $partial_documented_as_string;
# Performing addition on a string converts it to a number. Any string that fails
# to convert to a number becomes 0. So if our converted number is 0, but our string
# is nonzero, then the conversion was an error.
+$undocumented_as_string =~ s/^\s+|\s+$//g;
my $undocumented = $undocumented_as_string + 0;
-(($undocumented != 0) and ($undocumented_as_string ne "0"))
+(($undocumented != 0) or (($undocumented == 0) and ($undocumented_as_string eq "0")))
or die "ERROR: Cannot convert string to num: '$undocumented_as_string'";
+$partial_documented_as_string =~ s/^\s+|\s+$//g;
my $partial_documented = $partial_documented_as_string + 0;
-(($partial_documented != 0) and ($partial_documented_as_string ne "0"))
+(($partial_documented != 0) or (($partial_documented == 0) and ($partial_documented_as_string eq "0")))
or die "ERROR: Cannot convert string to num: '$partial_documented_as_string'";
+$total_syms_as_string =~ s/^\s+|\s+$//g;
my $total_syms = $total_syms_as_string + 0;
-(($total_syms != 0) and ($total_syms_as_string ne "0"))
+(($total_syms != 0) or (($total_syms == 0) and ($total_syms_as_string eq "0")))
or die "ERROR: Cannot convert string to num: '$total_syms_as_string'";
($total_syms != 0)